46548 Commits

Author SHA1 Message Date
Twinaphex
456b891994
Merge pull request #7788 from orbea/quotes
qb: Minor cleanup.
2018-12-22 19:45:37 +01:00
Twinaphex
f353feba8a
Merge pull request #7789 from jdgleaver/buff-size-fix
Fix gcc -Wformat-truncation= warning (redux)
2018-12-22 19:45:24 +01:00
Twinaphex
326395ff17
Merge pull request #7794 from orbea/load
menu: Reset position after pushing quick menu.
2018-12-22 19:45:08 +01:00
Twinaphex
1df95bb28b
Merge pull request #7793 from fr500/fixes
move core sideloading to load core menu
2018-12-22 19:44:45 +01:00
orbea
4da7092aff menu: Reset position after pushing quick menu.
Fixes:
  https://github.com/libretro/RetroArch/issues/5595
  https://github.com/libretro/RetroArch/issues/2506
2018-12-21 18:43:14 -08:00
radius
c70e322496 cleanup 2018-12-21 18:19:48 -05:00
radius
09deb96397 move core sideloading to load core menu 2018-12-21 18:17:17 -05:00
orbea
7e4723e37a qb: Minor cleanup.
This uses safer quoting and removes an unneeded use of printf.

Fixes the following shellcheck warning.

In qb/qb.libs.sh line 143:
	if [ $3 ]; then
             ^-- SC2086: Double quote to prevent globbing and word splitting.

v2: Remove redundant conditional.
2018-12-21 08:32:01 -08:00
jdgleaver
c2d4b70f8c menu_displaylist_parse_options_remappings(): increase buffer sizes, remove string precision qualifier (alternative to PR #7782) 2018-12-21 16:12:20 +00:00
Twinaphex
b55ed9e3ce
Merge pull request #7783 from theheroGAC/patch-40
Update msg_hash_it.h
2018-12-21 15:25:34 +01:00
Twinaphex
c3f2c49e84
Merge pull request #7784 from orbea/dir
menu: Use the default dir for recording output when unset.
2018-12-21 15:25:28 +01:00
Twinaphex
7ec32337b5
Merge pull request #7786 from orbea/version
Remove some hardcoded version strings.
2018-12-21 15:25:18 +01:00
Twinaphex
e239a46800
Merge pull request #7787 from ensra/netbsd-audio
Add an AudioIO dirver for NetBSD and Solaris.
2018-12-21 15:24:55 +01:00
nia
1721bd07c4 Use the correct message when printing macro tests. 2018-12-21 14:23:13 +00:00
nia
3ef9bbb592 Add an AudioIO dirver for NetBSD and Solaris. 2018-12-21 14:15:30 +00:00
orbea
6c4f0be0a5 Remove some hardcoded version strings. 2018-12-20 22:13:19 -08:00
orbea
2ab78dc67b menu: Use the default dir for recording output when unset. 2018-12-20 16:13:10 -08:00
theheroGAC
970e3515b1
Update msg_hash_it.h 2018-12-20 23:08:04 +01:00
Twinaphex
1d3874a142
Merge pull request #7779 from jdgleaver/rgui-colours
(RGUI) Enable customisation of background and border colours
2018-12-20 20:51:12 +01:00
Twinaphex
3bd1c3fa6a
Merge pull request #7782 from orbea/format
Fix gcc -Wformat-truncation= warning.
2018-12-20 20:49:37 +01:00
Twinaphex
e9e917ab29
Merge pull request #7781 from orbea/c89
Makefile.common: Remove redundant conditionals.
2018-12-20 20:48:58 +01:00
Twinaphex
1532b75d26
Merge pull request #7780 from orbea/dir
menu: Fix directory settings.
2018-12-20 20:48:19 +01:00
orbea
e6eedd05f5 Fix gcc -Wformat-truncation= warning.
menu/menu_displaylist.c: In function ‘menu_displaylist_ctl’:
menu/menu_displaylist.c:3441:28: warning: ‘ [’ directive output may be truncated writing 2 bytes into a region of size between 1 and 255 [-Wformat-truncation=]
                         "%s [%s %u]", descriptor, msg_hash_to_str(MENU_ENUM_LABEL_VALUE_USER), p + 1);
                            ^~
menu/menu_displaylist.c:3441:25: note: using the range [0, 4294967295] for directive argument
                         "%s [%s %u]", descriptor, msg_hash_to_str(MENU_ENUM_LABEL_VALUE_USER), p + 1);
                         ^~~~~~~~~~~~
menu/menu_displaylist.c:3440:16: note: ‘snprintf’ output 6 or more bytes (assuming 260) into a destination of size 255
                snprintf(desc_label, sizeof(desc_label),
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         "%s [%s %u]", descriptor, msg_hash_to_str(MENU_ENUM_LABEL_VALUE_USER), p + 1);
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2018-12-20 11:45:48 -08:00
orbea
5175c67381 menu: Fix directory settings.
The "Recording Output" and "Screenshot" directory settings accidentally
overwrote each other.

Fixes https://github.com/libretro/RetroArch/issues/7776
2018-12-20 11:13:28 -08:00
orbea
066bbd1a29 Makefile.common: Remove redundant conditionals.
C89 builds are only used for the qb build system currently and these are
already checked in qb/config.params.sh.

Additionally the HAVE_NETWORKING check is handled with qb/config.lib.sh
where HAVE_SSL and HAVE_BUILTINMBEDTLS are disabled if networking is
also disabled. The other build systems should never define HAVE_SSL or
HAVE_BUILTINMBEDTLS without HAVE_NETWORKING. Also there are no other
build systems that rely on Makefile.common using this yet.
2018-12-20 10:49:23 -08:00
jdgleaver
f603d4ec30 (RGUI) Enable customisation of background and border colours 2018-12-20 16:13:16 +00:00
Brad Parker
d41bb64d17 remove unused code 2018-12-20 09:00:48 -05:00
Twinaphex
a0a22a044a
Merge pull request #7773 from orbea/comment
Makefile.ctr: Add missing comment.
2018-12-20 13:58:36 +01:00
Twinaphex
4f270449f9
Merge pull request #7774 from bparker06/hold_start
add option to toggle menu by holding down start button
2018-12-20 13:58:18 +01:00
Brad Parker
458bb9fbb5 add option to toggle menu by holding down start button 2018-12-19 14:53:17 -05:00
orbea
2c09a6f37b Makefile.ctr: Add missing comment. 2018-12-19 11:27:10 -08:00
Brad Parker
fd93e5e26e Update CHANGES.md 2018-12-19 12:04:11 -05:00
Twinaphex
26568a6bc2
Merge pull request #7770 from jdgleaver/rgui-user-index
(RGUI) Add user index label to control menu entries
2018-12-19 17:47:53 +01:00
Twinaphex
a7bb1e60aa
Merge pull request #7771 from libretro/sgc-menu-animation
Animations deleted whilst in update loop may cause crash
2018-12-19 17:45:58 +01:00
jdgleaver
f68d756af3 (RGUI) Add user index label to control menu entries 2018-12-19 12:19:29 +00:00
Twinaphex
7835d0c54c
Merge pull request #7745 from orbea/mbedtls
Support building with the system mbedtls.
2018-12-19 01:53:14 +01:00
Twinaphex
0b0a21b742
Merge pull request #7768 from jdgleaver/3ds-named-inputs
(3DS) Add joypad input labels
2018-12-19 01:21:05 +01:00
Stuart Carnie
11a7d34358
fix: animations deleted during update mutate tween list, causing crash
defer deletes resulting from callbacks until after update loop
2018-12-18 17:12:19 -07:00
jdgleaver
37acbd1ecf (3DS) Add joypad input labels 2018-12-18 16:30:05 +00:00
Twinaphex
22fcd0be67
Merge pull request #7762 from orbea/rgui
Fix gcc -Wformat-truncation= warnings.
2018-12-18 10:12:50 +01:00
Brad Parker
d6741651b7 net_socket_ssl: keep reading data from server until finished, fixes #7451 2018-12-18 03:01:52 -05:00
Twinaphex
c565bb1b0b
Merge pull request #7763 from bparker06/sideload_vfs
use filestream/VFS for core sideload
2018-12-17 21:40:32 +01:00
Brad Parker
4b323a45df paths can be const 2018-12-17 09:38:12 -05:00
Brad Parker
971591fb9c use filestream/VFS for core sideload 2018-12-17 09:25:52 -05:00
orbea
13e29308d5 Fix gcc -Wformat-truncation= warnings.
menu/drivers/rgui.c: In function ‘rgui_render’:
menu/drivers/rgui.c:670:53: warning: ‘%-*s’ directive output may be truncated writing up to 2147483648 bytes into a region of size between 0 and 252 [-Wformat-truncation=]
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                                     ^~~~
menu/drivers/rgui.c:676:13:
             type_str_buf);
             ~~~~~~~~~~~~
menu/drivers/rgui.c:670:42: note: assuming directive output of 254 bytes
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                          ^~~~~~~~~~~~~~~~
menu/drivers/rgui.c:670:7: note: ‘snprintf’ output between 4 and 4294967300 bytes into a destination of size 255
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_selected ? '>' : ' ',
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_title_buf,
             ~~~~~~~~~~~~~~~~
             entry_spacing,
             ~~~~~~~~~~~~~~
             type_str_buf);
             ~~~~~~~~~~~~~
menu/drivers/rgui.c:670:53: warning: ‘%-*s’ directive output may be truncated writing up to 2147483648 bytes into a region of size between 0 and 252 [-Wformat-truncation=]
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                                     ^~~~
menu/drivers/rgui.c:676:13:
             type_str_buf);
             ~~~~~~~~~~~~
menu/drivers/rgui.c:670:42: note: assuming directive output of 254 bytes
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                          ^~~~~~~~~~~~~~~~
menu/drivers/rgui.c:670:7: note: ‘snprintf’ output between 4 and 4294967300 bytes into a destination of size 255
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_selected ? '>' : ' ',
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_title_buf,
             ~~~~~~~~~~~~~~~~
             entry_spacing,
             ~~~~~~~~~~~~~~
             type_str_buf);
             ~~~~~~~~~~~~~
2018-12-16 20:22:53 -08:00
Twinaphex
af0bf7a992
Merge pull request #7761 from orbea/c89
Fix gcc warnings with C89_BUILD.
2018-12-17 05:18:13 +01:00
Twinaphex
6dcdb843e8
Merge pull request #7758 from fr500/sideload
Sideload
2018-12-17 05:15:41 +01:00
orbea
d557ab09ce Fix a gcc -Wformat= warning with C89_BUILD.
network/netplay/netplay_frontend.c: In function ‘netplay_announce_cb’:
network/netplay/netplay_frontend.c:734:32: warning: format ‘%X’ expects argument of type ‘unsigned int *’, but argument 3 has type ‘int *’ [-Wformat=]
                sscanf(val, "%08X", &host_room->gamecrc);
                             ~~~^   ~~~~~~~~~~~~~~~~~~~
                             %08X
2018-12-16 19:59:53 -08:00
orbea
14905e33e1 Fix more gcc -Wformat= warnings with C89_BUILD.
The "z" modifier was introduced in c99, but using "l" instead
seems to work.

setting_list.c: In function ‘setting_get_string_representation_size’:
setting_list.c:175:24: warning: ISO C90 does not support the ‘z’ gnu_printf length modifier [-Wformat=]
       snprintf(s, len, "%" PRI_SIZET,
                        ^~~
setting_list.c: In function ‘setting_get_string_representation_size_in_mb’:
setting_list.c:183:24: warning: ISO C90 does not support the ‘z’ gnu_printf length modifier [-Wformat=]
       snprintf(s, len, "%" PRI_SIZET,
                        ^~~
setting_list.c: In function ‘setting_set_with_string_representation’:
setting_list.c:508:24: warning: ISO C90 does not support the ‘z’ gnu_scanf length modifier [-Wformat=]
          sscanf(value, "%" PRI_SIZET, setting->value.target.sizet);
                        ^~~

libretro-common/file/config_file.c: In function ‘config_get_size_t’:
libretro-common/file/config_file.c:692:32: warning: ISO C90 does not support the ‘z’ gnu_scanf length modifier [-Wformat=]
       if (sscanf(entry->value, "%" PRI_SIZET, &val) == 1
2018-12-16 19:59:50 -08:00
orbea
169002ef7f Fix a gcc -Wformat= warning with C89_BUILD.
The posix spec claims "%r" is equivelent to "%I : %M : %S %p".

Source: http://pubs.opengroup.org/onlinepubs/9699919799/functions/strftime.html

menu/menu_driver.c:395:15: warning: ISO C90 does not support the ‘%r’ gnu_strftime format [-Wformat=]
             "%r", localtime(&time_));
               ^
2018-12-16 19:59:47 -08:00