mirror/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch synced 2025-03-28 19:20:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: animations deleted during update mutate tween list, causing crash

Browse Source 
defer deletes resulting from callbacks until after update loop
This commit is contained in:
Stuart Carnie 2018-12-18 17:12:19 -07:00
parent 22fcd0be67
commit 11a7d34358
No known key found for this signature in database
GPG Key ID: 848D9C9718D78B4F
1 changed files with 41 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
menu/menu_animation.c
View File

@ -44,6 +44,7 @@ struct tween
easing_cb easing;
tween_cb cb;
void *userdata;
bool deleted;
};
DA_TYPEDEF(struct tween, tween_array_t)
@ -52,6 +53,7 @@ struct menu_animation
{
tween_array_t list;
tween_array_t pending;
bool pending_deletes;
bool in_update;
};
@ -341,6 +343,7 @@ bool menu_animation_push(menu_animation_ctx_entry_t *entry)
t.cb = entry->cb;
t.userdata = entry->userdata;
t.easing = NULL;
t.deleted = false;
switch (entry->easing_enum)
{
@ -471,7 +474,8 @@ bool menu_animation_update(float delta_time)
{
unsigned i;
anim.in_update = true;
anim.in_update = true;
anim.pending_deletes = false;
for(i = 0; i < da_count(anim.list); i++)
{
@ -496,6 +500,20 @@ bool menu_animation_update(float delta_time)
}
}
if (anim.pending_deletes)
{
for(i = 0; i < da_count(anim.list); i++)
{
struct tween *tween = da_getptr(anim.list, i);
if (tween->deleted)
{
da_delete(anim.list, i);
i--;
}
}
anim.pending_deletes = false;
}
if (da_count(anim.pending) > 0)
{
da_addn(anim.list, anim.pending.p, da_count(anim.pending));
@ -594,9 +612,17 @@ bool menu_animation_kill_by_tag(menu_animation_ctx_tag *tag)
struct tween *t = da_getptr(anim.list, i);
if (t->tag != *tag)
continue;
da_delete(anim.list, i);
--i;
if (anim.in_update)
{
t->deleted = true;
anim.pending_deletes = true;
}
else
{
da_delete(anim.list, i);
--i;
}
}
return true;
@ -615,9 +641,17 @@ void menu_animation_kill_by_subject(menu_animation_ctx_subject_t *subject)
{
if (t->subject != sub[j])
continue;
da_delete(anim.list, i);
--i;
if (anim.in_update)
{
t->deleted = true;
anim.pending_deletes = true;
}
else
{
da_delete(anim.list, i);
--i;
}
killed++;
break;