mirror of
https://github.com/protocolbuffers/protobuf-go.git
synced 2025-01-01 11:58:21 +00:00
71c6603a26
For a file "foo/bar.proto", put the FileDescriptor in "ProtoFile_foo_bar" rather than "Bar_fileDescriptor". Avoid name clashes when a package contains "a/foo.proto" and "b/foo.proto". Don't camelcase the filename: These vars weren't fully camelcased to begin with, and leaving the filename relatively unchanged is clearer and more predictable. Move "ProtoFile" from the end of the var name to the start, so that vars will sort better in packages with multiple descriptors. These changes do add a chance of name collision when the input filename begins with an uppercase letter: Foo.proto becomes "ProtoFile_Foo", which could be the result of camelcasing "proto_file.foo". The readability benefits seem worth it. Change-Id: If27d3a0d7b5bf3535aa1607a8579eb057c74d2dc Reviewed-on: https://go-review.googlesource.com/c/163199 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com> Reviewed-by: Herbie Ong <herbie@google.com> |
||
|---|---|---|
| .. | ||
| cmd | ||
| detrand | ||
| encoding | ||
| errors | ||
| fileinit | ||
| flags | ||
| impl | ||
| legacy | ||
| pragma | ||
| protogen/goldentest | ||
| scalar | ||
| set | ||
| testprotos | ||
| typefmt | ||
| value | ||