mirror/protobuf-go
1
0
Fork 0
mirror of https://github.com/protocolbuffers/protobuf-go.git synced 2025-04-15 23:42:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

internal/encoding/pack: don't depend on exact math.NaN bits

Browse Source 
This test examines the result of converting math.NaN() to a fixed byte
string. Change it to use a specific NaN value instead, since the value
returned by math.NaN is specified only as being a NaN, not a specific
one.

Use specific float32 and float64 NaN values, since the result of
converting a float64 NaN to a float32 can and does vary.

Fixes test failure on ARM.

Change-Id: Ia1517fdba768cdd88e5ee5f5af37f0b481e651b4
Reviewed-on: https://go-review.googlesource.com/c/162117
Reviewed-by: Herbie Ong <herbie@google.com>
This commit is contained in:
Damien Neil 2019-02-12 11:10:29 -08:00
parent f5db2df407
commit 3fa6d3f003
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/encoding/pack/pack_test.go
View File

@ -52,6 +52,8 @@ func dhex(s string) []byte {
}
func TestPack(t *testing.T) {
nan32 := math.Float32frombits(0x7fc00000)
nan64 := math.Float64frombits(0x7FF8000000000001)
tests := []struct {
raw []byte
msg Message
@ -126,7 +128,7 @@ func TestPack(t *testing.T) {
raw: dhex("3ddb0f49403a1401000000ffff7f7f0000c07f0000807f000080ff"),
msg: Message{
Tag{7, Fixed32Type}, Float32(math.Pi),
Tag{7, BytesType}, LengthPrefix{Float32(math.SmallestNonzeroFloat32), Float32(math.MaxFloat32), Float32(math.NaN()), Float32(math.Inf(+1)), Float32(math.Inf(-1))},
Tag{7, BytesType}, LengthPrefix{Float32(math.SmallestNonzeroFloat32), Float32(math.MaxFloat32), Float32(nan32), Float32(math.Inf(+1)), Float32(math.Inf(-1))},
},
wantOutSource: `pack.Message{
pack.Tag{7, pack.Fixed32Type}, pack.Float32(3.1415927),
@ -153,7 +155,7 @@ func TestPack(t *testing.T) {
raw: dhex("51182d4454fb21094052280100000000000000ffffffffffffef7f010000000000f87f000000000000f07f000000000000f0ff"),
msg: Message{
Tag{10, Fixed64Type}, Float64(math.Pi),
Tag{10, BytesType}, LengthPrefix{Float64(math.SmallestNonzeroFloat64), Float64(math.MaxFloat64), Float64(math.NaN()), Float64(math.Inf(+1)), Float64(math.Inf(-1))},
Tag{10, BytesType}, LengthPrefix{Float64(math.SmallestNonzeroFloat64), Float64(math.MaxFloat64), Float64(nan64), Float64(math.Inf(+1)), Float64(math.Inf(-1))},
},
wantOutMulti: `Message{
Tag{10, Fixed64}, Float64(3.141592653589793),