mirror of
https://github.com/protocolbuffers/protobuf-go.git
synced 2025-02-19 21:40:34 +00:00
37cbbeb558
The size cache is an int32. Store a -1 in it if the message size overflows, and fall back to recomputing the size if the value is negative. This means lamentable O(N^2) costs in marshaling, but that's better than silently producing invalid output. Also considered: Return an error. Avoids O(N^2) behavior, but gives the user no good choices if they don't care the output being slow. Encoding costs of messages this large are likely to be dominated by copying the bytes rather than the size operation anyway, so slow-but-correct seems like the most generally useful option. We could store valid values for the range (0x7fffffff,0xfffffffe) reserving only 0xffffffff as the overflow sentinel, but optimizing this case seems less important than the code being obviously correct. Fixes golang/protobuf#970. Change-Id: I44f59ff81fdfbc8672dd5aec959d5153a081aab9 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/220593 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>