mirror/protobuf-go
1
0
Fork 0
mirror of https://github.com/protocolbuffers/protobuf-go.git synced 2025-02-26 15:39:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

internal/impl: remove blocking TODO

Browse Source 
This TODO doesn't need to be addressed for v2 release.
Addressing this now would probably need to go through global testing,
which is not worth the effort now.

Change-Id: I44bf45e077c00e9a6462905193efb0bce41e9dd2
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/220345
Reviewed-by: Damien Neil <dneil@google.com>
This commit is contained in:
Joe Tsai 2020-02-20 11:00:10 -08:00 committed by Joe Tsai
parent 929c287d2b
commit fb5fde41cd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/impl/message_reflect.go
View File

@ -330,7 +330,7 @@ func (mi *MessageInfo) checkField(fd pref.FieldDescriptor) (*fieldInfo, pref.Ext
if fd.IsExtension() {
if fd.ContainingMessage().FullName() != mi.Desc.FullName() {
// TODO(blocks): Should this be exact containing message descriptor match?
// TODO: Should this be exact containing message descriptor match?
panic("mismatching containing message")
}
if !mi.Desc.ExtensionRanges().Has(fd.Number()) {