goldsimon
f3c860958f
-Wconversion (still far from finished) and other minor compilation fixes...
2017-07-06 22:47:11 +02:00
goldsimon
44f7a3cb0d
work on -Wconversion...
2017-07-05 22:31:58 +02:00
Dirk Ziegelmeier
5a27e97baf
smtp.c: Fix detecting overlength server names
...
Thanks to Axel Lin
2017-06-14 22:06:37 +02:00
Dirk Ziegelmeier
3073affaaf
Axel Lin correctly pointed out that there is no buffer overflow because smtp_server[SMTP_MAX_SERVERNAME_LEN + 1] - there is always room for terminating 0 byte
2017-06-14 14:11:27 +02:00
Dirk Ziegelmeier
3611b583f5
smtp.c, smtp_set_server_addr: Avoid smtp_server buffer overrun when server name length is SMTP_MAX_SERVERNAME_LEN -> "smtp_server[len] = 0" is an out-of-bound access
2017-06-14 12:40:58 +02:00
Axel Lin
4af438916a
apps/smtp: Ensure smtp_server is NULL terminated
...
Ensure we set correct setting when changing smtp_server setting.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2017-06-14 12:33:57 +02:00
goldsimon
bab7a32eec
Remove smtp_server when passing NULL to smtp_set_server_addr() (see patch #9373 for discussion)
2017-06-13 22:00:48 +02:00
Axel Lin
117d3abdf8
apps/smtp: Make smtp_state_str/smtp_result_strs/base64_table static
...
These tables are only referenced in smtp.c, so make them static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2017-06-13 21:57:03 +02:00
goldsimon
07cc25a9df
httpd: remove unnecessary "\0" suffix for CRLF string constant (see bug #51232 )
2017-06-13 21:53:35 +02:00
goldsimon
a92e838687
httpd: include hooks header file so that redefined defines/functions can be defined there
2017-06-13 21:13:45 +02:00
goldsimon
e80b2eb4cf
Fix mdns_resp_del_service
2017-05-12 13:21:42 +02:00
David Girault
c8b7759e10
mdns: added support for removing service in mdns responder
...
New function `mdns_resp_del_service()` added.
Signed-off-by: goldsimon <goldsimon@gmx.de>
2017-05-12 13:12:22 +02:00
Axel Lin
9dee346000
apps/smtp: Fix memory leak in smtp_send_mail_alloced error paths
...
Call smtp_free_struct(s) in all smtp_send_mail_alloced error paths to ensure
no memory leak.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2017-05-11 10:47:20 +02:00
goldsimon
ec9096be40
fixed typo in httpd debug message
2017-05-10 13:41:26 +02:00
Axel Lin
ae210967f2
apps/smtp: Fix memory leak if SMTP_BODYDH_MALLOC fails
...
Need to free s before return error.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2017-05-10 11:25:34 +02:00
Axel Lin
5bbe190b3b
apps/smtp: Make smtp_send_bodyh_data takes "const char **from" parameter
...
Fixes below build error:
cc -g -Wall -DLWIP_DEBUG -pedantic -Werror -Wparentheses -Wsequence-point -Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith -Wcast-qual -Wc++-compat -Wwrite-strings -Wold-style-definition -Wcast-align -Wmissing-prototypes -Wredundant-decls -Wnested-externs -Wno-address -Wunreachable-code -Wuninitialized -Wlogical-op -I. -I../../.. -I../../../../lwip/src/include -I../../../ports/unix/port/include -I../../../../mbedtls/include -Wno-redundant-decls -DLWIP_HAVE_MBEDTLS=1 -c ../../../../lwip/src/apps/smtp/smtp.c
../../../../lwip/src/apps/smtp/smtp.c: In function ‘smtp_send_body_data_handler’:
../../../../lwip/src/apps/smtp/smtp.c:1487:41: error: cast discards ‘const’ qualifier from pointer target type [-Werror=cast-qual]
if((res = smtp_send_bodyh_data(pcb, (char **)&s->body, &s->body_len))
^
../../../../lwip/src/apps/smtp/smtp.c:1507:47: error: cast discards ‘const’ qualifier from pointer target type [-Werror=cast-qual]
((res = smtp_send_bodyh_data(pcb, (char **)&s->body, &s->body_len)) == BDHALLDATASENT)
^
cc1: all warnings being treated as errors
../../Common.allports.mk:94: recipe for target 'smtp.o' failed
make: *** [smtp.o] Error 1
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2017-05-10 08:43:07 +02:00
Axel Lin
f5f34f138c
apps/smtp: Fix missing altcp conversion in smtp_send_bodyh_data
...
The pcb is "struct altcp_pcb *" so we cannot call tcp_sndbuf/tcp_write here.
Use altcp_sndbuf/altcp_write instead.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2017-05-10 08:18:00 +02:00
Axel Lin
b9d5399ec1
apps/smtp: Trivial typo fixes
...
s/smpt/smtp/g
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2017-05-10 08:06:49 +02:00
goldsimon
d36306e30b
sntp_process: fixed unused variable if sub-second time info is not used
2017-05-04 15:49:12 +02:00
Axel Lin
bf510fee51
SNMP: Cleanup unreachable code
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2017-05-04 09:15:29 +02:00
Daniel Elstner
ccf10a5023
SNTP: Avoid warning if debugging is disabled
2017-05-03 16:40:11 +02:00
goldsimon
39316bb9de
httpd: fixed bug #50915 (HTTP_IS_DATA_VOLATILE was wrong for LWIP_HTTPD_DYNAMIC_FILE_READ==1)
2017-05-03 09:57:12 +02:00
Dmitry
42eb98c9fc
Fix bugs in httpd with "LWIP_HTTPD_CUSTOM_FILES && LWIP_HTTPD_DYNAMIC_FILE_READ" when SSI tags (from '<' to '>' when they span from one read to the next or end at one read buffer) - bugs #50844 aqnd #50845
...
Signed-off-by: goldsimon <goldsimon@gmx.de>
2017-04-24 22:33:17 +02:00
Dirk Ziegelmeier
13f51a0318
Fix bug #50824 : Bug in SNTP POLL mode
...
Ignore all broken packets
Stop timeouts only when correct packet is received
2017-04-21 22:10:52 +02:00
goldsimon
554f5d7f9e
sntp: fix SNTP_LI_* bits; fix todo comment
2017-04-21 13:13:56 +02:00
goldsimon
84461e90e2
mqtt: fix shadowing global 'dup'
2017-04-21 07:23:32 +02:00
goldsimon
dfc57f0289
mqtt: move struct mqtt_client_s and inner structs to new file mqtt_priv.h (to hide it from apps but provide it for tests)
2017-04-12 21:50:58 +02:00
Joel Cunningham
557a11047d
Patch #9307 : Replace mem_malloc+memset with mem_calloc
...
Aside from reducing source code, on systems which use MEM_LIBC_MALLOC,
this has the potential to improve performance depending on the underlying
memory allocator
See http://stackoverflow.com/questions/2688466/why-mallocmemset-is-slower-than-calloc
2017-04-05 14:53:24 -05:00
goldsimon
97f4033a8a
bridgeif: improve documentation
2017-04-04 21:54:52 +02:00
Dirk Ziegelmeier
6559ffd848
Fix C++ style comment in altcp_tls_mbedtls.c
2017-03-31 13:05:04 +02:00
goldsimon
aa0601a66d
snmp_asn1_dec_tlv: explicitly check 'length_bytes > pbuf_stream->length' (for clarity, even if it would fail in pbuf_stream later)
2017-03-30 21:31:44 +02:00
goldsimon
4313bf2a74
altcp_tls_mbedtls: fix TX when lower write returns ERR_MEM
2017-03-30 14:55:37 +02:00
goldsimon
51dbd1a7c0
altcp: added altcp_get_port()
2017-03-30 14:19:31 +02:00
Dirk Ziegelmeier
4a7569fc2d
SNMP traps: Fix ignored return values
2017-03-30 13:01:10 +02:00
Dirk Ziegelmeier
132c285fd4
SNMP. Fix several ignored return values
2017-03-30 12:50:32 +02:00
Dirk Ziegelmeier
2673e635a3
Fix community string length copying - correctly handle long strings
2017-03-30 11:09:35 +02:00
Dirk Ziegelmeier
8d149e63a6
SNMP: strcpy -> strncpy, strlen -> strnlen
2017-03-30 08:57:53 +02:00
goldsimon
720f9b3a0b
fix compiling altcp_tls_mbedtls sources/headers if mbedtls is not available
2017-03-29 23:02:16 +02:00
Dirk Ziegelmeier
40df1474cc
SNMP: Advertise SNMPv3 support
2017-03-28 21:33:37 +02:00
Dirk Ziegelmeier
3266511ebb
Improve documentation, add TLS stuff
2017-03-28 21:25:49 +02:00
Dirk Ziegelmeier
9b6192bd65
Create smtp_opts.h and add SMTP client to doxygen docs
2017-03-28 21:14:56 +02:00
Dirk Ziegelmeier
3826bcceab
Move SMTP from contrib to main lwIP rep - with TLS support, it becomes useful again
2017-03-28 20:40:47 +02:00
Dirk Ziegelmeier
38651b8069
Cleanup #include structure of altcp_tls a bit
...
(as discussed with Simon today)
2017-03-28 20:31:25 +02:00
goldsimon
898d3832a7
more fixes for !LWIP_ALTCP: move mqtt client struct definitions to mqtt.c
2017-03-28 14:12:22 +02:00
goldsimon
537c258efa
httpd/altcp: add forgotten functions
2017-03-28 14:04:40 +02:00
Dirk Ziegelmeier
7599706808
One more try to fix mqtt.c
2017-03-28 12:30:26 +02:00
goldsimon
8673610f3f
mqtt: add TLS support
2017-03-28 09:19:32 +02:00
goldsimon
26a6e034fc
mqtt: convert to altcp API
2017-03-28 09:14:35 +02:00
goldsimon
881ab3011e
mqtt: pass client_user/client_pass to server if != NULL
2017-03-27 22:25:26 +02:00
Daniel Elstner
751ee7a534
SNTP: Implement round-trip delay compensation
...
Introduce a new configuration define SNTP_COMP_ROUNDTRIP to compensate
for network round-trip delays when setting the system clock from SNTP.
Note that this feature requires compiler support for 64-bit arithmetic.
2017-03-27 10:43:03 +02:00
Daniel Elstner
cc77b308a4
SNTP: Unify timestamp extraction from response packet
...
Avoid piecemeal invocation of pbuf_copy_partial() for each SNTP header
field. The new code may sometimes copy more than necessary, but the
complexity is reduced.
2017-03-27 10:43:02 +02:00
Daniel Elstner
2fa9cd8530
SNTP: Streamline timestamp handling
...
Generalize the NTP timestamp conversion arithmetic, and provide hooks
for using native NTP timestamps when setting or getting the system
clock time. Convert microseconds to a fraction as needed when getting
the system time.
2017-03-27 10:43:01 +02:00
goldsimon
425b2dda61
altcp_get_ip: added altcp_get_ip(), added default functions that only defer a call to the inner_conn (moved from tls_mbedtls to generic altcp)
2017-03-26 22:26:40 +02:00
goldsimon
6add16e36b
altcp_tls_mbedtls: fixed memory leak introduced by delayed deallocation
2017-03-25 20:35:46 +01:00
goldsimon
0581a77731
Prepare altcp_tls_mbedtls for TLS clients (not fully tested yet)
2017-03-24 15:25:43 +01:00
goldsimon
a2bc02d682
altcp_tls_mbedtls: improve sent/recved handling
2017-03-23 22:04:36 +01:00
goldsimon
1ddb125e2c
altcp_tls_mbedtls_mem: fix compiling for sizeof(mem_size_t) < sizeof(size_t)
2017-03-23 12:15:54 +01:00
goldsimon
1e26652d2e
renamed altcp_mbedtls files to altcp_tls_mbedtls
2017-03-23 08:34:02 +01:00
Dirk Ziegelmeier
d04dc46ccb
Add altcp_tls to Filelists.mk
...
Some compile fixes in altcp_mbedtls.c
2017-03-22 23:09:48 +01:00
Dirk Ziegelmeier
060a47f88a
Add altcp to Filelists.mk
...
Some compile fixes in altcp_tcp.c and httpd.c
2017-03-22 22:57:50 +01:00
Mikhail Lappo
7eba14cb76
Possible null-pointer dereference
...
The value should be dereferenced after
assertion is performed. This can lead
to crash
2017-03-22 22:50:16 +01:00
Mikhail Lappo
08cb949aea
Fread return value unused
...
Assert that fread was able to read
specified amount of chunks
2017-03-22 22:47:15 +01:00
goldsimon
8360054884
sanity check hdr_buf size
2017-03-22 22:46:49 +01:00
Mikhail Lappo
89b6fa479e
Possible out of bound exception
...
hdr_buf has size of 4096. Makes sense to assert that
we do not exceed this size before copying there
2017-03-22 22:45:06 +01:00
goldsimon
d386374449
httpd: add support for https
2017-03-22 22:42:09 +01:00
goldsimon
afaa7d9561
httpd: prepare for https: move initialization code to shared function
2017-03-22 22:41:24 +01:00
goldsimon
2f3b00efb4
httpd: convert to altcp API (a simple search & replace...)
2017-03-22 22:33:50 +01:00
goldsimon
c18393b52b
altcp: added 'addrinfo' and 'tcp_state' functions
2017-03-22 22:29:11 +01:00
goldsimon
a46664eab2
Add opts header for altcp_tls
2017-03-22 21:40:32 +01:00
goldsimon
82d9e45f74
Add protoypes for TLS connections for the new altcp API + an implementation doing HTTPS (server mode for now) with mbedTLS (ATTENTION: this might not be coded secure enough for productive use yet!)
2017-03-22 21:33:05 +01:00
goldsimon
ee5021deb1
tftp_server: fix bogus comment lines in file header
2017-03-22 21:14:36 +01:00
goldsimon
c3912e35f6
httpd: regenerate example fs (fsdata.c) with current makefsdata
2017-03-21 13:06:26 +01:00
goldsimon
ec24a2a4e8
Revert "httpd: regenerate example fs (fsdata.c) with current makefsdata"
...
This reverts commit 66fb52ff5c
.
2017-03-21 12:57:56 +01:00
goldsimon
66fb52ff5c
httpd: regenerate example fs (fsdata.c) with current makefsdata
2017-03-20 22:19:54 +01:00
goldsimon
d11292505b
httpd: use capital 'T' for content types, add more content types, provide the possibility to add more content types at compile time (HTTPD_ADDITIONAL_CONTENT_TYPES)
2017-03-20 22:19:05 +01:00
Dirk Ziegelmeier
1f1f2e1c46
Try to fix line endings of tftp_server.c in git rep
2017-03-14 09:12:25 +01:00
Dirk Ziegelmeier
59973c96e4
Fix bug #50534 : TFTP server does not copy terminating null of filename
...
Patch by David Rodgers
2017-03-13 21:26:06 +01:00
Dirk Ziegelmeier
1371400c2b
mdns_domain_add_label_base should be static
2017-03-11 10:41:47 +01:00
goldsimon
7bcb4eafec
mdns: minor(?) stack usage and performance improvement by letting mdns_readname_loop() copy from pbuf to struct (instead of pbuf->buffer->struct)
2017-03-10 23:00:46 +01:00
Dirk Ziegelmeier
e15e504217
Some minor SNMPv3 related cleanups
2017-03-06 09:38:58 +01:00
Dirk Ziegelmeier
02be2f8f42
Move snmpv3_dummy.* from main lwIP rep to contrib
2017-03-03 13:42:37 +01:00
Dirk Ziegelmeier
9719c52e62
SNMPv3: Missed two locations where the new enums can be used
2017-03-03 13:21:22 +01:00
Dirk Ziegelmeier
c961ac70b6
Fixump snmp/snmpv3_dummy.h copyright header
2017-03-03 13:17:06 +01:00
Dirk Ziegelmeier
6f485cc870
snmp/snmpv3_dummy.c: Set default configuration in snmpv3_dummy_init()
...
(Note: snmpv3_dummy.* will be moved to lwip-contrib soon)
2017-03-03 13:12:47 +01:00
Dirk Ziegelmeier
461f1fe1a9
More SNMPv3 cleanups: Create own header snmpv3_dummy.h and move functions in there
...
Decouple snmp_netconn.c from snmpv3_dummy.c (snmpv3_enginetime_timer)
Make SNMP API more type-safe using enums
2017-03-03 13:01:04 +01:00
Dirk Ziegelmeier
ecb3867803
SNMPv3: Rename tcpip_enginetime_timer to snmpv3_enginetime_timer
2017-03-03 12:32:22 +01:00
Dirk Ziegelmeier
593b211d1b
A few more SNMPv3 cleanups
2017-03-02 11:20:02 +01:00
Dirk Ziegelmeier
0065cd915f
Several Win32 compile fixes in SNMP code
2017-03-02 07:49:42 +01:00
Dirk Ziegelmeier
83de16678c
SNMP: TABs -> spaces
2017-03-02 07:33:18 +01:00
goldsimon
05a595f745
httpd: LWIP_HTTPD_POST_MANUAL_WND: fixed double-free when httpd_post_data_recved is called nested from httpd_post_receive_data() (bug #50424 )
2017-03-01 22:08:05 +01:00
Dirk Ziegelmeier
ea41480232
Replace several C++ style comments by C-style
2017-03-01 21:25:03 +01:00
Dirk Ziegelmeier
4ef21e2597
Fix compile when SNMPv3 is disabled
2017-03-01 20:39:39 +01:00
Dirk Ziegelmeier
78cdbff1b3
Several compile fixes for Marco's patch
2017-03-01 20:39:39 +01:00
Dirk Ziegelmeier
fef7ce3c0d
Some whitespace fixes to Marco's patches
2017-03-01 20:39:39 +01:00
Marco
f0605a510f
Modified the snmpv3_dummy implementation to be more functional.
...
The dummy implementation also implements the user table as a reference.
2017-03-01 20:39:39 +01:00
Marco
3b8bb580e4
Add framework MIB and USM mib if SNMPv3 is enabled.
2017-03-01 20:39:39 +01:00
Marco
4b97f2bb8e
Implemented usm mib.
2017-03-01 20:39:39 +01:00
Marco
46df850cb9
Implemented framework mib.
2017-03-01 20:39:39 +01:00
Marco
f8f3cc039a
Start a timer for enginetime handling.
...
This timer function should be implemented in the snmpv3_xxx.c file.
2017-03-01 20:39:39 +01:00
Marco
f092d09121
Added handling invalid packets in SNMPv3.
2017-03-01 20:39:39 +01:00
Marco
78806001e5
Made accepted SNMP version runtime configurable.
...
This feature can be disabled by setting LWIP_SNMP_CONFIGURE_VERSIONS to 0.
2017-03-01 20:39:39 +01:00
Marco
8fd09d4608
Added missing context specific tags.
2017-03-01 20:39:39 +01:00
Marco
ec044e826e
Replaced old LWIP_SNMPV3_GET_ENGINE_BOOTS macro.
...
Replaced old LWIP_SNMPV3_GET_ENGINE_BOOTS macro with the new snmpv3_get_engine_boots_internal function.
2017-03-01 20:39:39 +01:00
goldsimon
a9bfe7b72f
Fix compiling httpd for LWIP_HTTPD_SUPPORT_POST==1 (assigning int to u16_t)
2017-03-01 20:32:13 +01:00
goldsimon
0d585d55d3
Added LWIP_SINGLE_NETIF for small targets with only one netif (see task #13515 , there might be more optimizations to come with this option)
2017-03-01 16:10:50 +01:00
Dirk Ziegelmeier
d8135f9ae2
Fix bug #50427 : SNMP: ifIndex should use netif_get_index()
...
We have netif_get_index(netif) now
2017-03-01 12:34:47 +01:00
goldsimon
1741edf159
make tcp apps depend on LWIP_CALLBACK_API, too
2017-02-28 12:19:16 +01:00
Dirk Ziegelmeier
d7b51b5906
MDNS: Fix accessing wrong union member in netif ext callback
2017-02-15 14:38:57 +01:00
Dirk Ziegelmeier
498913b982
Third draft of task #14283 : Add more detailed status callback
...
Implement Joel's idea of a union
2017-02-15 10:14:06 +01:00
Dirk Ziegelmeier
35e148e26d
MDNS: Use new netif callback, now does not need mdns_resp_netif_settings_changed() calls from user any more when LWIP_NETIF_EXT_STATUS_CALLBACK is enabled
2017-02-14 21:03:49 +01:00
goldsimon
ea093d3a53
http_add_connection: add connections to the front to be faster (and really fix bug #50059 )
2017-02-09 13:08:17 +01:00
goldsimon
5743864744
Fixed bug #50059 (httpd LWIP_HTTPD_SUPPORT_11_KEEPALIVE vs. LWIP_HTTPD_KILL_OLD_ON_CONNECTIONS_EXCEEDED)
2017-02-09 13:01:37 +01:00
Dirk Ziegelmeier
5c58e25de5
Minor code readability improvement in mqtt.c
2017-01-15 09:22:13 +01:00
Dirk Ziegelmeier
f8ef8c48f7
Simplify HTTPD #include path handling
...
- Move fsdata.h content to lwip/apps/fs.h -> no #include path needed any more to src/apps/httpd/
- Create a #define to specify fsdata file name. One can use path in there now, e.g. "../mywebserver/mkfsdata_output.c" -> no #include path needed any more to location of generated file
2017-01-11 10:59:15 +01:00
Dirk Ziegelmeier
52f448978f
MQTT: Add check that WILL topic length must be > 0
2017-01-08 19:08:54 +01:00
Dirk Ziegelmeier
6d5ddb7139
MQTT: Fix possible bug in connect message generation that WILL flag can be set without appending a will message
...
The boolean condition of setting the WILL flag differs from that of appending the will message
Found by Axel Lin
(I fixed it the same way as Axel suggested, but I wanted a different commit message)
2017-01-08 19:07:43 +01:00
Axel Lin
a2915b7142
mqtt: Slightly improve mqtt_create_request
...
Mainly for better readability, also save NULL test while iterating the for loop.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2017-01-07 20:39:41 +01:00
Axel Lin
7faa4bcbe2
mqtt: Prevent NULL pointer dereference before assertion checking
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2017-01-06 12:15:03 +01:00
Dirk Ziegelmeier
0ffaccaec3
Add missing #include in httpd.c for atoi()
2017-01-05 08:53:26 +01:00
Erik Ekman
d2631e6a53
mqtt: Fix pedantic enum warning
...
src/apps/mqtt/mqtt.c:81:17: error: comma at end of enumerator list [-Werror=pedantic]
2017-01-04 00:24:00 +01:00
Dirk Ziegelmeier
2096f1a657
Fix C++ style comment in mqtt.c
2017-01-01 20:23:11 +01:00
Axel Lin
edfeab7932
mqtt: Trivial coding style fix
...
Add proper blank for if/for/while statements.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2017-01-01 19:20:24 +01:00
Dirk Ziegelmeier
f874d15185
Add #include <string.h> in snmp_netconn.c because memset() is used
2017-01-01 12:38:34 +01:00
Dirk Ziegelmeier
1466b7ac61
Several mqtt documentation fixes found by clang
2016-12-29 09:44:07 +01:00
Axel Lin
bfa0358a52
mqtt: Allow setting server port to connect
...
This is a mqtt client, so it does not make sense to determinate the server port
at compile time. Update mqtt_client_connect() function to allow setting server
port.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-12-23 09:52:31 +01:00
Dirk Ziegelmeier
3a557baedd
Move a few MQTT options from mqtt.c to mqtt_opts.h
2016-12-21 09:42:25 +01:00
Dirk Ziegelmeier
6e219b6b11
Change signature of mqtt_client_connect() to take an IP addr instead of a string
2016-12-21 09:36:28 +01:00
Dirk Ziegelmeier
ec1450bac4
Add mqtt documentation from Erik Anderson, rev 4b84fff
2016-12-21 09:29:47 +01:00
Axel Lin
5be91de56c
mqtt: Trivial error message fix
...
Fix trivial copy-paste mistake.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-12-21 08:54:57 +01:00
Axel Lin
d5bc856f45
mqtt: Check conn_state before create request for sub_unsub
...
This also avoid a request leak in client->conn_state == TCP_DISCONNECTED error
path.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-12-20 19:45:31 +01:00
Dirk Ziegelmeier
16b895b466
Undo removal of mqtt_publish() from documentation in Simon's last commit (guess it was by accident)
2016-12-20 10:48:19 +01:00
Dirk Ziegelmeier
dcb761637d
Minor documentation fix in MQTT
2016-12-20 10:42:56 +01:00
Axel Lin
02f4610b1c
mqtt: Use LWIP_ARRAYSIZE to replace hardcoded value
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-12-20 10:36:42 +01:00
goldsimon
b6a131edfb
mqtt: fix C usage (declaration after statement), fix casting to smaller type
2016-12-20 10:27:43 +01:00
Dirk Ziegelmeier
12bc2c0425
MQTT cleanups:
...
- create mqtt_opts.h file and move options in there
- documentation cleanups
2016-12-20 10:08:50 +01:00
Dirk Ziegelmeier
14e36866f5
Some cleanups in MQTT client
...
Integrate in documentation
Compile fixes, mostly: Variables must be declared before any statement in a function
2016-12-20 09:41:21 +01:00
Dirk Ziegelmeier
1e82465766
task #14281 : Add MQTT client
...
Thanks to Erik Andersen
Taken from https://github.com/erian747/ , branch mqtt, rev 5d59470
2016-12-20 09:16:21 +01:00
goldsimon
fb07d47b82
more LWIP_NOASSERT fixes
2016-12-19 10:34:49 +01:00
Dirk Ziegelmeier
e5f9f187ad
Continue to fix incorrect casts via size_t for some platforms
...
Now also for casts:
- to remove alignment warnings
- casts between pointers and ints
2016-12-12 10:17:33 +01:00
Dirk Ziegelmeier
f2a5aa2866
Fix bug #49827 : wrong cast to size_t on 16-bit x86 architecture
...
I hope I caught all of them.
TODO: Same for casts to get rid of alignment warnings, these are also casts via size_t
2016-12-12 10:07:00 +01:00
goldsimon
ac4d994249
mdns.c: use group initializer constants from prot/dns.h
2016-12-09 13:10:12 +01:00
goldsimon
f308694dd4
Revert "mdns.c: use constants from dns.h/.c"
...
This reverts commit 0e883bbbc5
.
2016-12-09 13:08:00 +01:00
goldsimon
0e883bbbc5
mdns.c: use constants from dns.h/.c
2016-12-09 12:49:49 +01:00
Dirk Ziegelmeier
89cb7b7aa1
Try to remove #include <stdlib.h> from many files. Does not seem necessary any more and might cause problems when porting lwIP.
2016-12-08 11:05:01 +01:00
Dirk Ziegelmeier
e00a131160
Fix bug #49778 : sntp_stop does not cancel all timers
...
Patch by Ari Suutari
2016-12-06 20:29:12 +01:00
Axel Lin
795acf020e
lwiperf: Simplify #if LWIPERF_CHECK_RX_DATA guard
...
The variable i is equal to q->len after exit the for loop.
Check the received data should not change the logic of update packet_idx.
So let's simplify the code a bit.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-12-06 11:36:25 +01:00
Dirk Ziegelmeier
1687721600
Fix compile when IPv4 is disabled
2016-12-05 22:01:58 +01:00
Axel Lin
12e35c4c12
mdns: Fix assertion message in mdns_resp_add_service_txtitem()
...
So we know which function emits the assertion.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-11-30 11:36:05 +01:00
Dirk Ziegelmeier
ad17f345e7
mdns: Use strlen to determine string length of strings contained in a struct - padding seems to be applied to these strings, and sizeof() returns the _padded_ size???
...
Found by compiling with CLANG with address sanitizer enabled
2016-11-16 21:01:15 +01:00
Erik Ekman
b90682dc8b
Update email address
...
I am leaving Verisure at the end of the month.
2016-11-10 11:19:51 +01:00
Dirk Ziegelmeier
5d22679c67
Use API function instead of accessing struct members directly
2016-11-05 16:14:11 +01:00
Erik Ekman
725feb0d4a
mdns: Use netif_get/set_client_data helpers
2016-10-11 11:34:59 +02:00
Dirk Ziegelmeier
f6e27940bd
Make lwIP compile with clang -Wdocumentation -> several documentation fixes
2016-10-09 12:21:39 +02:00
Dirk Ziegelmeier
13fb616bb2
Cleanup hton*/ntoh* function handling and platform abstraction
...
Let lwip use functions/macros prefixed by lwip_ internally to avoid naming clashes with external #includes.
Remove over-complicated #define handling in def.h
Make functions easier to override in cc.h. The following is sufficient now (no more LWIP_PLATFORM_BYTESWAP):
#define lwip_htons(x) <your_htons>
#define lwip_htonl(x) <your_htonl>
2016-10-06 12:55:57 +02:00
Dirk Ziegelmeier
fa211096c2
Fix macro name clash with windows headers in TFTP server
...
Reported by Gisle Vanem
2016-10-05 21:02:46 +02:00
Axel Lin
87172d6d35
mdns: Use NETIF_TO_HOST at appropriate places
...
Trivial cleanup, use NETIF_TO_HOST macro to get mdns_host from netif.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-10-05 11:23:08 +02:00
Dirk Ziegelmeier
81549578bf
Fix compile of TFTP with MSVC
2016-10-04 08:54:52 +02:00
Dirk Ziegelmeier
f8683499a6
TFTP: Add missing newline at end of file
2016-10-03 14:33:57 +02:00
Dirk Ziegelmeier
1e5efee7cb
TFTP server depends on UDP
2016-10-03 09:50:34 +02:00
Dirk Ziegelmeier
b040544628
task #14150 : Add TFTP server from Logan Gunthorpe
...
Originally written by Logan Gunthorpe, modifications/fixes/IPv6 by Dirk Ziegelmeier
2016-10-03 09:47:41 +02:00
Dirk Ziegelmeier
af04864094
Remove non-standard strnlen() call in snmp_msg.c
2016-09-29 08:30:33 +02:00
Dirk Ziegelmeier
5ddd2aef4b
Substitute custom itoa implementation mdns by lwip_itoa() and strlen() call
2016-09-29 08:25:57 +02:00
Dirk Ziegelmeier
461b3531c7
httpd.c: add missing default in case statement
2016-09-28 22:05:52 +02:00
Dirk Ziegelmeier
1f68b32485
Cleanup handling of non-standard functions in lwIP
...
- itoa
- strnicmp, stricmp/strcasecmp
- strnstr
Related to patch #9115 : httpd.c: strcasecmp for GCC and stricmp for Windows
2016-09-28 21:52:11 +02:00
Dirk Ziegelmeier
f8d19e28de
Minor: Documentation updates
2016-09-28 20:58:02 +02:00
Erik Ekman
f3cec74bd6
mdns: Use macro to get mdns_host from netif v2
...
Add missing )
2016-09-28 18:15:11 +02:00
Erik Ekman
87e815030c
mdns: Use macro to get mdns_host from netif
2016-09-28 18:00:48 +02:00
Erik Ekman
78498981e2
mdns: Update error message after argument type changed
...
Method argument is no longer netif, but a mdns_host
2016-09-28 18:00:44 +02:00
Dirk Ziegelmeier
633696c153
Implement consistent IPx_ADDR_ANYx macro naming between IPv4 and IPv6
...
- rename IP4_ADDR_ANY to IP4_ADDR_ANY4
- IP4_ADDR_ANY (= IP_ADDR_ANY) is now IPv4 any address in ip_addr_t format
2016-09-28 12:56:57 +02:00
Dirk Ziegelmeier
c25de8f317
Update comment in MDNS and pbuf.c
2016-09-21 12:37:31 +02:00
Daniel Elstner
c9bae5ea9b
Fix bug #49134 : Do not announce invalid IPv4 address via mDNS
...
In a dual stack configuration it is not really feasible to wait
until the IPv4 address is valid before starting the mDNS responder.
If there is no DHCPv4 server in the network, the IPv4 address may
never become valid, which should however not preclude IPv6 mDNS
from working.
2016-09-21 12:31:13 +02:00
Dirk Ziegelmeier
dbd847b70c
Fix bugfix for bug #49136 : No SNMPv2 SetRequest response when OID does not exist
...
Last commit broke SNMPv1 answers
2016-09-20 14:28:40 +02:00
Dirk Ziegelmeier
19e2780656
Fix bug #49136 : No SNMPv2 SetRequest response when OID does not exist
2016-09-20 14:06:20 +02:00
Dirk Ziegelmeier
2facd2d64d
Apply modified patch from Daniel Elstner to fix bug #49124 : mDNS should not use snprintf()
2016-09-19 12:20:20 +02:00
Dirk Ziegelmeier
58c8e0f8ca
Implement request by Marco Veeneman: Make snmp_send_trap() public
2016-09-15 10:41:05 +02:00
Dirk Ziegelmeier
8dbd1abdc4
Minor coding style fixes while reading SNMP code
2016-09-12 12:55:24 +02:00
Erik Ekman
4a73bcbc65
mdns: Revert answer count patch
...
Answers written to outpackets can be additional answers
or normal answers to questions.
2016-09-09 17:04:12 +02:00
Axel Lin
f38705c38c
mdns: Update answers counter in mdns_add_answer rather than each caller
...
This simplifies the code and less error prone.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-09-09 16:42:49 +02:00
Dirk Ziegelmeier
9078f31544
Minor: memcpy -> MEMCPY / SMEMCPY
2016-08-30 21:56:09 +02:00
Dirk Ziegelmeier
f5135b05d9
Minor coding style fixes in mdns.c
2016-08-30 21:21:32 +02:00
Axel Lin
ef827e85b8
apps/mdns: Fixup LWIP_ERROR message in mdns_build_host_domain
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2016-08-30 08:35:40 +02:00
Dirk Ziegelmeier
e545262d98
Remove superfluous parameter from mdns_domain_debug_print()
2016-08-29 19:32:39 +02:00
Dirk Ziegelmeier
fb62e9350f
Fix wrong sizeof() and remove superfluous NULL pointer check in MDNS
2016-08-29 19:15:22 +02:00
Dirk Ziegelmeier
d9b0236525
Fix MDNS did not allocate TX packets from RAM but from POOL
2016-08-24 08:04:04 +02:00
Dirk Ziegelmeier
fefb782bfe
Apply fix by Marco Veeneman in SNMPv3: The outbound_padding is calculated wrong in snmp_complete_outbound_frame()
2016-08-19 12:22:59 +02:00
Dirk Ziegelmeier
12609c951c
Fix compile of SNMPv3 code with MSVC
2016-08-19 12:22:58 +02:00
goldsimon
ebd1bf8a49
fixed typo :-(
2016-08-19 11:03:09 +02:00
goldsimon
4a7dafc6a6
fixed compiling mdns.c after moving things to mdns_priv.h
2016-08-19 11:02:37 +02:00
goldsimon
96c3c48ba7
mdns: moved private things into mdns_priv.h
2016-08-19 09:52:30 +02:00
goldsimon
14fb48cd7a
minor: whitespace cleanups
2016-08-19 09:41:34 +02:00
Dirk Ziegelmeier
a262a2f252
MDNS: Add callback to be called manually when IP has changed to announce new IP
2016-08-18 10:59:08 +02:00
Dirk Ziegelmeier
c8c804140d
Fix possible NULL pointer dereference in mdns.c introduced in my last commit
2016-08-17 21:00:59 +02:00
Dirk Ziegelmeier
ee815e4e7a
Finish porting MDNS to new netif client data API
2016-08-17 20:09:28 +02:00
Dirk Ziegelmeier
c28fb298b7
Introduce an API to store arbitrary data pointers in struct netif
...
Let MDNS to use the new API
TODO: AutoIP, DHCP
2016-08-17 16:37:15 +02:00
Dirk Ziegelmeier
2a90f33757
MDNS responder: two functions can take struct mdns_host instead of netif as argument
2016-08-17 12:32:33 +02:00
Dirk Ziegelmeier
efb7b3d5f8
Rename LWIP_MDNS to LWIP_MDNS_RESPONDER
2016-08-17 12:07:38 +02:00
Dirk Ziegelmeier
fec657bb38
MDNS: Substitute a few strlens by sizeof()
2016-08-16 09:33:53 +02:00
Dirk Ziegelmeier
858287fc3a
MDNS: Fix several MSVC warnings
2016-08-16 08:33:16 +02:00
Dirk Ziegelmeier
ab72ed8517
Fix options #include in mdns code
2016-08-16 08:22:41 +02:00
Dirk Ziegelmeier
482a4d2ce9
MDNS: Correct setting TTL when IGMP is not enabled
2016-08-16 08:09:19 +02:00
Dirk Ziegelmeier
39ac8e2c57
Remove some MDNS functions from documentation, they are only visible for unit tests
2016-08-14 17:08:39 +02:00
Dirk Ziegelmeier
52449e12c0
Forgot to save before committing...
2016-08-14 16:56:34 +02:00
Dirk Ziegelmeier
2335c1a73c
Port MDNS to new dual-stack API
2016-08-14 16:47:45 +02:00
Dirk Ziegelmeier
ebe0e6f98d
Some documentation cosmetics in mdns.c
2016-08-14 15:42:22 +02:00
Dirk Ziegelmeier
a2894ede1c
MDNS: make a few arguments const where suitable
2016-08-14 15:31:49 +02:00
Dirk Ziegelmeier
306113c8c3
Add MDNS to doxygen docs
2016-08-14 15:22:05 +02:00
Erik Ekman
4919932c49
Apply patch #8755 : Multicast DNS responder support from Erik Ekman
2016-08-14 15:07:45 +02:00
Dirk Ziegelmeier
ce6ea0df15
Convert SNMP snmp_vb_enumerator_err_t to a typedef and fix resulting compile error
2016-08-12 22:59:21 +02:00
Dirk Ziegelmeier
0005b7c2d0
Revert my last change in sntp.c - allow usage of custom error values in err_t
2016-08-09 08:20:28 +02:00
Dirk Ziegelmeier
61dae47a71
Relete SNMP README and incorporate it's text in doxygen docs
2016-08-08 22:40:57 +02:00
Dirk Ziegelmeier
85ab39985a
Fix a few incorrect uses of err_t. Found by converting lwip error codes to an enum, but I'm not sure wether I want to commit the actual enum conversion.
2016-08-08 22:15:01 +02:00
Dirk Ziegelmeier
9fb9033815
Move MIB compiler to contrib, it's a better place for it
2016-07-28 14:33:15 +02:00
goldsimon
5bcaefddd4
lwiperf: improved documentation, removed unused enum members
2016-07-28 08:07:02 +02:00
sg
8ece46d5d2
snmp threadsync_data: "u8" -> "err" (typedef snmp_err_t is an enum, not u8_t)
2016-07-27 20:28:39 +02:00
Dirk Ziegelmeier
aece68639a
Integrate snmp_agent.txt in doxygen documentation, delete outdated file
2016-07-27 18:58:28 +02:00
Dirk Ziegelmeier
6b524367a3
Documentation review with Simon, minor changes
2016-07-27 08:05:38 +02:00
Dirk Ziegelmeier
1993b0257c
Document SNMP MIB2 functions
2016-07-27 06:37:26 +02:00
Dirk Ziegelmeier
c6831648e2
Document apps in doxygen module style, create more top-level categories to structure documentation
2016-07-26 19:30:05 +02:00
Dirk Ziegelmeier
40bc80b551
Fix compile of snmp_mib2_system.c after my last SNMP API change
2016-07-26 16:39:34 +02:00
Dirk Ziegelmeier
73ee4cbbf7
MIB compiler: Back to .NET 4.0 to maintain compatibility to VS2010
2016-07-26 12:59:28 +02:00
Dirk Ziegelmeier
f6468510c6
Adapt MIB compiler to changed function signature of my last commit. Done with patch #9044 : SNMP response for failed get operation.
2016-07-26 12:59:27 +02:00
Dirk Ziegelmeier
a62e4452a2
Work on patch #9044 : SNMP response for failed get operation
...
Inspired by Marco Veeneman. Change signature of get_value function to return s16_t, where values <0 indicate an error. This is mapped to SNMP_ERR_GENERROR.
2016-07-26 12:59:26 +02:00
goldsimon
ca71eea56f
httpd: reverted accidentally committed change (came in with de9054cb7a
when fixing memp things)
2016-07-26 07:29:59 +02:00
sg
de9054cb7a
memp: cleaned up MEMP_MEM_MALLOC:
...
- support memp stats when MEMP_MEM_MALLOC==1 (bug #48442 );
- hide MEMP_MEM_MALLOC in memp.c instead of messing up the header file;
- make MEMP_OVERFLOW_CHECK work when MEMP_MEM_MALLOC==1
2016-07-21 22:17:32 +02:00
Dirk Ziegelmeier
802a4f2a14
Fix compiling of snmp_mib2_ip.c when ARP is not enabled
2016-07-21 12:54:15 +02:00
Dirk Ziegelmeier
5d4c1432c2
Fix bug #48436 : Naming clash for timers.c (with FreeRTOS)
...
Rename timers.* to timeouts.*
2016-07-19 12:44:12 +02:00
Dirk Ziegelmeier
7037b340c1
Move etharp to core/ipv4, which is a more appropriate place for it
2016-07-19 09:29:51 +02:00
goldsimon
9a355502e1
snmp: fix compiling traps :-(
2016-07-08 10:56:24 +02:00
goldsimon
52da49cd81
snmp: changed name (snmp_length_outbound_varbind -> snmp_varbind_length)
2016-07-08 10:24:06 +02:00
goldsimon
e302b1bbd2
httpd: fixed using pools, fixed missing default value of LWIP_HTTPD_SSI_RAW, fixed typo
2016-07-08 10:06:35 +02:00
Marco Veeneman
dcd52510ce
Reduce code duplication in SNMP agent traps implementation.
...
See patch #9038 : SNMP Traps with varbinds, file #37748 by Marco Veeneman
2016-07-07 21:00:07 +02:00
goldsimon
7e3de89646
minor: coding style
2016-07-07 13:02:18 +02:00
Dirk Ziegelmeier
5a1b9bf808
SNMP traps quick fix: Do not return err_t as u16_t in snmp_varbind_len. This need further cleanup.
2016-07-05 08:48:59 +02:00
goldsimon
14ca418ac0
minor: coding style fixes
2016-07-05 07:36:51 +02:00
Dirk Ziegelmeier
cb5f7859fd
Apply patch #9038 : SNMP Traps with varbinds
...
Applied with modifications. Original patch from Marco Veeneman.
2016-07-04 21:11:20 +02:00
goldsimon
06782c699c
httpd: fixed persistent connections for files not containing HTTP header
2016-07-01 12:43:03 +02:00
Dirk Ziegelmeier
91b5d8ad1e
Patch by Marco Veeneman: Generic snmpv1 traps should be sent from .1.3.6.1.2.1.11 (iso.org.dod.internet.mgmt.mib-2.snmp).
2016-06-29 22:16:43 +02:00
Dirk Ziegelmeier
aecbefc728
Patch by Marco Veeneman: Tthe variable bindings field is missing in the trap message. Even if there are no varbinds attached to the trap, this field should still be present.
2016-06-29 22:14:37 +02:00
Dirk Ziegelmeier
a0e8c2dd8f
Revert commit e40175ef05
: Fix a few more CLANG alignment warnings - clang warns although the target struct is packed (and may therefore be unaligned) :-(
...
It was caused by a local problem on my PC, I forgot that I modified cc.h... :-( Sorry for that!
2016-06-28 21:54:48 +02:00
Dirk Ziegelmeier
500e748888
Fix [bug #48330 ] Memory leak in snmp_send_trap function
...
Forgot to free pbuf after sending it
2016-06-28 21:31:12 +02:00
Dirk Ziegelmeier
e40175ef05
Fix a few more CLANG alignment warnings - clang warns although the target struct is packed (and may therefore be unaligned) :-(
2016-06-27 20:54:17 +02:00
goldsimon
c164869f6d
snmp: use 'tcpip_callback' instead of '.._with_block'
2016-06-27 11:01:34 +02:00
Dirk Ziegelmeier
19e2b15c41
Fix alignment warnings in snmp agent - we know these structs are aligned according to requirements when they are casted because they have been instantiated as the target type (clang)
2016-06-24 21:21:38 +02:00
Dirk Ziegelmeier
a929f418e7
Fix format string in httpd.c (clang)
2016-06-24 21:16:44 +02:00
Dirk Ziegelmeier
0116c3cd76
Fix "no newline at end of file" warnings (clang)
2016-06-24 21:16:12 +02:00
Dirk Ziegelmeier
1af40e7de2
SNMP doxygen updates
2016-06-22 21:11:59 +02:00
Dirk Ziegelmeier
8dc77ef558
doxygen updates - include IPv6 in documentation. Exclude include/netif/ppp/polarssl.
...
Convert TODO -> @todo
2016-06-22 20:18:23 +02:00
goldsimon
5d9f59daa4
httpd makefsdata: make http response server string configurable via command line, tiny fixes to usage and command interpretation
2016-06-10 13:35:38 +02:00
goldsimon
076f1ee89e
minor: coding style cleanup in snmp code
2016-06-09 14:28:04 +02:00
goldsimon
010b0e2972
snmp: don't assert-fail on zero-length OID
2016-06-09 11:47:15 +02:00