mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2025-02-14 06:41:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: add a unit test for TCP_CHECKSUM_ON_COPY with retransmissions

Browse Source 
This triggers bug #50914 (TCP_CHECKSUM_ON_COPY when adding data to
retransmission) when data is added to an already transmitted segment
with an uneven length of tcp data.
This commit is contained in:
goldsimon 2018-02-12 12:34:45 +01:00
parent cff31ba5de
commit 7b6d2870ca
1 changed files with 122 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

122
test/unit/tcp/test_tcp.c
View File

@ -891,6 +891,127 @@ START_TEST(test_tcp_tx_full_window_lost_from_unacked)
}
END_TEST
/** Send data, provoke retransmission and then add data to a segment
* that already has been sent before. */
START_TEST(test_tcp_retx_add_to_sent)
{
struct netif netif;
struct test_tcp_txcounters txcounters;
struct test_tcp_counters counters;
struct tcp_pcb* pcb;
struct pbuf* p;
char data1a[] = { 1, 2, 3};
char data1b[] = { 4};
char data2a[] = { 5, 6, 7, 8};
char data2b[] = { 5, 6, 7};
char data3[] = { 9, 10, 11, 12, 12};
char data4[] = { 13, 14, 15, 16,17};
err_t err;
int i;
LWIP_UNUSED_ARG(_i);
/* initialize local vars */
test_tcp_init_netif(&netif, &txcounters, &test_local_ip, &test_netmask);
memset(&counters, 0, sizeof(counters));
/* create and initialize the pcb */
pcb = test_tcp_new_counters_pcb(&counters);
EXPECT_RET(pcb != NULL);
tcp_set_state(pcb, ESTABLISHED, &test_local_ip, &test_remote_ip, TEST_LOCAL_PORT, TEST_REMOTE_PORT);
pcb->mss = TCP_MSS;
/* disable initial congestion window (we don't send a SYN here...) */
pcb->cwnd = pcb->snd_wnd;
/* send data1 */
err = tcp_write(pcb, data1a, sizeof(data1a), TCP_WRITE_FLAG_COPY);
EXPECT_RET(err == ERR_OK);
err = tcp_write(pcb, data1b, sizeof(data1b), TCP_WRITE_FLAG_COPY);
EXPECT_RET(err == ERR_OK);
err = tcp_output(pcb);
EXPECT_RET(err == ERR_OK);
EXPECT_RET(txcounters.num_tx_calls == 1);
EXPECT_RET(txcounters.num_tx_bytes == sizeof(data1a) + sizeof(data1b) + sizeof(struct tcp_hdr) + sizeof(struct ip_hdr));
memset(&txcounters, 0, sizeof(txcounters));
/* "recv" ACK for data1 */
p = tcp_create_rx_segment(pcb, NULL, 0, 0, 4, TCP_ACK);
EXPECT_RET(p != NULL);
test_tcp_input(p, &netif);
EXPECT_RET(txcounters.num_tx_calls == 0);
EXPECT_RET(pcb->unacked == NULL);
/* send data2 */
err = tcp_write(pcb, data2a, sizeof(data2a), TCP_WRITE_FLAG_COPY);
EXPECT_RET(err == ERR_OK);
err = tcp_write(pcb, data2b, sizeof(data2b), TCP_WRITE_FLAG_COPY);
EXPECT_RET(err == ERR_OK);
err = tcp_output(pcb);
EXPECT_RET(err == ERR_OK);
EXPECT_RET(txcounters.num_tx_calls == 1);
EXPECT_RET(txcounters.num_tx_bytes == sizeof(data2a) + sizeof(data2b) + sizeof(struct tcp_hdr) + sizeof(struct ip_hdr));
memset(&txcounters, 0, sizeof(txcounters));
/* send data3 */
err = tcp_write(pcb, data3, sizeof(data3), TCP_WRITE_FLAG_COPY);
EXPECT_RET(err == ERR_OK);
err = tcp_output(pcb);
EXPECT_RET(err == ERR_OK);
EXPECT_RET(txcounters.num_tx_calls == 0);
EXPECT_RET(txcounters.num_tx_bytes == 0);
memset(&txcounters, 0, sizeof(txcounters));
/* data3 not sent yet (nagle) */
EXPECT_RET(pcb->unacked != NULL);
EXPECT_RET(pcb->unsent != NULL);
/* disable nagle for this test so data to sent segment can be added below... */
tcp_nagle_disable(pcb);
/* call the tcp timer some times */
for (i = 0; i < 20; i++) {
test_tcp_tmr();
if (txcounters.num_tx_calls != 0) {
break;
}
}
/* data3 sent */
EXPECT_RET(txcounters.num_tx_calls == 1);
EXPECT_RET(txcounters.num_tx_bytes == sizeof(data3) + sizeof(struct tcp_hdr) + sizeof(struct ip_hdr));
EXPECT_RET(pcb->unacked != NULL);
EXPECT_RET(pcb->unsent == NULL);
memset(&txcounters, 0, sizeof(txcounters));
tcp_nagle_enable(pcb);
/* call the tcp timer some times */
for (i = 0; i < 20; i++) {
test_tcp_tmr();
if (txcounters.num_tx_calls != 0) {
break;
}
}
/* RTO: rexmit of data2 */
EXPECT_RET(txcounters.num_tx_calls == 1);
EXPECT_RET(txcounters.num_tx_bytes == sizeof(data2a) + sizeof(data2b) + sizeof(struct tcp_hdr) + sizeof(struct ip_hdr));
EXPECT_RET(pcb->unacked != NULL);
EXPECT_RET(pcb->unsent != NULL);
memset(&txcounters, 0, sizeof(txcounters));
/* send data4 */
err = tcp_write(pcb, data4, sizeof(data4), TCP_WRITE_FLAG_COPY);
EXPECT_RET(err == ERR_OK);
/* disable nagle for this test so data to transmit without further ACKs... */
tcp_nagle_disable(pcb);
err = tcp_output(pcb);
EXPECT_RET(err == ERR_OK);
/* nagle enabled, no tx calls */
EXPECT_RET(txcounters.num_tx_calls == 1);
EXPECT_RET(txcounters.num_tx_bytes == sizeof(data3) + sizeof(data4) + sizeof(struct tcp_hdr) + sizeof(struct ip_hdr));
memset(&txcounters, 0, sizeof(txcounters));
/* make sure the pcb is freed */
EXPECT_RET(MEMP_STATS_GET(used, MEMP_TCP_PCB) == 1);
tcp_abort(pcb);
EXPECT_RET(MEMP_STATS_GET(used, MEMP_TCP_PCB) == 0);
}
END_TEST
START_TEST(test_tcp_rto_tracking)
{
struct netif netif;
@ -1368,6 +1489,7 @@ tcp_suite(void)
TESTFUNC(test_tcp_rto_rexmit_wraparound),
TESTFUNC(test_tcp_tx_full_window_lost_from_unacked),
TESTFUNC(test_tcp_tx_full_window_lost_from_unsent),
TESTFUNC(test_tcp_retx_add_to_sent),
TESTFUNC(test_tcp_rto_tracking),
TESTFUNC(test_tcp_rto_timeout),
TESTFUNC(test_tcp_zwp_timeout),