mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-10-02 21:02:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

PPP, magic, improved magic_randomize() for PPP_MD5_RANDM is not enabled

Browse Source 
A disabled PPP_MD5_RANDM should not be used when challenge are used, but
anyway, improved magic_randomize() so magic_randomseed is not equals to
sys_jiffies() which is pretty useless because that's fully predicable.
This commit is contained in:
Sylvain Rochet 2015-08-30 20:44:13 +02:00
parent a24f4421d6
commit 541e3b6eb4
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/netif/ppp/magic.c
View File

@ -226,17 +226,14 @@ void magic_init(void) {
* bits. * bits.
*/ */
void magic_randomize(void) { void magic_randomize(void) {
static u32_t last_jiffies;
if (!magic_randomized) { if (!magic_randomized) {
magic_randomized = !0; magic_randomized = !0;
magic_init(); magic_init();
/* The initialization function also updates the seed. */ /* The initialization function also updates the seed. */
} else { } else {
/* magic_randomseed += (magic_randomseed << 16) + TM1; */ /* magic_randomseed += (magic_randomseed << 16) + TM1; */
magic_randomseed += (sys_jiffies() - last_jiffies); /* XXX */ magic_randomseed += sys_jiffies() & 0xffff; /* XXX */
} }
last_jiffies = sys_jiffies();
} }
/* /*