From 541e3b6eb4467278b75d3d1f52ea6c8f9cdd4764 Mon Sep 17 00:00:00 2001 From: Sylvain Rochet Date: Sun, 30 Aug 2015 20:44:13 +0200 Subject: [PATCH] PPP, magic, improved magic_randomize() for PPP_MD5_RANDM is not enabled A disabled PPP_MD5_RANDM should not be used when challenge are used, but anyway, improved magic_randomize() so magic_randomseed is not equals to sys_jiffies() which is pretty useless because that's fully predicable. --- src/netif/ppp/magic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/netif/ppp/magic.c b/src/netif/ppp/magic.c index 45a3fd56..2b95059b 100644 --- a/src/netif/ppp/magic.c +++ b/src/netif/ppp/magic.c @@ -226,17 +226,14 @@ void magic_init(void) { * bits. */ void magic_randomize(void) { - static u32_t last_jiffies; - if (!magic_randomized) { magic_randomized = !0; magic_init(); /* The initialization function also updates the seed. */ } else { /* magic_randomseed += (magic_randomseed << 16) + TM1; */ - magic_randomseed += (sys_jiffies() - last_jiffies); /* XXX */ + magic_randomseed += sys_jiffies() & 0xffff; /* XXX */ } - last_jiffies = sys_jiffies(); } /*