mirror/aseprite
1
0
Fork 0
mirror of https://github.com/aseprite/aseprite.git synced 2024-11-20 05:14:45 +00:00
Code Issues Packages Projects Releases Wiki Activity
46c57c91c7
aseprite/CONTRIBUTING.md
David Capello 87407f2627 Add section about PR assignee in CONTRIBUTING guide
2024-09-10 16:31:22 -03:00

6.7 KiB
Raw Blame History

Code of Conduct

We have a code of conduct that we all must follow. Be polite to everyone. If you are not in your best day, take a deep breath and try again.

New Issues

Before you submit an issue:

  • Search in the current list of issues, bug reports, or feature requests.
  • If the issue already exists, add a 👍 or a ❤️, and you can click the Subscribe or Watching button to get notifications via email.

Compilation problem

Before you submit an issue or a post about a compilation problem, check the following items:

  • See how to get the source code correctly in the INSTALL guide.
  • Check if you are using the latest repository clone.
  • Remember that we use submodules, so you need to initialize and update them.
  • Search in the GitHub issues about compilation if someone else had the same problem.
  • Remember that might be some pull requests being reviewed to fix your same issue.

If you have a compilation problem, you can ask in the Development category in the Community site for help or create a new GitHub issue.

Contributing

One of the easiest ways to contribute is writing articles, Steam reviews, blog posts, recording video tutorials, creating pixel art in social media with #aseprite, or showing your love to Aseprite, e.g. naming Aseprite in your website and linking it to https://www.aseprite.org/, following @aseprite, or buying an extra Aseprite copy to your friends.

Other ways to contribute require direct contact with us. For example:

  • Writing documentation.
  • Making art (and fan art) with Aseprite and for Aseprite (logos, skins, mockups).
  • Sending patches for features or bug fixes.
  • Reviewing issues in the issue tracker and making comments.
  • Helping other users in the Community site.

Documentation

You can start seeing the documentation, and contact us if you want to help writing documentation or recording tutorials.

If you are going to write some docs, we recommend you to take screenshots or record a GIF animations to showcase the feature your are documenting or the steps to follow:

  • As screen recording software, on Windows you can generate GIF files using LICEcap.
  • PNG/GIF images can be uploaded in the same docs repository with a pull request

Reviewing Issues

You can review issues, make comments, or create new features, bug reports, etc. You are encouraged to create mockups for any issue you see and attach them.

Code submission policy

We have some rules for the changes and commits that are contributed:

  • First of all you will need to sign our Contributor License Agreement (CLA) to submit your code.
  • Split your changes in the most atomic commits possible: one commit for feature, or fix.
  • Rebase your commits to the main branch (or beta if you are targeting the beta version).
  • Wrap your commit messages at 72 characters.
  • The first line of the commit message is the subject line.
  • Write the subject line in the imperative mood, e.g. "Fix something", not "Fixed something".
  • For platform-specific commits start the subject line using [win], [osx], or [x11] prefixes.
  • For CLI related commits you can use the [cli] prefix in the subject line.
  • For Lua scripting related commits can use the [lua] prefix in the subject line.
  • Check the spelling of your code, comments and commit messages.
  • Follow our coding style guide. We're using some C++17 features, targeting macOS 10.9 mainly as the oldest platform (and the one limiting us to newer C++ standards),

You can also take a look at the src/README.md guide which contains some information about how the code is structured.

Pull Request (PR) Assignee

In case you are a developer or contributor with write or triage access to the repository:

  1. The PR assignee is the one that is working on the PR right now.
  2. After a PR is sent, you (can) assign the PR to some other developer that will act as a reviewer.
    • Or if there is no assignee and the PR is not a draft, some developer will take it for review sooner or later.
  3. That developer will review the PR (or reassign the PR).
  4. When the review process is done, the reviewer will merge the PR or reassign the PR to you if it needs some changes.
  5. When you have applied the requested changes, you can reassign the PR to the last reviewer.
  6. If a PR is labeled with some "needs something" label, it means that the PR will not merged as it is, and something is required to continue.

With this workflow you can find the PRs assigned to you to review/continue working in: https://github.com/pulls/assigned

Community

You can use the Development category to ask questions about the code, how to compile, etc. If you want to start working on something (issue, bug, or feature), post a comment asking if somebody is already working on that, in that way you can avoid starting programming in something that is already done for the next release or which someone else is working on.

Future

If you want to contribute a new feature, I highly recommend trying to contribute a couple of pull requests to fix some bugs first. After that you can check what are the features we're planning for the future: