9977 Commits

Author SHA1 Message Date
David Capello
62b67b02b1 Add missing dependencies to link filters-lib 2024-12-26 20:20:14 -03:00
David Capello
b2e8cfc88f Merge branch 'main' into beta 2024-12-26 16:13:08 -03:00
David Capello
8ec836c727 Update laf module 2024-12-26 16:07:18 -03:00
David Capello
cb7549e43c [clang-tidy] Disable misc-include-cleaner 2024-12-26 16:06:09 -03:00
David Capello
7fb8cfc8fa Avoid including image impl details as much as possible (image_impl/bits/iterator.h)
Including doc/image.h should be enough to access/iterate the image
pixels.
2024-12-19 09:44:37 -03:00
Ryan Carsten Schmidt
71654e4b8e Add USE_SHARED_TINYEXIF option
See #4843

When this option is enabled, it requires a version of TinyEXIF newer
than 1.0.2 (which is the latest version that has been released),
specifically the change in cdcseacave/TinyEXIF@d75f772. The request to
release a new version of TinyEXIF is cdcseacave/TinyEXIF#18.
2024-12-18 09:43:15 -03:00
David Capello
9f552598ff Minor fixes in coding style guide 2024-12-18 08:41:51 -03:00
David Capello
11184b453f Update coding style guide with new clang-format rules 2024-12-18 08:35:20 -03:00
David Capello
c5dd58654b Revert changes to close all docs before destroying the MainWindow
Merged run()/close() member functions again to close all docs before
destroying MainWindow even in case of an exception, using RAII
idiom (this fixes some failing tests/benchmarks).

Fixes a failing ASSERT() in ~DocObserverWidget().

We've fixed some issues resetting the ui::Theme to nullptr when we're
shutting down the App to run a new unit test later. This avoids using
a freed theme pointer.
2024-12-17 17:29:10 -03:00
David Capello
27fbc4b9d7 Merge branch 'main' into beta 2024-12-17 14:17:46 -03:00
David Capello
daecb2001b Add .git-blame-ignore-revs file
This file can be used with --ignore-revs-file param or
blame.ignoreRevsFile config to ignore global formatting changes which
don't help to use git-blame.
2024-12-17 14:08:12 -03:00
David Capello
43aa0b9e86 Merge branch 'main' into beta 2024-12-16 14:54:17 -03:00
David Capello
09538f9a1a clang-format all files 2024-12-16 14:52:19 -03:00
David Capello
b2e4f78b69 clang-format all files 2024-12-16 10:10:34 -03:00
David Capello
35c7f5bc4e Merge branch 'main' into beta 2024-12-16 10:03:31 -03:00
David Capello
4b3ff3369e Update laf module 2024-12-16 09:52:55 -03:00
David Capello
d8fdc22648 [precommit] Add .m and .mm files to clang-format 2024-12-14 00:07:23 -03:00
David Capello
d0dbc78f1c Revert "[clang-format] Set SeparateDefinitionBlocks=Always"
This reverts commit d38565f64e4c0304b8ea2ae060c9e1c11ba5a863.

It added blank lines between one line member function definitions
inside class bodies/header files, something which is undesirable.
2024-12-13 19:59:24 -03:00
David Capello
6555e74d83 [clang-format] We use west const (might fix #4361) 2024-12-12 22:16:55 -03:00
David Capello
b146f0648e [clang-format] Set PackConstructorInitializers=CurrentLine
We prefer two kinds of formatting for constructors:

  Ctor() : a(), b() {}

  Ctor()
    : aaa()
    , bbb()
    , ccc()
2024-12-12 21:53:22 -03:00
David Capello
70ec2d422f [clang-format] Enable the alignment of short "case: break;" statements 2024-12-12 20:13:40 -03:00
David Capello
f19cbe8a37 [clang-format] Set AllowShortCaseLabelsOnASingleLine=true
Allows "case value: stmt; break;" in one line if it's short enough.
2024-12-12 20:02:36 -03:00
David Capello
d38565f64e [clang-format] Set SeparateDefinitionBlocks=Always
With the current code it makes no difference, but it will force new
definitions to be in its own block, e.g. we cannot define two
functions without a blank line between then.
2024-12-12 19:54:49 -03:00
David Capello
4a9ccf27b4 [clang-format] Set ReflowComments=1 to allow adjusting comments
Allows to format the code in better ways adjusting the comments to fit
the column limit. In few cases the comment will require to be moved to
other place (e.g. at the top of a statement rather than to the side of
it).
2024-12-12 19:45:39 -03:00
David Capello
1447e829f7 [clang-format] Change AllowAllParametersOfDeclarationOnNextLine=false
With this we prefer to format a function declaration as:

  int function(arg1,
               arg2,
               arg3);

Rather than:

  int function(
    arg1, arg2, arg3);

Cons: This makes the definition of NewParams structures a bit worse.
2024-12-12 19:29:01 -03:00
David Capello
17bb11fc42 [clang-format] Change SpaceInEmptyBlock=false
I love { } for empty blocks, but it looks like {} is too common among
developers now.
2024-12-12 19:20:05 -03:00
David Capello
28043e8305 [clang-format] Change SpacesBeforeTrailingComments=1 2024-12-12 19:15:20 -03:00
David Capello
b38a3c03eb [clang-format] Change AllowAllArgumentsOnNextLine=false
With this we prefer to format function calls as:

  int value = function(arg1,
                       arg2,
                       arg3);

Or:

  int value =
    function(arg1, arg2, arg3);

Rather than:

  int value = function(
    arg1, arg2, arg3);
2024-12-12 19:03:04 -03:00
David Capello
215f22cce3 [clang-format] New ColumnLimit=100 and new penalty weights
Making PenaltyBreakAssignment bigger creates better looking
const/variable declarations, where the following term to the
assignment operator is in the same line.
2024-12-12 18:38:53 -03:00
David Capello
8cf1a185b6 [clang-format] Set AlignArrayOfStructures: Left
We get better results when defining command Params and scripting
structures (methods/properties).
2024-12-12 16:28:52 -03:00
David Capello
aff027dcf4 Update clang-format config with --dump-config (clang-format v19.1.5) 2024-12-12 15:52:32 -03:00
Christian Kaiser
2f0c107c3b Sort clang-format file 2024-12-12 13:44:52 -03:00
David Capello
1ace3bb601 Merge branch 'main' into beta 2024-12-11 16:28:47 -03:00
David Capello
8e1eee3b9c Enable clang-format config for C++ and Objective-C files 2024-12-11 16:27:07 -03:00
David Capello
6e9898b218 Merge branch 'main' into beta 2024-12-11 15:25:44 -03:00
David Capello
cb19167a6f Update laf module 2024-12-11 15:24:33 -03:00
David Capello
0d2f5a1a9e
Merge pull request #4828 from martincapello/fix-dropping-unsupported-files 2024-12-11 15:20:44 -03:00
David Capello
9a7ce8604b Merge branch 'main' into beta 2024-12-11 08:34:33 -03:00
David Capello
6cc0bbd0bf [precommit] Add GitHub action 2024-12-11 08:30:16 -03:00
David Capello
df19b09c23 Avoid using tabs in run-tests.sh expected output 2024-12-10 22:42:22 -03:00
David Capello
a154faf3f9 [precommit] Default EOL as LF (and CRLF for .cmd and .ps1 files) 2024-12-10 22:38:57 -03:00
David Capello
67a971618d [precommit] Allow tabs in .gpl files and .gitmodules 2024-12-10 22:15:30 -03:00
David Capello
f62b5eafb1 Merge branch 'main' into beta 2024-12-10 16:16:16 -03:00
David Capello
e47148a360 [pre-commit] Autoupdate packages 2024-12-10 14:06:43 -03:00
David Capello
db7c4658be [pre-commit] Remove codespell 2024-12-10 14:00:21 -03:00
Christian Kaiser
102624cad3 Add pre-commit configuration and documentation. 2024-12-10 13:52:39 -03:00
David Capello
f5f3cc03b9 Update laf module 2024-12-10 13:51:35 -03:00
David Capello
70f2cd9559 Remove duplicated code checking if mnemonic+modifiers are pressed 2024-12-10 10:16:20 -03:00
David Capello
cfc92e7cdb Add { } in switch-case to define vars inside
This is required if a new case is added below in the future to avoid
compiler errors. It's better to always use { } if we're going to
define local variables for the case.
2024-12-10 09:31:32 -03:00
Martín Capello
0edc4e16ed Disable and reset columns/rows according to type 2024-12-10 09:30:29 -03:00