mirror/Sunshine
1
0
Fork 0
mirror of https://github.com/LizardByte/Sunshine.git synced 2025-03-25 13:43:33 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Guard against missing parameters

Browse Source
This commit is contained in:
loki 2021-05-19 20:02:03 +02:00
parent 0868d898f6
commit cd870bdcdd
1 changed files with 44 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
sunshine/nvhttp.cpp
View File

@ -339,12 +339,19 @@ template<class T>
void pair(std::shared_ptr<safe::queue_t<crypto::x509_t>> &add_cert, std::shared_ptr<typename SimpleWeb::ServerBase<T>::Response> response, std::shared_ptr<typename SimpleWeb::ServerBase<T>::Request> request) { void pair(std::shared_ptr<safe::queue_t<crypto::x509_t>> &add_cert, std::shared_ptr<typename SimpleWeb::ServerBase<T>::Response> response, std::shared_ptr<typename SimpleWeb::ServerBase<T>::Request> request) {
print_req<T>(request); print_req<T>(request);
pt::ptree tree;
auto args = request->parse_query_string(); auto args = request->parse_query_string();
if(args.find("uniqueid"s) == std::end(args)) {
tree.put("root.resume", 0);
tree.put("root.<xmlattr>.status_code", 400);
return;
}
auto uniqID { std::move(args.at("uniqueid"s)) }; auto uniqID { std::move(args.at("uniqueid"s)) };
auto sess_it = map_id_sess.find(uniqID); auto sess_it = map_id_sess.find(uniqID);
pt::ptree tree;
args_t::const_iterator it; args_t::const_iterator it;
if(it = args.find("phrase"); it != std::end(args)) { if(it = args.find("phrase"); it != std::end(args)) {
if(it->second == "getservercert"sv) { if(it->second == "getservercert"sv) {
@ -505,9 +512,6 @@ void serverinfo(std::shared_ptr<typename SimpleWeb::ServerBase<T>::Response> res
void applist(resp_https_t response, req_https_t request) { void applist(resp_https_t response, req_https_t request) {
print_req<SimpleWeb::HTTPS>(request); print_req<SimpleWeb::HTTPS>(request);
auto args = request->parse_query_string();
auto clientID = args.at("uniqueid"s);
pt::ptree tree; pt::ptree tree;
auto g = util::fail_guard([&]() { auto g = util::fail_guard([&]() {
@ -517,6 +521,16 @@ void applist(resp_https_t response, req_https_t request) {
response->write(data.str()); response->write(data.str());
}); });
auto args = request->parse_query_string();
if(args.find("uniqueid"s) == std::end(args)) {
tree.put("root.resume", 0);
tree.put("root.<xmlattr>.status_code", 400);
return;
}
auto clientID = args.at("uniqueid"s);
auto client = map_id_client.find(clientID); auto client = map_id_client.find(clientID);
if(client == std::end(map_id_client)) { if(client == std::end(map_id_client)) {
tree.put("root.<xmlattr>.status_code", 501); tree.put("root.<xmlattr>.status_code", 501);
@ -558,7 +572,19 @@ void launch(resp_https_t response, req_https_t request) {
return; return;
} }
auto args = request->parse_query_string(); auto args = request->parse_query_string();
if(
args.find("uniqueid"s) == std::end(args) ||
args.find("rikey"s) == std::end(args) ||
args.find("rikey"s) == std::end(args) ||
args.find("appid"s) == std::end(args)) {
tree.put("root.resume", 0);
tree.put("root.<xmlattr>.status_code", 400);
return;
}
auto appid = util::from_view(args.at("appid")) - 1; auto appid = util::from_view(args.at("appid")) - 1;
auto current_appid = proc::proc.running(); auto current_appid = proc::proc.running();
@ -625,7 +651,18 @@ void resume(resp_https_t response, req_https_t request) {
stream::launch_session_t launch_session; stream::launch_session_t launch_session;
auto args = request->parse_query_string(); auto args = request->parse_query_string();
if(
args.find("uniqueid"s) == std::end(args) ||
args.find("rikey"s) == std::end(args) ||
args.find("rikeyid"s) == std::end(args)) {
tree.put("root.resume", 0);
tree.put("root.<xmlattr>.status_code", 400);
return;
}
auto clientID = args.at("uniqueid"s); auto clientID = args.at("uniqueid"s);
launch_session.gcm_key = *util::from_hex<crypto::aes_t>(args.at("rikey"s), true); launch_session.gcm_key = *util::from_hex<crypto::aes_t>(args.at("rikey"s), true);
uint32_t prepend_iv = util::endian::big<uint32_t>(util::from_view(args.at("rikeyid"s))); uint32_t prepend_iv = util::endian::big<uint32_t>(util::from_view(args.at("rikeyid"s)));