config file was being freed at the end of input_remapping_load_file
when the menu_cbs_ok.c function was still using it afterwards - move
the config_file_free outside of the function and free manually
afterwards when we're done
==27741== Conditional jump or move depends on uninitialised value(s)
==27741== at 0x6080F5: strlcpy_retro__ (compat_strl.c:38)
==27741== by 0x60818A: strlcat_retro__ (compat_strl.c:60)
==27741== by 0x49EDD7: fill_pathname_join_special_ext (file_path.c:843)
==27741== by 0x4C78C8: config_load_remap (configuration.c:3765)
==27741== by 0x4386FF: command_event_init_core (retroarch.c:12601)
==27741== by 0x43B15E: command_event (retroarch.c:14000)
==27741== by 0x468863: retroarch_main_init (retroarch.c:35231)
==27741== by 0x487AED: content_load (task_content.c:607)
==27741== by 0x48A3D3: task_load_content_internal (task_content.c:2068)
==27741== by 0x48A6AD: task_push_load_content_from_cli (task_content.c:2162)
==27741== by 0x43D66E: rarch_main (retroarch.c:15300)
==27741== by 0x43D6ED: main (retroarch.c:15398)
==27741== Uninitialised value was created by a stack allocation
==27741== at 0x4C7730: config_load_remap (configuration.c:3721)
So far, if display is scaled, overlays gets correctly drawn but touch
input is not correctly scaled, resulting in an unusable overlay.
This happens for touches in menu too.
This commit aims to introduce this scaling factor adding it to the
config file, eg:
input_touch_scale = "2"
As some issues indicate (#6195#10471#11008#6861) there's an issue with
the autoincrement save slot feature: slot index will increase and very old
saves won't be deleted.
This commit adds support to delete old save states with a user defined
save state limit (global). Instead of wrapping around the slot counter
it will simply delete the oldest save, since it is simpler.
For now there's a limit of one deletion per save, which ensures a user
cannot delete many saves by accident if they set the limit too low.
