46936 Commits

Author SHA1 Message Date
orbea
5175c67381 menu: Fix directory settings.
The "Recording Output" and "Screenshot" directory settings accidentally
overwrote each other.

Fixes https://github.com/libretro/RetroArch/issues/7776
2018-12-20 11:13:28 -08:00
orbea
066bbd1a29 Makefile.common: Remove redundant conditionals.
C89 builds are only used for the qb build system currently and these are
already checked in qb/config.params.sh.

Additionally the HAVE_NETWORKING check is handled with qb/config.lib.sh
where HAVE_SSL and HAVE_BUILTINMBEDTLS are disabled if networking is
also disabled. The other build systems should never define HAVE_SSL or
HAVE_BUILTINMBEDTLS without HAVE_NETWORKING. Also there are no other
build systems that rely on Makefile.common using this yet.
2018-12-20 10:49:23 -08:00
jdgleaver
f603d4ec30 (RGUI) Enable customisation of background and border colours 2018-12-20 16:13:16 +00:00
Brad Parker
d41bb64d17 remove unused code 2018-12-20 09:00:48 -05:00
Twinaphex
a0a22a044a
Merge pull request #7773 from orbea/comment
Makefile.ctr: Add missing comment.
2018-12-20 13:58:36 +01:00
Twinaphex
4f270449f9
Merge pull request #7774 from bparker06/hold_start
add option to toggle menu by holding down start button
2018-12-20 13:58:18 +01:00
CozmoP
7bb23d15bd Fix last commit and a couple style changes. 2018-12-19 21:28:11 +01:00
Brad Parker
458bb9fbb5 add option to toggle menu by holding down start button 2018-12-19 14:53:17 -05:00
orbea
2c09a6f37b Makefile.ctr: Add missing comment. 2018-12-19 11:27:10 -08:00
Brad Parker
fd93e5e26e Update CHANGES.md 2018-12-19 12:04:11 -05:00
Twinaphex
26568a6bc2
Merge pull request #7770 from jdgleaver/rgui-user-index
(RGUI) Add user index label to control menu entries
2018-12-19 17:47:53 +01:00
Twinaphex
a7bb1e60aa
Merge pull request #7771 from libretro/sgc-menu-animation
Animations deleted whilst in update loop may cause crash
2018-12-19 17:45:58 +01:00
jdgleaver
f68d756af3 (RGUI) Add user index label to control menu entries 2018-12-19 12:19:29 +00:00
CozmoP
a396008bf6 Qt: More C89 changes. 2018-12-19 08:57:00 +01:00
Twinaphex
7835d0c54c
Merge pull request #7745 from orbea/mbedtls
Support building with the system mbedtls.
2018-12-19 01:53:14 +01:00
Twinaphex
0b0a21b742
Merge pull request #7768 from jdgleaver/3ds-named-inputs
(3DS) Add joypad input labels
2018-12-19 01:21:05 +01:00
Stuart Carnie
11a7d34358
fix: animations deleted during update mutate tween list, causing crash
defer deletes resulting from callbacks until after update loop
2018-12-18 17:12:19 -07:00
CozmoP
95ed844d81 Qt: C89 changes and other cleanups. 2018-12-19 01:11:52 +01:00
jdgleaver
37acbd1ecf (3DS) Add joypad input labels 2018-12-18 16:30:05 +00:00
Twinaphex
22fcd0be67
Merge pull request #7762 from orbea/rgui
Fix gcc -Wformat-truncation= warnings.
2018-12-18 10:12:50 +01:00
Brad Parker
d6741651b7 net_socket_ssl: keep reading data from server until finished, fixes #7451 2018-12-18 03:01:52 -05:00
Twinaphex
c565bb1b0b
Merge pull request #7763 from bparker06/sideload_vfs
use filestream/VFS for core sideload
2018-12-17 21:40:32 +01:00
Brad Parker
4b323a45df paths can be const 2018-12-17 09:38:12 -05:00
Brad Parker
971591fb9c use filestream/VFS for core sideload 2018-12-17 09:25:52 -05:00
orbea
13e29308d5 Fix gcc -Wformat-truncation= warnings.
menu/drivers/rgui.c: In function ‘rgui_render’:
menu/drivers/rgui.c:670:53: warning: ‘%-*s’ directive output may be truncated writing up to 2147483648 bytes into a region of size between 0 and 252 [-Wformat-truncation=]
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                                     ^~~~
menu/drivers/rgui.c:676:13:
             type_str_buf);
             ~~~~~~~~~~~~
menu/drivers/rgui.c:670:42: note: assuming directive output of 254 bytes
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                          ^~~~~~~~~~~~~~~~
menu/drivers/rgui.c:670:7: note: ‘snprintf’ output between 4 and 4294967300 bytes into a destination of size 255
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_selected ? '>' : ' ',
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_title_buf,
             ~~~~~~~~~~~~~~~~
             entry_spacing,
             ~~~~~~~~~~~~~~
             type_str_buf);
             ~~~~~~~~~~~~~
menu/drivers/rgui.c:670:53: warning: ‘%-*s’ directive output may be truncated writing up to 2147483648 bytes into a region of size between 0 and 252 [-Wformat-truncation=]
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                                     ^~~~
menu/drivers/rgui.c:676:13:
             type_str_buf);
             ~~~~~~~~~~~~
menu/drivers/rgui.c:670:42: note: assuming directive output of 254 bytes
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                          ^~~~~~~~~~~~~~~~
menu/drivers/rgui.c:670:7: note: ‘snprintf’ output between 4 and 4294967300 bytes into a destination of size 255
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_selected ? '>' : ' ',
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_title_buf,
             ~~~~~~~~~~~~~~~~
             entry_spacing,
             ~~~~~~~~~~~~~~
             type_str_buf);
             ~~~~~~~~~~~~~
2018-12-16 20:22:53 -08:00
Twinaphex
af0bf7a992
Merge pull request #7761 from orbea/c89
Fix gcc warnings with C89_BUILD.
2018-12-17 05:18:13 +01:00
Twinaphex
6dcdb843e8
Merge pull request #7758 from fr500/sideload
Sideload
2018-12-17 05:15:41 +01:00
orbea
d557ab09ce Fix a gcc -Wformat= warning with C89_BUILD.
network/netplay/netplay_frontend.c: In function ‘netplay_announce_cb’:
network/netplay/netplay_frontend.c:734:32: warning: format ‘%X’ expects argument of type ‘unsigned int *’, but argument 3 has type ‘int *’ [-Wformat=]
                sscanf(val, "%08X", &host_room->gamecrc);
                             ~~~^   ~~~~~~~~~~~~~~~~~~~
                             %08X
2018-12-16 19:59:53 -08:00
orbea
14905e33e1 Fix more gcc -Wformat= warnings with C89_BUILD.
The "z" modifier was introduced in c99, but using "l" instead
seems to work.

setting_list.c: In function ‘setting_get_string_representation_size’:
setting_list.c:175:24: warning: ISO C90 does not support the ‘z’ gnu_printf length modifier [-Wformat=]
       snprintf(s, len, "%" PRI_SIZET,
                        ^~~
setting_list.c: In function ‘setting_get_string_representation_size_in_mb’:
setting_list.c:183:24: warning: ISO C90 does not support the ‘z’ gnu_printf length modifier [-Wformat=]
       snprintf(s, len, "%" PRI_SIZET,
                        ^~~
setting_list.c: In function ‘setting_set_with_string_representation’:
setting_list.c:508:24: warning: ISO C90 does not support the ‘z’ gnu_scanf length modifier [-Wformat=]
          sscanf(value, "%" PRI_SIZET, setting->value.target.sizet);
                        ^~~

libretro-common/file/config_file.c: In function ‘config_get_size_t’:
libretro-common/file/config_file.c:692:32: warning: ISO C90 does not support the ‘z’ gnu_scanf length modifier [-Wformat=]
       if (sscanf(entry->value, "%" PRI_SIZET, &val) == 1
2018-12-16 19:59:50 -08:00
orbea
169002ef7f Fix a gcc -Wformat= warning with C89_BUILD.
The posix spec claims "%r" is equivelent to "%I : %M : %S %p".

Source: http://pubs.opengroup.org/onlinepubs/9699919799/functions/strftime.html

menu/menu_driver.c:395:15: warning: ISO C90 does not support the ‘%r’ gnu_strftime format [-Wformat=]
             "%r", localtime(&time_));
               ^
2018-12-16 19:59:47 -08:00
orbea
30e5f1dfef Fix gcc -Wformat warnings with C89_BUILD.
gfx/display_servers/dispserv_x11.c: In function ‘x11_display_server_set_resolution’:
gfx/display_servers/dispserv_x11.c:221:76: warning: ISO C90 does not support the ‘%lf’ gnu_printf format [-Wformat=]
       snprintf(xrandr, sizeof(xrandr), "xrandr --newmode \"%dx%d_%0.2f\" %lf %d %d %d %d %d %d %d %d -hsync -vsync", width, height, hz, pixel_clock,
                                                                            ^
gfx/display_servers/dispserv_x11.c:228:76: warning: ISO C90 does not support the ‘%lf’ gnu_printf format [-Wformat=]
       snprintf(xrandr, sizeof(xrandr), "xrandr --newmode \"%dx%d_%0.2f\" %lf %d %d %d %d %d %d %d %d interlace -hsync -vsync", width, height, hz, pixel_clock,
                                                                            ^
2018-12-16 19:15:45 -08:00
Twinaphex
26cb223852
Merge pull request #7760 from orbea/clang
Fix warnings with clang.
2018-12-17 01:54:13 +01:00
orbea
47666fb4a8 Fix clang -Wuninitialized warning.
dynamic.c:188:26: warning: variable 'i' is uninitialized when used here [-Wuninitialized]
         unsigned size = i;
                         ^
dynamic.c:187:20: note: initialize the variable 'i' to silence this warning
         unsigned i, j;
                   ^
                    = 0
1 warning generated.
2018-12-16 16:28:37 -08:00
Twinaphex
9feeaecb12
Merge pull request #7759 from grant2258/mouse
use none zero as requested for udev mouse
2018-12-17 01:25:32 +01:00
orbea
4bc0aacd8b Fix clang -Wreorder warnings.
gfx/drivers_shader/shader_vulkan.cpp:1109:6: warning: field 'id' will be initialized after field 'device' [-Wreorder]
   : id(move(id)),
     ^
gfx/drivers_shader/shader_vulkan.cpp:2107:4: warning: field 'device' will be initialized after field 'memory_properties' [-Wreorder]
   device(device),
   ^
2 warnings generated.
2018-12-16 16:16:07 -08:00
grant2258
3a0c27e753 use none zero as requested 2018-12-17 00:07:00 +00:00
twinaphex
862a4e099b Duplicate entry removed 2018-12-17 00:07:35 +01:00
Twinaphex
fbb095cc06
Merge pull request #7730 from grant2258/mouse
fix udev mouse
2018-12-16 23:17:06 +01:00
radius
6c936274b7 make file copy operation a function
add sublabels

improve localization
2018-12-16 16:55:12 -05:00
grant2258
74de0ade03 resolve changes 2018-12-16 20:52:15 +00:00
Twinaphex
708c9c0774
Merge pull request #7754 from orbea/c89
Fix C89 build with clang.
2018-12-16 19:47:17 +01:00
Twinaphex
fc6b3b7335
Merge pull request #7755 from fr500/fixes
subsystem: remember last used folder
2018-12-16 19:46:01 +01:00
radius
16d1cf28f7 only show with advanced options and on dynamic platforms 2018-12-16 12:42:10 -05:00
radius
bfd23150b5 add core sideloading option 2018-12-16 12:42:09 -05:00
radius
319124c7a0 subsystem: remember last used folder 2018-12-16 12:33:27 -05:00
orbea
d40da6aca3 Fix c89 'keyword is hidden by macro definition' with clang. 2018-12-16 08:01:03 -08:00
orbea
6e95a62fdf Fix c89 build with clang. 2018-12-16 07:02:14 -08:00
Twinaphex
c0ea6e7574
Merge pull request #7753 from orbea/c89
Fix c89 build.
2018-12-16 07:53:05 +01:00
orbea
f4a5c3bd55 Fix c89 build. 2018-12-15 21:03:28 -08:00
Twinaphex
94d5457106
Merge pull request #7752 from orbea/typo
qb: Fix typo.
2018-12-16 05:39:52 +01:00