mirror/OpenMW
1
0
Fork 0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2025-02-04 21:40:03 +00:00
Code Issues Projects Releases Wiki Activity
OpenMW/apps/openmw/mwgui
History
elsid a0cfcc50a2
Fix dangling pointer access on clicking save in the main menu 
getSignature() returns an object which means expression like:
className = it->getSignature().mPlayerClassName;
assigns a temporary object to className that does not outlive the statement.
Having className a string view such code leads to a dangling pointer.

Return a reference from getSignature to save on redundant copying.

Change getSignature implementation to make it visible that it finds a maximum
element.

Do not call getSignature multiple times when possible to avoid seaching for the
same max element multiple times.
2022-09-15 22:49:20 +02:00
..
alchemywindow.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
alchemywindow.hpp
Appease the evil spirits of C++
2022-09-01 18:25:41 +02:00
backgroundimage.cpp
Replace all NULLs to nullptr
2018-10-09 10:21:12 +04:00
backgroundimage.hpp
components/compiler cleanup; also cleaned up related cascading warnings; fixed up final/override issues
2020-10-22 23:57:53 +02:00
birth.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
birth.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
bookpage.cpp
Cleanup openmw render, physics, world, dialogue, gui, input includes
2022-08-17 18:45:52 +02:00
bookpage.hpp
Cleanup openmw render, physics, world, dialogue, gui, input includes
2022-08-17 18:45:52 +02:00
bookwindow.cpp
move most of the files from esm to esm3, keep common code in esm; this is make space for a future with esm4
2022-01-23 17:04:48 +01:00
bookwindow.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
charactercreation.cpp
Add comma to the last array element to prevent putting multiple elements on a single line
2022-09-14 00:36:02 +02:00
charactercreation.hpp
Use std::unique_ptr to manage dialogs lifetime
2022-08-21 21:04:21 +02:00
class.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
class.hpp
Remove various string copies
2022-08-24 20:38:52 +02:00
companionitemmodel.cpp
Make getScript return string_view
2022-08-11 22:51:55 +02:00
companionitemmodel.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
companionwindow.cpp
Use std::unique_ptr in ItemView
2022-08-31 19:03:45 +02:00
companionwindow.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
confirmationdialog.cpp
Fixes bug #4650
2019-09-02 16:49:29 +02:00
confirmationdialog.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
console.cpp
partially revert "Store: moved all the template specialization to its own heaper file, included where it's needed"
2022-09-05 17:35:06 +02:00
console.hpp
Cleanup openmw render, physics, world, dialogue, gui, input includes
2022-08-17 18:45:52 +02:00
container.cpp
Use std::unique_ptr in ItemView
2022-08-31 19:03:45 +02:00
container.hpp
Force the loot UI open if it was open while resurrecting the lootee
2021-12-01 18:21:21 +01:00
containeritemmodel.cpp
improves MWClass mapping (#3166)
2021-10-11 13:46:21 +02:00
containeritemmodel.hpp
Sprinkle some const-ref
2021-08-15 19:50:28 +02:00
controllers.cpp
Get rid of redundant ControllerRepeatClick class
2019-05-17 10:49:00 +04:00
controllers.hpp
components/compiler cleanup; also cleaned up related cascading warnings; fixed up final/override issues
2020-10-22 23:57:53 +02:00
countdialog.cpp
Partially revert "Get rid of redundant setKeyFocusWidget() method"
2019-06-09 02:12:44 +03:00
countdialog.hpp
Refactor exitCurrentGuiMode
2017-09-24 19:08:13 +02:00
cursor.cpp
Replace all NULLs to nullptr
2018-10-09 10:21:12 +04:00
cursor.hpp
components/compiler cleanup; also cleaned up related cascading warnings; fixed up final/override issues
2020-10-22 23:57:53 +02:00
debugwindow.cpp
Improve built-in default fonts
2022-08-30 07:54:20 +00:00
debugwindow.hpp
Move statics into cpp and properly guard buffer from race conditions
2022-06-07 16:59:44 +03:00
dialogue.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
dialogue.hpp
Appease the evil spirits of C++
2022-09-01 18:25:41 +02:00
draganddrop.cpp
Return string_view from SoundId methods
2022-08-14 14:39:58 +02:00
draganddrop.hpp
Exit drag-and-drop if dragged item is deleted (Fixes #3097)
2017-09-26 16:51:19 +02:00
enchantingdialog.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
enchantingdialog.hpp
Remove forward declarations used by smart pointers
2022-09-01 17:20:15 +02:00
exposedwindow.cpp
Allow to maximize windows via Shift + Double Click (feature #3999)
2019-05-01 20:15:11 +04:00
exposedwindow.hpp
Allow to maximize windows via Shift + Double Click (feature #3999)
2019-05-01 20:15:11 +04:00
formatting.cpp
Split components/misc/stringops.hpp into multiple headers
2022-08-03 22:06:24 +02:00
formatting.hpp
Introduce font mappings
2022-07-17 22:01:48 +04:00
hud.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
hud.hpp
Remove forward declarations used by smart pointers
2022-09-01 17:20:15 +02:00
inventoryitemmodel.cpp
Sprinkle some const-ref
2021-08-15 19:50:28 +02:00
inventoryitemmodel.hpp
Sprinkle some const-ref
2021-08-15 19:50:28 +02:00
inventorywindow.cpp
Use std::unique_ptr in ItemView
2022-08-31 19:03:45 +02:00
inventorywindow.hpp
Fix Avatar Preview Coordinate Transformations in the Inventory (Issues #6129, #6131)
2021-07-04 08:36:59 +00:00
itemchargeview.cpp
Return string_view from getGameSettingString
2022-08-24 22:16:03 +02:00
itemchargeview.hpp
components/compiler cleanup; also cleaned up related cascading warnings; fixed up final/override issues
2020-10-22 23:57:53 +02:00
itemmodel.cpp
Use std::unique_ptr in ProxyItemModel
2022-08-31 18:49:50 +02:00
itemmodel.hpp
Use std::unique_ptr in ProxyItemModel
2022-08-31 18:49:50 +02:00
itemselection.cpp
Use std::unique_ptr in ItemView
2022-08-31 19:03:45 +02:00
itemselection.hpp
Remove forward declarations used by smart pointers
2022-09-01 17:20:15 +02:00
itemview.cpp
Use std::unique_ptr in ItemView
2022-08-31 19:03:45 +02:00
itemview.hpp
Use std::unique_ptr in ItemView
2022-08-31 19:03:45 +02:00
itemwidget.cpp
Improve built-in default fonts
2022-08-30 07:54:20 +00:00
itemwidget.hpp
components/compiler cleanup; also cleaned up related cascading warnings; fixed up final/override issues
2020-10-22 23:57:53 +02:00
jailscreen.cpp
Split components/misc/stringops.hpp into multiple headers
2022-08-03 22:06:24 +02:00
jailscreen.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
journalbooks.cpp
Fix out-of-bounds access in JournalBooks::createCyrillicJournalIndex
2021-05-15 10:45:39 -04:00
journalbooks.hpp
Use field for columns count instead of out integer
2018-09-12 14:31:01 +04:00
journalviewmodel.cpp
Remove various string copies
2022-08-24 20:38:52 +02:00
journalviewmodel.hpp
Remove various string copies
2022-08-24 20:38:52 +02:00
journalwindow.cpp
Use std::unique_ptr in WindowManager
2022-08-31 21:07:59 +02:00
journalwindow.hpp
Use std::unique_ptr in WindowManager
2022-08-31 21:07:59 +02:00
keyboardnavigation.cpp
Clean up MyGUI includes
2022-06-04 15:26:36 +02:00
keyboardnavigation.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
layout.cpp
Return string_view from getGameSettingString
2022-08-24 22:16:03 +02:00
layout.hpp
Return string_view from getGameSettingString
2022-08-24 22:16:03 +02:00
levelupdialog.cpp
Use string_view in Fallback::Map
2022-08-28 17:20:49 +02:00
levelupdialog.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
loadingscreen.cpp
Use string_view in the remaining Class methods and push string_views closer to the MyGUI boundary
2022-08-23 22:14:27 +02:00
loadingscreen.hpp
Refactor UI layers
2022-02-26 13:54:42 +00:00
mainmenu.cpp
Use std::unique_ptr in MainMenu
2022-08-31 19:05:32 +02:00
mainmenu.hpp
Remove forward declarations used by smart pointers
2022-09-01 17:20:15 +02:00
mapwindow.cpp
partially revert "Store: moved all the template specialization to its own heaper file, included where it's needed"
2022-09-05 17:35:06 +02:00
mapwindow.hpp
Replace shared_ptr by unique_ptr
2022-04-08 22:42:22 +02:00
merchantrepair.cpp
Make Class::getName return string_view
2022-08-16 21:15:03 +02:00
merchantrepair.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
messagebox.cpp
Use std::unique_ptr in MessageBoxManager
2022-08-31 19:44:04 +02:00
messagebox.hpp
Use std::unique_ptr in MessageBoxManager
2022-08-31 19:44:04 +02:00
mode.hpp
Make console to do not hide other GUI windows (bug #1515)
2019-05-29 17:10:57 +04:00
pickpocketitemmodel.cpp
Use std::unique_ptr in ProxyItemModel
2022-08-31 18:49:50 +02:00
pickpocketitemmodel.hpp
Use std::unique_ptr in ProxyItemModel
2022-08-31 18:49:50 +02:00
postprocessorhud.cpp
Use more string_view
2022-08-28 15:06:31 +02:00
postprocessorhud.hpp
Clean up MyGUI includes
2022-06-04 15:26:36 +02:00
quickkeysmenu.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
quickkeysmenu.hpp
Remove forward declarations used by smart pointers
2022-09-01 17:20:15 +02:00
race.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
race.hpp
Allow mouse scrolling in the race preview widget (feature 6925)
2022-08-06 11:25:27 +04:00
recharge.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
recharge.hpp
Use std::unique_ptr to manage dialogs lifetime
2022-08-21 21:04:21 +02:00
referenceinterface.cpp
Some PVS-Studio and cppcheck fixes
2018-04-18 12:36:10 +00:00
referenceinterface.hpp
Remove redundant player cell variable
2017-09-24 19:08:13 +02:00
repair.cpp
Use std::unique_ptr in ProxyItemModel
2022-08-31 18:49:50 +02:00
repair.hpp
Use std::unique_ptr to manage dialogs lifetime
2022-08-21 21:04:21 +02:00
resourceskin.cpp
Split components/misc/stringops.hpp into multiple headers
2022-08-03 22:06:24 +02:00
resourceskin.hpp
components/compiler cleanup; also cleaned up related cascading warnings; fixed up final/override issues
2020-10-22 23:57:53 +02:00
review.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
review.hpp
Return string_view from getGameSettingString
2022-08-24 22:16:03 +02:00
savegamedialog.cpp
Fix dangling pointer access on clicking save in the main menu
2022-09-15 22:49:20 +02:00
savegamedialog.hpp
Enlarge character selection menu to fit long character or class names
2022-08-28 21:35:11 +04:00
screenfader.cpp
Refactor UI layers
2022-02-26 13:54:42 +00:00
screenfader.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
scrollwindow.cpp
move most of the files from esm to esm3, keep common code in esm; this is make space for a future with esm4
2022-01-23 17:04:48 +01:00
scrollwindow.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
settingswindow.cpp
Make Settings::Manager::getString return a reference
2022-08-28 16:38:11 +02:00
settingswindow.hpp
Bring back empty script message
2022-07-30 08:07:24 +00:00
sortfilteritemmodel.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
sortfilteritemmodel.hpp
Use std::unique_ptr in ProxyItemModel
2022-08-31 18:49:50 +02:00
soulgemdialog.cpp
Use emplace_back instead of push_back
2020-10-18 10:27:35 +04:00
soulgemdialog.hpp
Added soulgem dialog; made interactive message boxes not close the previous UI
2013-03-30 15:51:07 +01:00
spellbuyingwindow.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
spellbuyingwindow.hpp
Remove unused forward declarations
2021-04-11 14:46:51 +02:00
spellcreationdialog.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
spellcreationdialog.hpp
Use std::unique_ptr to manage dialogs lifetime
2022-08-21 21:04:21 +02:00
spellicons.cpp
partially revert "Store: moved all the template specialization to its own heaper file, included where it's needed"
2022-09-05 17:35:06 +02:00
spellicons.hpp
Overhaul magic effects to work with onApply and onEnd events
2021-09-29 19:25:10 +02:00
spellmodel.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
spellmodel.hpp
move most of the files from esm to esm3, keep common code in esm; this is make space for a future with esm4
2022-01-23 17:04:48 +01:00
spellview.cpp
Improve handling of larger font size
2022-08-18 13:29:12 +04:00
spellview.hpp
components/compiler cleanup; also cleaned up related cascading warnings; fixed up final/override issues
2020-10-22 23:57:53 +02:00
spellwindow.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
spellwindow.hpp
Remove forward declarations used by smart pointers
2022-09-01 17:20:15 +02:00
statswatcher.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
statswatcher.hpp
move most of the files from esm to esm3, keep common code in esm; this is make space for a future with esm4
2022-01-23 17:04:48 +01:00
statswindow.cpp
Add comma to the last array element to prevent putting multiple elements on a single line
2022-09-14 00:36:02 +02:00
statswindow.hpp
Return string_view from getGameSettingString
2022-08-24 22:16:03 +02:00
textcolours.cpp
Move TextColours initialization to the TextColours itself
2020-05-26 18:35:16 +04:00
textcolours.hpp
Move TextColours initialization to the TextColours itself
2020-05-26 18:35:16 +04:00
textinput.cpp
Return string_view from getGameSettingString
2022-08-24 22:16:03 +02:00
textinput.hpp
Return string_view from getGameSettingString
2022-08-24 22:16:03 +02:00
timeadvancer.cpp
Constify a few things
2021-04-11 14:46:51 +02:00
timeadvancer.hpp
Clean up MyGUI includes
2022-06-04 15:26:36 +02:00
tooltips.cpp
Localize the 'show effect duration' option
2022-09-08 07:46:56 +04:00
tooltips.hpp
Show the soulgem soul in count dialog (feature #5362)
2020-04-12 11:55:00 +03:00
tradeitemmodel.cpp
Use std::unique_ptr in ProxyItemModel
2022-08-31 18:49:50 +02:00
tradeitemmodel.hpp
Use std::unique_ptr in ProxyItemModel
2022-08-31 18:49:50 +02:00
tradewindow.cpp
Use std::unique_ptr in ItemView
2022-08-31 19:03:45 +02:00
tradewindow.hpp
Update tradewindow.hpp
2021-10-04 20:47:45 +00:00
trainingwindow.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
trainingwindow.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
travelwindow.cpp
fewer header includes
2022-09-08 21:08:59 +02:00
travelwindow.hpp
Sprinkle some const-ref
2021-08-15 19:50:28 +02:00
ustring.hpp
Return string_view from getGameSettingString
2022-08-24 22:16:03 +02:00
videowidget.cpp
Replace new with make_unique in openmw
2022-05-29 13:24:48 +02:00
videowidget.hpp
Pause both audio and video playback when the game is minimized (feature #4944)
2020-04-04 22:54:51 +04:00
waitdialog.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
waitdialog.hpp
Mark overrided methods by override keyword
2020-10-16 22:18:54 +04:00
widgets.cpp
With the records include removed from store.hpp, need to include the relevant files accross the codebase.Lots of touched files, but very little done
2022-09-06 13:26:13 +02:00
widgets.hpp
Return string_view from getGameSettingString
2022-08-24 22:16:03 +02:00
windowbase.cpp
Use string_view in Layout and remove dead code
2022-06-27 19:13:17 +02:00
windowbase.hpp
Use string_view in Layout and remove dead code
2022-06-27 19:13:17 +02:00
windowmanagerimp.cpp
Implement system-scaled HiDPI support (SDL_WINDOW_ALLOW_HIGHDPI - Wayland, macOS, etc)
2022-09-12 08:18:08 +00:00
windowmanagerimp.hpp
Make sure all paths are passed as std::filesystem::path instead of std::string where possible.
2022-09-11 14:41:15 +02:00
windowpinnablebase.cpp
Allow to maximize windows via Shift + Double Click (feature #3999)
2019-05-01 20:15:11 +04:00
windowpinnablebase.hpp
Remove unused forward declarations
2021-04-11 14:46:51 +02:00