1
0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2024-12-27 06:14:09 +00:00
OpenMW/components/sdlutil
AnyOldName3 28131fd62b Fixes for a whole bunch of warnings
These warnings were always enabled, but we didn't see them due to https://gitlab.com/OpenMW/openmw/-/issues/7882.
I do not fully understand the cause of 7822 as I can't repro it in a minimal CMake project.

Some of these fixes are thought through.
Some are sensible best guesses.
Some are kind of a stab in the dark as I don't know whether there was a
possible bug the warning was telling me about that I've done nothing to
help by introducing a static_cast.

Nearly all of these warnings were about some kind of narrowing
conversion, so I'm not sure why they weren't firing with GCC and Clang,
which have -Wall -Wextra -pedantic set, which should imply -Wnarrowing,
and they can't have been affected by 7882.

There were also some warnings being triggered from Boost code.
The vast majority of library headers that do questionable things weren't
firing warnings off, but for some reason, /external:I wasn't putting
these Boost headers into external mode.

We need these warnings dealt with one way or another so we can switch
the default Windows CI from MSBuild (which doesn't do ccache) to Ninja
(which does).
I have the necessary magic for that on a branch, but the branch won't
build because of these warnings.
2024-03-14 23:39:33 +00:00
..
events.hpp
gl4es_init.cpp
gl4es_init.h
imagetosurface.cpp
imagetosurface.hpp
sdlcursormanager.cpp
sdlcursormanager.hpp
sdlgraphicswindow.cpp
sdlgraphicswindow.hpp
sdlinputwrapper.cpp
sdlinputwrapper.hpp
sdlmappings.cpp Fixes for a whole bunch of warnings 2024-03-14 23:39:33 +00:00
sdlmappings.hpp
sdlvideowrapper.cpp
sdlvideowrapper.hpp
vsyncmode.hpp