mirror/OpenMW
1
0
Fork 0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2025-02-21 09:39:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1726 from elsid/fix_catch_warnings

Browse Source 
Fix warnings: catching polymorphic type by value
This commit is contained in:
Bret Curtis 2018-06-02 19:36:04 +02:00 committed by GitHub
commit 4a2b973052
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/openmw/mwworld/worldimp.cpp
View File

@ -2601,11 +2601,11 @@ namespace MWWorld
int y = std::stoi(name.substr(name.find(',')+1)); int y = std::stoi(name.substr(name.find(',')+1));
ext = getExterior(x, y)->getCell(); ext = getExterior(x, y)->getCell();
} }
catch (std::invalid_argument) catch (const std::invalid_argument&)
{ {
// This exception can be ignored, as this means that name probably refers to a interior cell instead of comma separated coordinates // This exception can be ignored, as this means that name probably refers to a interior cell instead of comma separated coordinates
} }
catch (std::out_of_range) catch (const std::out_of_range&)
{ {
throw std::runtime_error("Cell coordinates out of range."); throw std::runtime_error("Cell coordinates out of range.");
} }

4
components/widgets/numericeditbox.cpp
View File

@ -38,11 +38,11 @@ namespace Gui
setCaption(MyGUI::utility::toString(mValue)); setCaption(MyGUI::utility::toString(mValue));
} }
} }
catch (std::invalid_argument) catch (const std::invalid_argument&)
{ {
setCaption(MyGUI::utility::toString(mValue)); setCaption(MyGUI::utility::toString(mValue));
} }
catch (std::out_of_range) catch (const std::out_of_range&)
{ {
setCaption(MyGUI::utility::toString(mValue)); setCaption(MyGUI::utility::toString(mValue));
} }