mirror/OpenMW
1
0
Fork 0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2025-01-06 00:55:50 +00:00
Code Issues Projects Releases Wiki Activity

Fix warnings: catching polymorphic type by value

Browse Source 
openmw/apps/openmw/mwworld/worldimp.cpp: In member function ‘virtual bool MWWorld::World::findExteriorPosition(const string&, ESM::Position&)’:
openmw/apps/openmw/mwworld/worldimp.cpp:2650:25: warning: catching polymorphic type ‘class std::invalid_argument’ by value [-Wcatch-value=]
             catch (std::invalid_argument)
                         ^~~~~~~~~~~~~~~~
openmw/apps/openmw/mwworld/worldimp.cpp:2654:25: warning: catching polymorphic type ‘class std::out_of_range’ by value [-Wcatch-value=]
             catch (std::out_of_range)
                         ^~~~~~~~~~~~

openmw/components/widgets/numericeditbox.cpp: In member function ‘void Gui::NumericEditBox::onEditTextChange(MyGUI::EditBox*)’:
openmw/components/widgets/numericeditbox.cpp:41:21: warning: catching polymorphic type ‘class std::invalid_argument’ by value [-Wcatch-value=]
         catch (std::invalid_argument)
                     ^~~~~~~~~~~~~~~~
openmw/components/widgets/numericeditbox.cpp:45:21: warning: catching polymorphic type ‘class std::out_of_range’ by value [-Wcatch-value=]
         catch (std::out_of_range)
                     ^~~~~~~~~~~~
This commit is contained in:
elsid 2018-06-02 14:28:05 +03:00
parent d73c6ebe60
commit dba79f4d4d
No known key found for this signature in database
GPG Key ID: B845CB9FEE18AB40
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/openmw/mwworld/worldimp.cpp
View File

@ -2601,11 +2601,11 @@ namespace MWWorld
int y = std::stoi(name.substr(name.find(',')+1));
ext = getExterior(x, y)->getCell();
}
catch (std::invalid_argument)
catch (const std::invalid_argument&)
{
// This exception can be ignored, as this means that name probably refers to a interior cell instead of comma separated coordinates
}
catch (std::out_of_range)
catch (const std::out_of_range&)
{
throw std::runtime_error("Cell coordinates out of range.");
}

4
components/widgets/numericeditbox.cpp
View File

@ -38,11 +38,11 @@ namespace Gui
setCaption(MyGUI::utility::toString(mValue));
}
}
catch (std::invalid_argument)
catch (const std::invalid_argument&)
{
setCaption(MyGUI::utility::toString(mValue));
}
catch (std::out_of_range)
catch (const std::out_of_range&)
{
setCaption(MyGUI::utility::toString(mValue));
}