Merge branch 'fix_esm4_init_coverity_issues' into 'master'

Remove used-defined constructors from ESM4 types

See merge request OpenMW/openmw!1688

components/esm4/acti.hpp

@@ -57,7 +57,6 @@ namespace ESM4
 
         std::string mActivationPrompt;
 
-        Activator();
         virtual ~Activator();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/lighting.hpp

@@ -28,6 +28,7 @@
 #define ESM4_LIGHTING_H
 
 #include <cstdint>
+#include <limits>
 
 namespace ESM4
 {
@@ -44,7 +45,7 @@ namespace ESM4
         std::int32_t  rotationZ;   // rotation z    | 00 00 00 00 = 0
         float         fogDirFade;  // Fog dir fade  | 00 00 80 3F = 1.f
         float         fogClipDist; // Fog clip dist | 00 80 3B 45 = 3000.f
-        float         fogPower;
+        float         fogPower = std::numeric_limits<float>::max();
     };
 
     struct Lighting_TES5

components/esm4/loadachr.cpp

@@ -32,16 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::ActorCharacter::ActorCharacter() : mFormId(0), mFlags(0), mBaseObj(0),
-                                         mScale(1.f), mOwner(0), mGlobal(0), mInitiallyDisabled(false)
-{
-    mEditorId.clear();
-    mFullName.clear();
-
-    mEsp.parent = 0;
-    mEsp.flags = 0;
-}
-
 ESM4::ActorCharacter::~ActorCharacter()
 {
 }

components/esm4/loadachr.hpp

@@ -49,7 +49,7 @@ namespace ESM4
         FormId      mBaseObj;
 
         Placement mPlacement;
-        float    mScale;      // default 1.f
+        float    mScale = 1.0f;
         FormId   mOwner;
         FormId   mGlobal;
 
@@ -57,7 +57,6 @@ namespace ESM4
 
         EnableParent mEsp;
 
-        ActorCharacter();
         virtual ~ActorCharacter();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadacre.cpp

@@ -32,15 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::ActorCreature::ActorCreature() : mFormId(0), mFlags(0), mBaseObj(0), mScale(1.f),
-                                       mOwner(0), mGlobal(0), mFactionRank(0), mInitiallyDisabled(false)
-{
-    mEditorId.clear();
-
-    mEsp.parent = 0;
-    mEsp.flags = 0;
-}
-
 ESM4::ActorCreature::~ActorCreature()
 {
 }

components/esm4/loadacre.hpp

@@ -45,7 +45,7 @@ namespace ESM4
         FormId      mBaseObj;
 
         Placement mPlacement;
-        float    mScale;      // default 1.f
+        float    mScale = 1.0f;
         FormId   mOwner;
         FormId   mGlobal;
         std::uint32_t mFactionRank;
@@ -54,7 +54,6 @@ namespace ESM4
 
         EnableParent mEsp;
 
-        ActorCreature();
         virtual ~ActorCreature();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadacti.cpp

@@ -32,16 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Activator::Activator() : mFormId(0), mFlags(0), mScriptId(0), mLoopingSound(0), mActivationSound(0),
-    mBoundRadius(0.f), mRadioTemplate(0), mRadioStation(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-
-    mActivationPrompt.clear();
-}
-
 ESM4::Activator::~Activator()
 {
 }

components/esm4/loadalch.cpp

@@ -33,19 +33,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Potion::Potion() : mFormId(0), mFlags(0), mPickUpSound(0), mDropSound(0), mScriptId(0), mBoundRadius(0.f)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-    mIcon.clear();
-    mMiniIcon.clear();
-
-    mData.weight = 0.f;
-
-    std::memset(&mEffect, 0, sizeof(ScriptEffect));
-}
-
 ESM4::Potion::~Potion()
 {
 }

components/esm4/loadaloc.cpp

@@ -38,15 +38,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::MediaLocationController::MediaLocationController() : mFormId(0), mFlags(0),
-    mConditionalFaction(0), mLocationDelay(0.f), mRetriggerDelay(0.f), mDayStart(0), mNightStart(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-
-    std::memset(&mMediaFlags, 0, sizeof(MLC_Flags));
-}
-
 ESM4::MediaLocationController::~MediaLocationController()
 {
 }

components/esm4/loadammo.cpp

@@ -31,16 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Ammunition::Ammunition() : mFormId(0), mFlags(0), mPickUpSound(0), mDropSound(0), mBoundRadius(0.f)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-    mText.clear();
-    mIcon.clear();
-    mMiniIcon.clear();
-}
-
 ESM4::Ammunition::~Ammunition()
 {
 }

components/esm4/loadammo.hpp

@@ -71,7 +71,6 @@ namespace ESM4
 
         Data mData;
 
-        Ammunition();
         virtual ~Ammunition();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadanio.cpp

@@ -31,13 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::AnimObject::AnimObject() : mFormId(0), mFlags(0), mBoundRadius(0.f), mIdleAnim(0)
-{
-    mEditorId.clear();
-    mModel.clear();
-    mUnloadEvent.clear();
-}
-
 ESM4::AnimObject::~AnimObject()
 {
 }

components/esm4/loadanio.hpp

@@ -50,7 +50,6 @@ namespace ESM4
         FormId mIdleAnim;         // only in TES4
         std::string mUnloadEvent; // only in TES5
 
-        AnimObject();
         virtual ~AnimObject();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadappa.cpp

@@ -31,20 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Apparatus::Apparatus() : mFormId(0), mFlags(0), mBoundRadius(0.f), mScriptId(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-    mText.clear();
-    mIcon.clear();
-
-    mData.type = 0;
-    mData.value = 0;
-    mData.weight = 0.f;
-    mData.quality = 0.f;
-}
-
 ESM4::Apparatus::~Apparatus()
 {
 }

components/esm4/loadappa.hpp

@@ -62,7 +62,6 @@ namespace ESM4
 
         Data mData;
 
-        Apparatus();
         virtual ~Apparatus();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadarma.cpp

@@ -32,15 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::ArmorAddon::ArmorAddon() : mFormId(0), mFlags(0), mTextureMale(0), mTextureFemale(0),
-                                 mRacePrimary(0)
-{
-    mEditorId.clear();
-
-    mModelMale.clear();
-    mModelFemale.clear();
-}
-
 ESM4::ArmorAddon::~ArmorAddon()
 {
 }

components/esm4/loadarma.hpp

@@ -57,7 +57,6 @@ namespace ESM4
 
         BodyTemplate mBodyTemplate; // TES5
 
-        ArmorAddon();
         virtual ~ArmorAddon();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadarmo.cpp

@@ -32,28 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Armor::Armor() : mFormId(0), mFlags(0), mIsTES4(false), mIsFO3(false), mIsFONV(false),
-                       mPickUpSound(0), mDropSound(0), mBoundRadius(0.f),
-                       mArmorFlags(0), mGeneralFlags(0), mScriptId(0), mEnchantmentPoints(0), mEnchantment(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModelMale.clear();
-    mModelMaleWorld.clear();
-    mModelFemale.clear();
-    mModelFemaleWorld.clear();
-    mText.clear();
-    mIconMale.clear();
-    mMiniIconMale.clear();
-    mIconFemale.clear();
-    mMiniIconFemale.clear();
-
-    mData.armor = 0;
-    mData.value = 0;
-    mData.health = 0;
-    mData.weight = 0.f;
-}
-
 ESM4::Armor::~Armor()
 {
 }

components/esm4/loadarmo.hpp

@@ -183,7 +183,6 @@ namespace ESM4
         std::vector<FormId> mAddOns; // TES5 ARMA
         Data mData;
 
-        Armor();
         virtual ~Armor();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadaspc.cpp

@@ -32,12 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::AcousticSpace::AcousticSpace() : mFormId(0), mFlags(0), mEnvironmentType(0), mSoundRegion(0),
-    mIsInterior(0)
-{
-    mEditorId.clear();
-}
-
 ESM4::AcousticSpace::~AcousticSpace()
 {
 }

components/esm4/loadaspc.hpp

@@ -53,7 +53,6 @@ namespace ESM4
 
         std::uint32_t mIsInterior; // if true only use mAmbientLoopSounds[0]
 
-        AcousticSpace();
         virtual ~AcousticSpace();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadbook.cpp

@@ -31,22 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Book::Book() : mFormId(0), mFlags(0), mBoundRadius(0.f), mScriptId(0),
-                     mEnchantmentPoints(0), mEnchantment(0), mPickUpSound(0), mDropSound(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-    mText.clear();
-    mIcon.clear();
-
-    mData.flags = 0;
-    mData.type = 0;
-    mData.bookSkill = 0;
-    mData.value = 0;
-    mData.weight = 0.f;
-}
-
 ESM4::Book::~Book()
 {
 }

components/esm4/loadbook.hpp

@@ -101,7 +101,6 @@ namespace ESM4
         FormId mPickUpSound;
         FormId mDropSound;
 
-        Book();
         virtual ~Book();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadbptd.cpp

@@ -43,13 +43,6 @@ void ESM4::BodyPartData::BodyPart::clear()
     mGoreEffectsTarget.clear();
 }
 
-ESM4::BodyPartData::BodyPartData() : mFormId(0), mFlags(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-}
-
 ESM4::BodyPartData::~BodyPartData()
 {
 }

components/esm4/loadbptd.hpp

@@ -115,7 +115,6 @@ namespace ESM4
 
         std::vector<BodyPart> mBodyParts;
 
-        BodyPartData();
         virtual ~BodyPartData();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadcell.cpp

@@ -39,28 +39,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Cell::Cell() : mParent(0), mFormId(0), mFlags(0), mCellFlags(0), mX(0), mY(0), mOwner(0),
-                     mGlobal(0), mClimate(0), mWater(0), mWaterHeight(0.f),
-                     mLightingTemplate(0), mLightingTemplateFlags(0), mMusic(0), mAcousticSpace(0),
-                     mMusicType(0), mPreloaded(false)
-{
-    mEditorId.clear();
-    mFullName.clear();
-
-    mLighting.ambient = 0;
-    mLighting.directional = 0;
-    mLighting.fogColor = 0;
-    mLighting.fogNear = 0.f;
-    mLighting.fogFar = 0.f;
-    mLighting.rotationXY = 0;
-    mLighting.rotationZ = 0;
-    mLighting.fogDirFade = 0.f;
-    mLighting.fogClipDist = 0.f;
-    mLighting.fogPower = FLT_MAX; // hack way to detect TES4
-
-    mRegions.clear();
-}
-
 ESM4::Cell::~Cell()
 {
 }

components/esm4/loadcell.hpp

@@ -91,7 +91,6 @@ namespace ESM4
 
         CellGroup *mCellGroup;
 
-        Cell();
         virtual ~Cell();
 
         void init(ESM4::Reader& reader); // common setup for both preload() and load()

components/esm4/loadclas.cpp

@@ -36,14 +36,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Class::Class()
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mDesc.clear();
-    mIcon.clear();
-}
-
 ESM4::Class::~Class()
 {
 }

components/esm4/loadclas.hpp

@@ -53,7 +53,6 @@ namespace ESM4
         std::string mIcon;
         Data mData;
 
-        Class();
         ~Class();
 
         void load(ESM4::Reader& reader);

components/esm4/loadclfm.cpp

@@ -32,17 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Colour::Colour() : mFormId(0), mFlags(0), mPlayable(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-
-    mColour.red = 0;
-    mColour.green = 0;
-    mColour.blue = 0;
-    mColour.custom = 0;
-}
-
 ESM4::Colour::~Colour()
 {
 }

components/esm4/loadclfm.hpp

@@ -57,7 +57,6 @@ namespace ESM4
         ColourRGB mColour;
         std::uint32_t mPlayable;
 
-        Colour();
         virtual ~Colour();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadclot.cpp

@@ -32,22 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Clothing::Clothing() : mFormId(0), mFlags(0), mBoundRadius(0.f), mClothingFlags(0),
-                             mScriptId(0), mEnchantmentPoints(0), mEnchantment(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModelMale.clear();
-    mModelMaleWorld.clear();
-    mModelFemale.clear();
-    mModelFemaleWorld.clear();
-    mIconMale.clear();
-    mIconFemale.clear();
-
-    mData.value = 0;
-    mData.weight = 0.f;
-}
-
 ESM4::Clothing::~Clothing()
 {
 }

components/esm4/loadclot.hpp

@@ -70,7 +70,6 @@ namespace ESM4
 
         Data mData;
 
-        Clothing();
         virtual ~Clothing();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadcont.cpp

@@ -31,14 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Container::Container() : mFormId(0), mFlags(0), mBoundRadius(0.f), mDataFlags(0), mWeight(0.f),
-                               mOpenSound(0), mCloseSound(0), mScriptId(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-}
-
 ESM4::Container::~Container()
 {
 }

components/esm4/loadcont.hpp

@@ -58,7 +58,6 @@ namespace ESM4
 
         std::vector<InventoryItem> mInventory;
 
-        Container();
         virtual ~Container();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadcrea.cpp

@@ -40,28 +40,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Creature::Creature() : mFormId(0), mFlags(0), mDeathItem(0), mScriptId(0), mCombatStyle(0),
-                             mSoundBase(0), mSound(0), mSoundChance(0), mBaseScale(0.f),
-                             mTurningSpeed(0.f), mFootWeight(0.f), mBoundRadius(0.f)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-
-    mBloodSpray.clear();
-    mBloodDecal.clear();
-
-    mAIData.aggression = 0;
-    mAIData.confidence = 0;
-    mAIData.energyLevel = 0;
-    mAIData.responsibility = 0;
-    mAIData.aiFlags = 0;
-    mAIData.trainSkill = 0;
-    mAIData.trainLevel = 0;
-
-    std::memset(&mData, 0, sizeof(Data));
-}
-
 ESM4::Creature::~Creature()
 {
 }

components/esm4/loadcrea.hpp

@@ -138,7 +138,6 @@ namespace ESM4
         FormId mBaseTemplate;           // FO3/FONV
         std::vector<FormId> mBodyParts; // FO3/FONV
 
-        Creature();
         virtual ~Creature();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loaddial.cpp

@@ -33,15 +33,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Dialogue::Dialogue() : mFormId(0), mFlags(0), mDoAllBeforeRepeat(false),
-                             mDialType(0), mDialFlags(0), mPriority(0.f)
-{
-    mEditorId.clear();
-    mTopicName.clear();
-
-    mTextDumb.clear(); // FIXME: temp name
-}
-
 ESM4::Dialogue::~Dialogue()
 {
 }

components/esm4/loaddial.hpp

@@ -57,7 +57,6 @@ namespace ESM4
 
         float mPriority;
 
-        Dialogue();
         virtual ~Dialogue();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loaddobj.cpp

@@ -37,13 +37,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::DefaultObj::DefaultObj() : mFormId(0), mFlags(0)
-{
-    mEditorId.clear();
-
-    std::memset(&mData, 0, sizeof(Defaults));
-}
-
 ESM4::DefaultObj::~DefaultObj()
 {
 }

components/esm4/loaddobj.hpp

@@ -87,7 +87,6 @@ namespace ESM4
 
         Defaults mData;
 
-        DefaultObj();
         virtual ~DefaultObj();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loaddoor.cpp

@@ -31,14 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Door::Door() : mFormId(0), mFlags(0), mBoundRadius(0.f), mDoorFlags(0), mScriptId(0),
-                     mOpenSound(0), mCloseSound(0), mLoopSound(0), mRandomTeleport(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-}
-
 ESM4::Door::~Door()
 {
 }

components/esm4/loaddoor.hpp

@@ -63,7 +63,6 @@ namespace ESM4
         FormId mLoopSound;
         FormId mRandomTeleport;
 
-        Door();
         virtual ~Door();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadeyes.cpp

@@ -31,15 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Eyes::Eyes() : mFormId(0), mFlags(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mIcon.clear();
-
-    mData.flags = 0;
-}
-
 ESM4::Eyes::~Eyes()
 {
 }

components/esm4/loadeyes.hpp

@@ -55,7 +55,6 @@ namespace ESM4
 
         Data mData;
 
-        Eyes();
         virtual ~Eyes();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadflor.cpp

@@ -31,14 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Flora::Flora() : mFormId(0), mFlags(0), mBoundRadius(0.f), mScriptId(0), mIngredient(0),
-                       mSound(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-}
-
 ESM4::Flora::~Flora()
 {
 }

components/esm4/loadflor.hpp

@@ -65,7 +65,6 @@ namespace ESM4
         FormId mSound;
         Production mPercentHarvest;
 
-        Flora();
         virtual ~Flora();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadflst.cpp

@@ -32,11 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::FormIdList::FormIdList() : mFormId(0), mFlags(0)
-{
-    mEditorId.clear();
-}
-
 ESM4::FormIdList::~FormIdList()
 {
 }

components/esm4/loadflst.hpp

@@ -47,7 +47,6 @@ namespace ESM4
 
         std::vector<FormId> mObjects;
 
-        FormIdList();
         virtual ~FormIdList();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadfurn.cpp

@@ -31,14 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Furniture::Furniture() : mFormId(0), mFlags(0), mBoundRadius(0.f), mScriptId(0),
-                               mActiveMarkerFlags(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-}
-
 ESM4::Furniture::~Furniture()
 {
 }

components/esm4/loadfurn.hpp

@@ -51,7 +51,6 @@ namespace ESM4
         FormId mScriptId;
         std::uint32_t mActiveMarkerFlags;
 
-        Furniture();
         virtual ~Furniture();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadglob.cpp

@@ -32,11 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::GlobalVariable::GlobalVariable() : mFormId(0), mFlags(0), mType(0), mValue(0.f)
-{
-    mEditorId.clear();
-}
-
 ESM4::GlobalVariable::~GlobalVariable()
 {
 }

components/esm4/loadglob.hpp

@@ -47,7 +47,6 @@ namespace ESM4
         std::uint8_t mType;
         float mValue;
 
-        GlobalVariable();
         virtual ~GlobalVariable();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadgras.cpp

@@ -31,12 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Grass::Grass() : mFormId(0), mFlags(0), mBoundRadius(0.f)
-{
-    mEditorId.clear();
-    mModel.clear();
-}
-
 ESM4::Grass::~Grass()
 {
 }

components/esm4/loadgras.hpp

@@ -85,7 +85,6 @@ namespace ESM4
 
         Data mData;
 
-        Grass();
         virtual ~Grass();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadhair.cpp

@@ -32,16 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Hair::Hair() : mFormId(0), mFlags(0), mBoundRadius(0.f)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-    mIcon.clear();
-
-    mData.flags = 0;
-}
-
 ESM4::Hair::~Hair()
 {
 }

components/esm4/loadhair.hpp

@@ -58,7 +58,6 @@ namespace ESM4
 
         Data mData;
 
-        Hair();
         virtual ~Hair();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadhdpt.cpp

@@ -32,15 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::HeadPart::HeadPart() : mFormId(0), mFlags(0), mData(0), mAdditionalPart(0), mBaseTexture(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-
-    mTriFile.resize(3);
-}
-
 ESM4::HeadPart::~HeadPart()
 {
 }

components/esm4/loadhdpt.hpp

@@ -28,7 +28,7 @@
 #define ESM4_HDPT_H
 
 #include <cstdint>
-#include <vector>
+#include <array>
 
 #include "formid.hpp"
 
@@ -50,7 +50,7 @@ namespace ESM4
 
         FormId mAdditionalPart;
 
-        std::vector<std::string> mTriFile;
+        std::array<std::string, 3> mTriFile;
         FormId mBaseTexture;
 
         HeadPart();

components/esm4/loadidle.cpp

@@ -31,13 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::IdleAnimation::IdleAnimation() : mFormId(0), mFlags(0), mParent(0), mPrevious(0)
-{
-    mEditorId.clear();
-    mCollision.clear();
-    mEvent.clear();
-}
-
 ESM4::IdleAnimation::~IdleAnimation()
 {
 }

components/esm4/loadidle.hpp

@@ -49,7 +49,6 @@ namespace ESM4
         FormId      mParent;  // IDLE or AACT
         FormId      mPrevious;
 
-        IdleAnimation();
         virtual ~IdleAnimation();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadidlm.cpp

@@ -32,11 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::IdleMarker::IdleMarker() : mFormId(0), mFlags(0), mIdleFlags(0), mIdleCount(0), mIdleTimer(0.f), mIdleAnim(0)
-{
-    mEditorId.clear();
-}
-
 ESM4::IdleMarker::~IdleMarker()
 {
 }

components/esm4/loadidlm.hpp

@@ -50,7 +50,6 @@ namespace ESM4
         float mIdleTimer;
         std::vector<FormId> mIdleAnim;
 
-        IdleMarker();
         virtual ~IdleMarker();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadimod.cpp

@@ -34,11 +34,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::ItemMod::ItemMod() : mFormId(0), mFlags(0)
-{
-    mEditorId.clear();
-}
-
 ESM4::ItemMod::~ItemMod()
 {
 }

components/esm4/loadimod.hpp

@@ -46,7 +46,6 @@ namespace ESM4
 
         std::string mEditorId;
 
-        ItemMod();
         virtual ~ItemMod();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadinfo.cpp

@@ -33,21 +33,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::DialogInfo::DialogInfo() : mFormId(0), mFlags(0), mQuest(0), mSound(0),
-    mDialType(0), mNextSpeaker(0), mInfoFlags(0), mParam3(0)
-{
-    std::memset(&mResponseData, 0, sizeof(TargetResponseData));
-    mResponse.clear();
-    mNotes.clear();
-    mEdits.clear();
-
-    std::memset(&mTargetCondition, 0, sizeof(TargetCondition));
-
-    std::memset(&mScript.scriptHeader, 0, sizeof(ScriptHeader));
-    mScript.scriptSource.clear();
-    mScript.globReference = 0;
-}
-
 ESM4::DialogInfo::~DialogInfo()
 {
 }

components/esm4/loadinfo.hpp

@@ -77,7 +77,6 @@ namespace ESM4
 
         ScriptDefinition mScript; // FIXME: ignoring the second one after the NEXT sub-record
 
-        DialogInfo();
         virtual ~DialogInfo();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadingr.cpp

@@ -32,21 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Ingredient::Ingredient() : mFormId(0), mFlags(0), mBoundRadius(0.f), mScriptId(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-    mIcon.clear();
-
-    mData.value = 0;
-    mData.weight = 0.f;
-    mEnchantment.value = 0;
-    mEnchantment.flags = 0;
-
-    std::memset(&mEffect, 0, sizeof(ScriptEffect));
-}
-
 ESM4::Ingredient::~Ingredient()
 {
 }

components/esm4/loadingr.hpp

@@ -70,7 +70,6 @@ namespace ESM4
 
         Data mData;
 
-        Ingredient();
         virtual ~Ingredient();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadkeym.cpp

@@ -31,18 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Key::Key() : mFormId(0), mFlags(0), mPickUpSound(0), mDropSound(0), mBoundRadius(0.f), mScriptId(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-    mIcon.clear();
-    mMiniIcon.clear();
-
-    mData.value = 0;
-    mData.weight = 0.f;
-}
-
 ESM4::Key::~Key()
 {
 }

components/esm4/loadkeym.hpp

@@ -64,7 +64,6 @@ namespace ESM4
 
         Data mData;
 
-        Key();
         virtual ~Key();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadland.cpp

@@ -38,17 +38,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Land::Land() : mFormId(0), mFlags(0), mLandFlags(0), mDataTypes(0)
-{
-    for (int i = 0; i < 4; ++i)
-    {
-        mTextures[i].base.formId = 0;
-        mTextures[i].base.quadrant = 0;
-        mTextures[i].base.unknown1 = 0;
-        mTextures[i].base.unknown2 = 0;
-    }
-}
-
 ESM4::Land::~Land()
 {
 }

components/esm4/loadland.hpp

@@ -123,7 +123,6 @@ namespace ESM4
         Texture       mTextures[4]; // 0 = bottom left, 1 = bottom right, 2 = top left, 3 = top right
         std::vector<FormId> mIds;   // land texture (LTEX) formids
 
-        Land();
         virtual ~Land();
 
         virtual void load(Reader& reader);

components/esm4/loadlgtm.cpp

@@ -35,22 +35,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::LightingTemplate::LightingTemplate() : mFormId(0), mFlags(0)
-{
-    mEditorId.clear();
-
-    mLighting.ambient = 0;
-    mLighting.directional = 0;
-    mLighting.fogColor = 0;
-    mLighting.fogNear = 0.f;
-    mLighting.fogFar = 0.f;
-    mLighting.rotationXY = 0;
-    mLighting.rotationZ = 0;
-    mLighting.fogDirFade = 0.f;
-    mLighting.fogClipDist = 0.f;
-    mLighting.fogPower = FLT_MAX; // hack way to detect TES4
-}
-
 ESM4::LightingTemplate::~LightingTemplate()
 {
 }

components/esm4/loadlgtm.hpp

@@ -50,7 +50,6 @@ namespace ESM4
 
         Lighting mLighting;
 
-        LightingTemplate();
         virtual ~LightingTemplate();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadligh.cpp

@@ -31,15 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Light::Light() : mFormId(0), mFlags(0), mBoundRadius(0.f), mScriptId(0), mSound(0),
-                       mFade(0.f)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-    mIcon.clear();
-}
-
 ESM4::Light::~Light()
 {
 }

components/esm4/loadligh.hpp

@@ -42,7 +42,7 @@ namespace ESM4
         struct Data
         {
             std::uint32_t time;               // FO/FONV only
-            float         duration;
+            float         duration = -1;
             std::uint32_t radius;
             std::uint32_t colour; // RGBA
             // flags:
@@ -57,18 +57,14 @@ namespace ESM4
             // 0x00000200 = Spot Light
             // 0x00000400 = Spot Shadow
             std::int32_t  flags;
-            float         falloff;
-            float         FOV;
+            float         falloff = 1.f;
+            float         FOV = 90; // FIXME: FOV in degrees or radians?
             float         nearClip;           // TES5 only
             float         frequency;          // TES5 only
             float         intensityAmplitude; // TES5 only
             float         movementAmplitude;  // TES5 only
             std::uint32_t value;   // gold
             float         weight;
-            Data() : duration(-1), radius(0), colour(0), flags(0), falloff(1.f), FOV(90),
-                     nearClip(0.f), frequency(0.f), intensityAmplitude(0.f), movementAmplitude(0.f),
-                     value(0), weight(0.f) // FIXME: FOV in degrees or radians?
-            {}
         };
 
         FormId mFormId;       // from the header
@@ -88,7 +84,6 @@ namespace ESM4
 
         Data mData;
 
-        Light();
         virtual ~Light();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadltex.cpp

@@ -37,14 +37,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::LandTexture::LandTexture() : mFormId(0), mFlags(0), mHavokFriction(0), mHavokRestitution(0),
-                                   mTextureSpecular(0), mGrass(0), mHavokMaterial(0), mTexture(0),
-                                   mMaterial(0)
-{
-    mEditorId.clear();
-    mTextureFile.clear();
-}
-
 ESM4::LandTexture::~LandTexture()
 {
 }

components/esm4/loadltex.hpp

@@ -62,7 +62,6 @@ namespace ESM4
 
         // ----------------------
 
-        LandTexture();
         virtual ~LandTexture();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadlvlc.cpp

@@ -32,12 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::LevelledCreature::LevelledCreature() : mFormId(0), mFlags(0), mScriptId(0), mTemplate(0),
-                                           mChanceNone(0), mLvlCreaFlags(0)
-{
-    mEditorId.clear();
-}
-
 ESM4::LevelledCreature::~LevelledCreature()
 {
 }

components/esm4/loadlvlc.hpp

@@ -58,7 +58,6 @@ namespace ESM4
         bool calcEachItemInCount() const;
         std::int8_t chanceNone() const;
 
-        LevelledCreature();
         virtual ~LevelledCreature();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadlvli.cpp

@@ -32,12 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::LevelledItem::LevelledItem() : mFormId(0), mFlags(0), mChanceNone(0), mHasLvlItemFlags(false),
-    mLvlItemFlags(0), mData(0)
-{
-    mEditorId.clear();
-}
-
 ESM4::LevelledItem::~LevelledItem()
 {
 }

components/esm4/loadlvli.hpp

@@ -54,7 +54,6 @@ namespace ESM4
 
         std::vector<LVLO> mLvlObject;
 
-        LevelledItem();
         virtual ~LevelledItem();
 
         bool calcAllLvlLessThanPlayer() const;

components/esm4/loadlvln.cpp

@@ -32,12 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::LevelledNpc::LevelledNpc() : mFormId(0), mFlags(0), mChanceNone(0), mLvlActorFlags(0), mListCount(0)
-{
-    mEditorId.clear();
-    mModel.clear();
-}
-
 ESM4::LevelledNpc::~LevelledNpc()
 {
 }

components/esm4/loadlvln.hpp

@@ -52,7 +52,6 @@ namespace ESM4
         std::uint8_t mListCount;
         std::vector<LVLO> mLvlObject;
 
-        LevelledNpc();
         virtual ~LevelledNpc();
 
         inline bool calcAllLvlLessThanPlayer() const { return (mLvlActorFlags & 0x01) != 0; }

components/esm4/loadmato.cpp

@@ -31,12 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Material::Material() : mFormId(0), mFlags(0)
-{
-    mEditorId.clear();
-    mModel.clear();
-}
-
 ESM4::Material::~Material()
 {
 }

components/esm4/loadmato.hpp

@@ -45,7 +45,6 @@ namespace ESM4
         std::string mEditorId;
         std::string mModel;
 
-        Material();
         virtual ~Material();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadmisc.cpp

@@ -31,18 +31,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::MiscItem::MiscItem() : mFormId(0), mFlags(0), mPickUpSound(0), mDropSound(0), mBoundRadius(0.f), mScriptId(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-    mIcon.clear();
-    mMiniIcon.clear();
-
-    mData.value = 0;
-    mData.weight = 0.f;
-}
-
 ESM4::MiscItem::~MiscItem()
 {
 }

components/esm4/loadmisc.hpp

@@ -64,7 +64,6 @@ namespace ESM4
 
         Data mData;
 
-        MiscItem();
         virtual ~MiscItem();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadmset.cpp

@@ -32,24 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::MediaSet::MediaSet() : mFormId(0), mFlags(0), mSetType(-1), mEnabled(0),
-    mBoundaryDayOuter(0.f), mBoundaryDayMiddle(0.f), mBoundaryDayInner(0.f),
-    mBoundaryNightOuter(0.f), mBoundaryNightMiddle(0.f), mBoundaryNightInner(0.f),
-    mLevel8(0.f), mLevel9(0.f), mLevel0(0.f), mLevelA(0.f), mLevelB(0.f), mLevelC(0.f),
-    mTime1(0.f), mTime2(0.f), mTime3(0.f), mTime4(0.f),
-    mSoundIntro(0), mSoundOutro(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-
-    mSet2.clear();
-    mSet3.clear();
-    mSet4.clear();
-    mSet5.clear();
-    mSet6.clear();
-    mSet7.clear();
-}
-
 ESM4::MediaSet::~MediaSet()
 {
 }

components/esm4/loadmset.hpp

@@ -51,7 +51,7 @@ namespace ESM4
         //              night outer (NAM5), night middle (NAM6), night inner (NAM7)
         // Dungeon    - intro (HNAM), battle (NAM2), explore (NAM3), suspence (NAM4), outro (INAM)
         // Incidental - daytime (HNAM), nighttime (INAM)
-        std::int32_t mSetType;
+        std::int32_t mSetType = -1;
         // 0x01 day outer,   0x02 day middle,   0x04 day inner
         // 0x08 night outer, 0x10 night middle, 0x20 night inner
         std::uint8_t mEnabled; // for location
@@ -86,7 +86,6 @@ namespace ESM4
         FormId mSoundIntro; // HNAM
         FormId mSoundOutro; // INAM
 
-        MediaSet();
         virtual ~MediaSet();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadmstt.cpp

@@ -32,12 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::MovableStatic::MovableStatic() : mFormId(0), mFlags(0), mData(0), mLoopingSound(0)
-{
-    mEditorId.clear();
-    mModel.clear();
-}
-
 ESM4::MovableStatic::~MovableStatic()
 {
 }

components/esm4/loadmusc.cpp

@@ -36,12 +36,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Music::Music() : mFormId(0), mFlags(0)
-{
-    mEditorId.clear();
-    mMusicFile.clear();
-}
-
 ESM4::Music::~Music()
 {
 }

components/esm4/loadmusc.hpp

@@ -47,7 +47,6 @@ namespace ESM4
         std::string mEditorId;
         std::string mMusicFile;
 
-        Music();
         virtual ~Music();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadnavi.cpp

@@ -38,11 +38,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Navigation::Navigation()
-{
-    mEditorId.clear();
-}
-
 ESM4::Navigation::~Navigation()
 {
 }

components/esm4/loadnavi.hpp

@@ -104,7 +104,6 @@ namespace ESM4
 
         std::map<FormId, std::uint32_t> mPathIndexMap;
 
-        Navigation();
         virtual ~Navigation();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadnavm.cpp

@@ -35,10 +35,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::NavMesh::NavMesh() : mFormId(0), mFlags(0)
-{
-}
-
 ESM4::NavMesh::~NavMesh()
 {
 }

components/esm4/loadnavm.hpp

@@ -98,7 +98,6 @@ namespace ESM4
         FormId mFormId;       // from the header
         std::uint32_t mFlags; // from the header, see enum type RecordFlag for details
 
-        NavMesh();
         virtual ~NavMesh();
 
         virtual void load(ESM4::Reader& reader);

components/esm4/loadnote.cpp

@@ -32,14 +32,6 @@
 #include "reader.hpp"
 //#include "writer.hpp"
 
-ESM4::Note::Note() : mFormId(0), mFlags(0)
-{
-    mEditorId.clear();
-    mFullName.clear();
-    mModel.clear();
-    mIcon.clear();
-}
-
 ESM4::Note::~Note()
 {
 }

components/esm4/loadnote.hpp

@@ -47,7 +47,6 @@ namespace ESM4
         std::string mModel;
         std::string mIcon;
 
-        Note();
         virtual ~Note();
 
         virtual void load(ESM4::Reader& reader);