mirror/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-03-15 13:21:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

CppCheck: Marked out case_range that in RSXThread.cpp. It seems missing its own break;.

Browse Source
This commit is contained in:
luxsie 2015-04-10 19:20:50 +08:00
parent f6392baab3
commit d072eba687
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rpcs3/Emu/RSX/RSXThread.cpp
View File

@ -200,6 +200,7 @@ u32 RSXThread::OutOfArgsCount(const uint x, const u32 cmd, const u32 count, cons
#define case_32(offset, step) \
case_16(offset, step) \
case_16(offset + 16*step, step)
// TODO:: Syphurith: I'm not sure about whether this is correct or missing a break;.
#define case_range(n, offset, step) \
case_##n(offset, step) \
index = (cmd - offset) / step
@ -368,6 +369,7 @@ void RSXThread::DoCmd(const u32 fcmd, const u32 cmd, const u32 args_addr, const
}
// Texture
// TODO:: Syphurith: Ensure it don't need to break;? case 0: A=0; case 1: A=1; would always give you A=1.
case_range(16, NV4097_SET_TEXTURE_FORMAT, 0x20);
case_range(16, NV4097_SET_TEXTURE_OFFSET, 0x20);
case_range(16, NV4097_SET_TEXTURE_FILTER, 0x20);
@ -397,7 +399,8 @@ void RSXThread::DoCmd(const u32 fcmd, const u32 cmd, const u32 args_addr, const
break;
}
// Vertex Texture
// Vertex Texture
// TODO:: Syphurith: Ensure it don't need to break;? Similiar reason..
case_range(4, NV4097_SET_VERTEX_TEXTURE_FORMAT, 0x20);
case_range(4, NV4097_SET_VERTEX_TEXTURE_OFFSET, 0x20);
case_range(4, NV4097_SET_VERTEX_TEXTURE_FILTER, 0x20);