mirror/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-01-30 03:32:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

System.cpp: Do not hold on fs::dir handle

Browse Source
This commit is contained in:
Elad 2024-11-27 21:40:28 +02:00
parent 2b9f076024
commit cf850598eb
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
rpcs3/Emu/System.cpp
View File

@ -4001,14 +4001,20 @@ u32 Emulator::AddGamesFromDir(const std::string& path)
games_added++; games_added++;
} }
fs::dir fs_dir{path}; std::vector<fs::dir_entry> entries;
auto path_it = fs_dir.begin(); for (auto&& dir_entry : fs::dir(path))
{
// Prefetch entries, it is unsafe to keep fs::dir for a long time or for many operations
entries.emplace_back(std::move(dir_entry));
}
auto path_it = entries.begin();
qt_events_aware_op(0, [&]() qt_events_aware_op(0, [&]()
{ {
// search direct subdirectories, that way we can drop one folder containing all games // search direct subdirectories, that way we can drop one folder containing all games
for (; path_it != fs_dir.end(); ++path_it) for (; path_it != entries.end(); ++path_it)
{ {
auto dir_entry = std::move(*path_it); auto dir_entry = std::move(*path_it);