mirror/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2024-11-17 08:11:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix UB in to_u8

Browse Source 
Possible signed shift overflow.
This commit is contained in:
Nekotekina 2019-12-23 22:51:40 +03:00
parent abe2cc196a
commit baf9a20c08
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Utilities/types.h
View File

@ -529,7 +529,7 @@ struct offset32_detail<T3 T4::*>
};
// Helper function, used by ""_u16, ""_u32, ""_u64
constexpr u8 to_u8(char c)
constexpr u32 to_u8(char c)
{
return static_cast<u8>(c);
}
@ -539,7 +539,7 @@ constexpr u16 operator""_u16(const char* s, std::size_t length)
{
return
#if IS_LE_MACHINE == 1
to_u8(s[1]) << 8 | to_u8(s[0]);
static_cast<u16>(to_u8(s[1]) << 8 | to_u8(s[0]));
#endif
}