From 900389d857bc68b2d2c1784e15bb67367aebad17 Mon Sep 17 00:00:00 2001 From: luxsie Date: Fri, 10 Apr 2015 20:13:25 +0800 Subject: [PATCH] CppCheck: Tried to classify and marked some lines that weird. --- rpcs3/Crypto/lz.cpp | 1 + rpcs3/Crypto/sha1.cpp | 1 + rpcs3/Emu/ARMv7/Modules/sceLibc.cpp | 1 + rpcs3/Emu/Cell/SPUThread.h | 1 + rpcs3/Emu/SysCalls/Modules/cellAdec.cpp | 1 + rpcs3/Emu/SysCalls/Modules/cellVdec.cpp | 1 + rpcs3/Emu/SysCalls/lv2/sys_spu.cpp | 2 +- 7 files changed, 7 insertions(+), 1 deletion(-) diff --git a/rpcs3/Crypto/lz.cpp b/rpcs3/Crypto/lz.cpp index 86d82d7161..f28431fc6e 100644 --- a/rpcs3/Crypto/lz.cpp +++ b/rpcs3/Crypto/lz.cpp @@ -140,6 +140,7 @@ int decompress(unsigned char *out, unsigned char *in, unsigned int size) unsigned int range = 0xFFFFFFFF; unsigned int code = (in[1] << 24) | (in[2] << 16) | (in[3] << 8) | in[4]; + // TODO:: Syphurith: There was a check against the unsigned char head. if (head < 0) would always be false.. I don't know are you tried to if (head > 0x80)? if (head < 0) // Check if we have a valid starting byte. { // The dictionary header is invalid, the data is not compressed. diff --git a/rpcs3/Crypto/sha1.cpp b/rpcs3/Crypto/sha1.cpp index 8e6177c0e7..650b1dfa88 100644 --- a/rpcs3/Crypto/sha1.cpp +++ b/rpcs3/Crypto/sha1.cpp @@ -233,6 +233,7 @@ void sha1_update( sha1_context *ctx, const unsigned char *input, size_t ilen ) size_t fill; uint32_t left; + // TODO:: Syphurith: Orz. It is said that size_t is an unsigned type.. if( ilen <= 0 ) return; diff --git a/rpcs3/Emu/ARMv7/Modules/sceLibc.cpp b/rpcs3/Emu/ARMv7/Modules/sceLibc.cpp index 98fab490a0..85dba9cb20 100644 --- a/rpcs3/Emu/ARMv7/Modules/sceLibc.cpp +++ b/rpcs3/Emu/ARMv7/Modules/sceLibc.cpp @@ -28,6 +28,7 @@ std::string armv7_fmt(ARMv7Context& context, vm::psv::ptr fmt, u32 g const auto start = fmt - 1; // read flags + // TODO:: Syphurith: Sorry i can not classify/understand these lines exactly.. const bool plus_sign = *fmt == '+' ? fmt++, true : false; const bool minus_sign = *fmt == '-' ? fmt++, true : false; const bool space_sign = *fmt == ' ' ? fmt++, true : false; diff --git a/rpcs3/Emu/Cell/SPUThread.h b/rpcs3/Emu/Cell/SPUThread.h index bee08966ab..4267ac40e0 100644 --- a/rpcs3/Emu/Cell/SPUThread.h +++ b/rpcs3/Emu/Cell/SPUThread.h @@ -258,6 +258,7 @@ public: sync_var.atomic_op([&out_result, &out_value, &out_count, last_value](sync_var_t& data) { + // TODO:: Syphurith: I don't know what you tried to express, exactly. if ((out_result = data.count != 0)) { out_value = data.value0; diff --git a/rpcs3/Emu/SysCalls/Modules/cellAdec.cpp b/rpcs3/Emu/SysCalls/Modules/cellAdec.cpp index 7c3b60c706..5cad2c2a63 100644 --- a/rpcs3/Emu/SysCalls/Modules/cellAdec.cpp +++ b/rpcs3/Emu/SysCalls/Modules/cellAdec.cpp @@ -196,6 +196,7 @@ next: goto next; } + // TODO:: Syphurith: I don't know whether we should keep this else-if now. Since the if condition is same with this one. else if (adec.reader.size < (u32)buf_size) { buf_size = adec.reader.size; diff --git a/rpcs3/Emu/SysCalls/Modules/cellVdec.cpp b/rpcs3/Emu/SysCalls/Modules/cellVdec.cpp index 7b289e13b0..c03177d2a9 100644 --- a/rpcs3/Emu/SysCalls/Modules/cellVdec.cpp +++ b/rpcs3/Emu/SysCalls/Modules/cellVdec.cpp @@ -168,6 +168,7 @@ next: goto next; } + // TODO:: Syphurith: Orz. The if condition above is same with this one, so this would not be executed. else if (vdec.reader.size < (u32)buf_size) { buf_size = vdec.reader.size; diff --git a/rpcs3/Emu/SysCalls/lv2/sys_spu.cpp b/rpcs3/Emu/SysCalls/lv2/sys_spu.cpp index f4eb597754..780426c603 100644 --- a/rpcs3/Emu/SysCalls/lv2/sys_spu.cpp +++ b/rpcs3/Emu/SysCalls/lv2/sys_spu.cpp @@ -508,7 +508,7 @@ s32 sys_spu_thread_group_terminate(u32 id, s32 value) } } - if (group->state <= SPU_THREAD_GROUP_STATUS_INITIALIZED || group->state == SPU_THREAD_GROUP_STATUS_WAITING || group->state == SPU_THREAD_GROUP_STATUS_WAITING) + if ((group->state <= SPU_THREAD_GROUP_STATUS_INITIALIZED) || (group->state == SPU_THREAD_GROUP_STATUS_WAITING) || (group->state == SPU_THREAD_GROUP_STATUS_WAITING)) { return CELL_EINVAL; }