mirror/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-03-29 22:20:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

PPU Analyzer: Remove ppu_function::name to lower sizeof(ppu_function)

Browse Source
This commit is contained in:
Elad 2025-01-15 19:49:56 +02:00
parent f0fa8e3bc3
commit 857eac3d10
3 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
rpcs3/Emu/Cell/PPUAnalyser.h
View File

@ -14,7 +14,7 @@
#include "PPUOpcodes.h" #include "PPUOpcodes.h"
// PPU Function Attributes // PPU Function Attributes
enum class ppu_attr : u32 enum class ppu_attr : u8
{ {
known_size, known_size,
no_return, no_return,
@ -38,7 +38,6 @@ struct ppu_function
std::map<u32, u32> blocks{}; // Basic blocks: addr -> size std::map<u32, u32> blocks{}; // Basic blocks: addr -> size
std::set<u32> calls{}; // Set of called functions std::set<u32> calls{}; // Set of called functions
std::set<u32> callers{}; std::set<u32> callers{};
mutable std::string name{}; // Function name
struct iterator struct iterator
{ {

5
rpcs3/Emu/Cell/PPUThread.cpp
View File

@ -4908,9 +4908,6 @@ bool ppu_initialize(const ppu_module<lv2_obj>& info, bool check_only, u64 file_s
part.local_bounds.first = std::min<u32>(part.local_bounds.first, func.addr); part.local_bounds.first = std::min<u32>(part.local_bounds.first, func.addr);
part.local_bounds.second = std::max<u32>(part.local_bounds.second, func.addr + func.size); part.local_bounds.second = std::max<u32>(part.local_bounds.second, func.addr + func.size);
// Fixup some information
func.name = fmt::format("__0x%x", func.addr - reloc);
bsize += func.size; bsize += func.size;
fpos++; fpos++;
@ -5473,7 +5470,7 @@ static void ppu_initialize2(jit_compiler& jit, const ppu_module<lv2_obj>& module
{ {
if (func.size) if (func.size)
{ {
const auto f = cast<Function>(_module->getOrInsertFunction(func.name, _func).getCallee()); const auto f = cast<Function>(_module->getOrInsertFunction(fmt::format("__0x%x", func.addr - reloc), _func).getCallee());
f->setCallingConv(CallingConv::GHC); f->setCallingConv(CallingConv::GHC);
f->addParamAttr(1, llvm::Attribute::NoAlias); f->addParamAttr(1, llvm::Attribute::NoAlias);
f->addFnAttr(Attribute::NoUnwind); f->addFnAttr(Attribute::NoUnwind);

12
rpcs3/Emu/Cell/PPUTranslator.cpp
View File

@ -185,7 +185,12 @@ bool ppu_test_address_may_be_mmio(std::span<const be_t<u32>> insts);
Function* PPUTranslator::Translate(const ppu_function& info) Function* PPUTranslator::Translate(const ppu_function& info)
{ {
m_function = m_module->getFunction(info.name); // Instruction address is (m_addr + base)
const u64 base = m_reloc ? m_reloc->addr : 0;
m_addr = info.addr - base;
m_attr = m_info.attr + info.attr;
m_function = m_module->getFunction(fmt::format("__0x%x", m_addr));
std::fill(std::begin(m_globals), std::end(m_globals), nullptr); std::fill(std::begin(m_globals), std::end(m_globals), nullptr);
std::fill(std::begin(m_locals), std::end(m_locals), nullptr); std::fill(std::begin(m_locals), std::end(m_locals), nullptr);
@ -193,11 +198,6 @@ Function* PPUTranslator::Translate(const ppu_function& info)
IRBuilder<> irb(BasicBlock::Create(m_context, "__entry", m_function)); IRBuilder<> irb(BasicBlock::Create(m_context, "__entry", m_function));
m_ir = &irb; m_ir = &irb;
// Instruction address is (m_addr + base)
const u64 base = m_reloc ? m_reloc->addr : 0;
m_addr = info.addr - base;
m_attr = m_info.attr + info.attr;
// Don't emit check in small blocks without terminator // Don't emit check in small blocks without terminator
bool need_check = info.size >= 16; bool need_check = info.size >= 16;