mirror/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-01-30 12:32:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

rsx: Apply Clang-Tidy fix "readability-inconsistent-declaration-parameter-name"

Browse Source
This commit is contained in:
scribam 2019-06-08 08:22:09 +02:00 committed by kd-11
parent c9b0a4afd0
commit 801fa0113f
9 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
rpcs3/Emu/RSX/CgBinaryVertexProgram.cpp
View File

@ -48,15 +48,15 @@ std::string CgBinaryDisasm::GetScaMaskDisasm()
return GetMaskDisasm(true);
}
std::string CgBinaryDisasm::GetDSTDisasm(bool isSca)
std::string CgBinaryDisasm::GetDSTDisasm(bool is_sca)
{
std::string ret;
std::string mask = GetMaskDisasm(isSca);
std::string mask = GetMaskDisasm(is_sca);
switch ((isSca && d3.sca_dst_tmp != 0x3f) ? 0x1f : d3.dst)
switch ((is_sca && d3.sca_dst_tmp != 0x3f) ? 0x1f : d3.dst)
{
case 0x1f:
ret += (isSca ? fmt::format("R%d", d3.sca_dst_tmp) : fmt::format("R%d", d0.dst_tmp)) + mask;
ret += (is_sca ? fmt::format("R%d", d3.sca_dst_tmp) : fmt::format("R%d", d0.dst_tmp)) + mask;
break;
default:

12
rpcs3/Emu/RSX/Common/VertexProgramDecompiler.cpp
View File

@ -37,15 +37,15 @@ std::string VertexProgramDecompiler::GetScaMask()
return GetMask(true);
}
std::string VertexProgramDecompiler::GetDST(bool isSca)
std::string VertexProgramDecompiler::GetDST(bool is_sca)
{
std::string ret;
const std::string mask = GetMask(isSca);
const std::string mask = GetMask(is_sca);
// ARL writes to special integer registers
const bool is_address_reg = !isSca && (d1.vec_opcode == RSX_VEC_OPCODE_ARL);
const auto tmp_index = isSca ? d3.sca_dst_tmp : d0.dst_tmp;
const bool is_result = isSca ? (tmp_index == 0x3f) : d0.vec_result;
const bool is_address_reg = !is_sca && (d1.vec_opcode == RSX_VEC_OPCODE_ARL);
const auto tmp_index = is_sca ? d3.sca_dst_tmp : d0.dst_tmp;
const bool is_result = is_sca ? (tmp_index == 0x3f) : d0.vec_result;
if (is_result)
{
@ -76,7 +76,7 @@ std::string VertexProgramDecompiler::GetDST(bool isSca)
if (!ret.empty())
{
// Double assignment. Only possible for vector ops
verify(HERE), !isSca;
verify(HERE), !is_sca;
ret += " = ";
}

2
rpcs3/Emu/RSX/GL/GLGSRender.h
View File

@ -392,7 +392,7 @@ protected:
void on_init_thread() override;
void on_exit() override;
bool do_method(u32 id, u32 arg) override;
bool do_method(u32 cmd, u32 arg) override;
void flip(int buffer, bool emu_flip = false) override;
void do_local_task(rsx::FIFO_state state) override;

2
rpcs3/Emu/RSX/GL/GLTexture.h
View File

@ -14,7 +14,7 @@ namespace rsx
namespace gl
{
GLenum get_target(rsx::texture_dimension_extended type);
GLenum get_sized_internal_format(u32 gcm_format);
GLenum get_sized_internal_format(u32 texture_format);
std::tuple<GLenum, GLenum> get_format_type(u32 texture_format);
std::tuple<GLenum, GLenum, bool> get_format_type(texture::internal_format format);
GLenum wrap_mode(rsx::texture_wrap_mode wrap);

6
rpcs3/Emu/RSX/Overlays/overlays.h
View File

@ -19,7 +19,7 @@
// Utils
std::string utf8_to_ascii8(const std::string& utf8_string);
std::string utf16_to_ascii8(const std::u16string& utf16_string);
std::u16string ascii8_to_utf16(const std::string& utf8_string);
std::u16string ascii8_to_utf16(const std::string& ascii_string);
extern u64 get_system_time();
// Definition of user interface implementations
@ -367,7 +367,7 @@ namespace rsx
void init();
void set_detail_level(detail_level level);
void set_position(screen_quadrant pos);
void set_position(screen_quadrant quadrant);
void set_update_interval(u32 update_interval);
void set_font(std::string font);
void set_font_size(u32 font_size);
@ -464,7 +464,7 @@ namespace rsx
virtual ~osk_dialog() {}
void Create(const std::string& title, const std::u16string& message, char16_t* init_text, u32 charlimit, u32 options) override = 0;
void Close(bool accepted) override;
void Close(bool ok) override;
void initialize_layout(const std::vector<grid_entry_ctor>& layout, const std::string& title, const std::string& initial_text);

4
rpcs3/Emu/RSX/RSXThread.h
View File

@ -397,8 +397,8 @@ namespace rsx
ZCULL_control() {}
~ZCULL_control() {}
void set_enabled(class ::rsx::thread* ptimer, bool enabled);
void set_active(class ::rsx::thread* ptimer, bool active);
void set_enabled(class ::rsx::thread* ptimer, bool state);
void set_active(class ::rsx::thread* ptimer, bool state);
void write(vm::addr_t sink, u32 timestamp, u32 type, u32 value);

2
rpcs3/Emu/RSX/VK/VKFragmentProgram.h
View File

@ -55,7 +55,7 @@ public:
std::array<u32, 4> output_color_masks{ {} };
std::vector<vk::glsl::program_input> uniforms;
void SetInputs(std::vector<vk::glsl::program_input>& uniforms);
void SetInputs(std::vector<vk::glsl::program_input>& inputs);
/**
* Decompile a fragment shader located in the PS3's Memory. This function operates synchronously.
* @param prog RSXShaderProgram specifying the location and size of the shader in memory

4
rpcs3/Emu/RSX/VK/VKGSRender.h
View File

@ -512,7 +512,7 @@ private:
bool load_program();
void load_program_env();
void update_vertex_env(const vk::vertex_upload_info& upload_info);
void update_vertex_env(const vk::vertex_upload_info& vertex_info);
public:
void init_buffers(rsx::framebuffer_creation_context context, bool skip_reading = false);
@ -537,7 +537,7 @@ protected:
void on_init_thread() override;
void on_exit() override;
bool do_method(u32 id, u32 arg) override;
bool do_method(u32 cmd, u32 arg) override;
void flip(int buffer, bool emu_flip = false) override;
void do_local_task(rsx::FIFO_state state) override;

2
rpcs3/Emu/RSX/rsx_utils.h
View File

@ -395,7 +395,7 @@ namespace rsx
}
}
void scale_image_nearest(void* dst, const void* src, u16 src_width, u16 src_height, u16 dst_pitch, u16 src_pitch, u8 pixel_size, u8 samples_u, u8 samples_v, bool swap_bytes = false);
void scale_image_nearest(void* dst, const void* src, u16 src_width, u16 src_height, u16 dst_pitch, u16 src_pitch, u8 element_size, u8 samples_u, u8 samples_v, bool swap_bytes = false);
void convert_scale_image(u8 *dst, AVPixelFormat dst_format, int dst_width, int dst_height, int dst_pitch,
const u8 *src, AVPixelFormat src_format, int src_width, int src_height, int src_pitch, int src_slice_h, bool bilinear);