From 7a9561b966f41c6777d99eca6b18edce9b6f3b46 Mon Sep 17 00:00:00 2001 From: Nekotekina Date: Sun, 18 Apr 2021 13:12:29 +0300 Subject: [PATCH] vm_native: document some unmap_critical behaviour (posix) --- rpcs3/Emu/Memory/vm.cpp | 4 ++++ rpcs3/util/vm_native.cpp | 1 + 2 files changed, 5 insertions(+) diff --git a/rpcs3/Emu/Memory/vm.cpp b/rpcs3/Emu/Memory/vm.cpp index 1ba36d53c6..b08038e8d7 100644 --- a/rpcs3/Emu/Memory/vm.cpp +++ b/rpcs3/Emu/Memory/vm.cpp @@ -923,7 +923,9 @@ namespace vm else { shm->unmap_critical(g_base_addr + addr); +#ifdef _WIN32 shm->unmap_critical(g_sudo_addr + addr); +#endif } if (is_exec) @@ -1148,7 +1150,9 @@ namespace vm if (m_common) { m_common->unmap_critical(vm::base(addr)); +#ifdef _WIN32 m_common->unmap_critical(vm::get_super_ptr(addr)); +#endif } } } diff --git a/rpcs3/util/vm_native.cpp b/rpcs3/util/vm_native.cpp index f23064328f..7fdfd27e38 100644 --- a/rpcs3/util/vm_native.cpp +++ b/rpcs3/util/vm_native.cpp @@ -511,6 +511,7 @@ namespace utils return; } #else + // This method is faster but leaves mapped remnants of the shm (until overwritten) ensure(::mprotect(target, m_size, PROT_NONE) != -1); #endif }