From a62552b0861771a49b2bd99f4d3a8af8ba95797d Mon Sep 17 00:00:00 2001 From: Anthony Miyaguchi Date: Sun, 30 Mar 2014 15:58:51 -0700 Subject: [PATCH 1/4] Organized the cellGcmSys_init() functions in a more sane manner. --- rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp | 152 ++++++++++++++++------ 1 file changed, 112 insertions(+), 40 deletions(-) diff --git a/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp b/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp index d90e4a3705..bb6620cd71 100644 --- a/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp +++ b/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp @@ -815,53 +815,98 @@ int32_t cellGcmUnreserveIoMapSize(u32 size) void cellGcmSys_init() { - cellGcmSys.AddFunc(0x055bd74d, cellGcmGetTiledPitchSize); - cellGcmSys.AddFunc(0x06edea9e, cellGcmSetUserHandler); - cellGcmSys.AddFunc(0x15bae46b, cellGcmInit); - cellGcmSys.AddFunc(0x21397818, cellGcmSetFlipCommand); - cellGcmSys.AddFunc(0x3a33c1fd, cellGcmFunc15); - cellGcmSys.AddFunc(0x4ae8d215, cellGcmSetFlipMode); - cellGcmSys.AddFunc(0x5e2ee0f0, cellGcmGetDefaultCommandWordSize); - cellGcmSys.AddFunc(0x72a577ce, cellGcmGetFlipStatus); - cellGcmSys.AddFunc(0x8cdf8c70, cellGcmGetDefaultSegmentWordSize); - cellGcmSys.AddFunc(0x9ba451e4, cellGcmSetDefaultFifoSize); - cellGcmSys.AddFunc(0xa53d12ae, cellGcmSetDisplayBuffer); - cellGcmSys.AddFunc(0xa547adde, cellGcmGetControlRegister); - cellGcmSys.AddFunc(0xb2e761d4, cellGcmResetFlipStatus); - cellGcmSys.AddFunc(0xd8f88e1a, cellGcmSetFlipCommandWithWaitLabel); - cellGcmSys.AddFunc(0xe315a0b2, cellGcmGetConfiguration); - cellGcmSys.AddFunc(0x9dc04436, cellGcmBindZcull); - cellGcmSys.AddFunc(0xd34a420d, cellGcmSetZcull); - cellGcmSys.AddFunc(0xd9a0a879, cellGcmGetZcullInfo); + //------------------------------------------------------------------------ + // Generating Render Commands + //------------------------------------------------------------------------ + + // TODO + + //------------------------------------------------------------------------ + // Data Retrieval + //------------------------------------------------------------------------ + // cellGcmGetCurrentField + cellGcmSys.AddFunc(0xf80196c1, cellGcmGetLabelAddress); + // cellGcmGetNotifyDataAddress + // cellGcmGetReport + // cellGcmGetReportDataAddress + cellGcmSys.AddFunc(0x8572bce2, cellGcmGetReportDataAddressLocation); + // cellGcmGetReportDataLocation cellGcmSys.AddFunc(0x5a41c10f, cellGcmGetTimeStamp); + // cellGcmGetTimeStampLocation + + //------------------------------------------------------------------------ + // Data Transfer and Format Conversion + //------------------------------------------------------------------------ + + // TODO + + //------------------------------------------------------------------------ + // Command Buffer Control + //------------------------------------------------------------------------ + // cellGcmCallbackForSnc + // cellGcmFinish + // cellGcmFlush + cellGcmSys.AddFunc(0xa547adde, cellGcmGetControlRegister); + cellGcmSys.AddFunc(0x5e2ee0f0, cellGcmGetDefaultCommandWordSize); + cellGcmSys.AddFunc(0x8cdf8c70, cellGcmGetDefaultSegmentWordSize); + cellGcmSys.AddFunc(0xcaabd992, cellGcmInitDefaultFifoMode); + // cellGcmReserveMethodSize + // cellGcmResetDefaultCommandBuffer + // cellGcmSetCallCommand + cellGcmSys.AddFunc(0x9ba451e4, cellGcmSetDefaultFifoSize); + // cellGcmSetJumpCommand + // cellGcmSetNopCommand + // cellGcmSetReturnCommand + // cellGcmSetSkipNop + // cellGcmSetupContextData + // cellGcmSetUserCommand + + //------------------------------------------------------------------------ + // Hardware Resource Management + //------------------------------------------------------------------------ + cellGcmSys.AddFunc(0x4524cccd, cellGcmBindTile); + cellGcmSys.AddFunc(0x9dc04436, cellGcmBindZcull); + // cellGcmDumpGraphicsError + cellGcmSys.AddFunc(0xe315a0b2, cellGcmGetConfiguration); + // cellGcmGetDisplayBufferByFlipIndex + cellGcmSys.AddFunc(0x72a577ce, cellGcmGetFlipStatus); + // cellGcmgetLastFlipTime + // cellGcmGetLastSecondVTime + cellGcmSys.AddFunc(0x055bd74d, cellGcmGetTiledPitchSize); + // cellGcmGetVBlankCount + cellGcmSys.AddFunc(0x15bae46b, cellGcmInit); + // cellGcmInitSystemMode + cellGcmSys.AddFunc(0xb2e761d4, cellGcmResetFlipStatus); + cellGcmSys.AddFunc(0x51c9d62b, cellGcmSetDebugOutputLevel); + cellGcmSys.AddFunc(0xa53d12ae, cellGcmSetDisplayBuffer); + cellGcmSys.AddFunc(0xdc09357e, cellGcmSetFlip); + cellGcmSys.AddFunc(0xa41ef7e8, cellGcmSetFlipHandler); + // cellGcmSetFlipImmediate + cellGcmSys.AddFunc(0x4ae8d215, cellGcmSetFlipMode); + cellGcmSys.AddFunc(0xa47c09ff, cellGcmSetFlipStatus); + // cellGcmSetFlipWithWaitLabel + // cellGcmSetGraphicsHandler + cellGcmSys.AddFunc(0x0b4b62d5, cellGcmSetPrepareFlip); + //cellGcmSetQueueHandler + cellGcmSys.AddFunc(0x4d7ce993, cellGcmSetSecondVFrequency); + // cellGcmSetSecondVHandler + cellGcmSys.AddFunc(0xbd100dbc, cellGcmSetTileInfo); + // cellGcmSetUserHandler TODO: Function exists + // cellGcmSetVBlankFrequency + cellGcmSys.AddFunc(0xa91b0402, cellGcmSetVBlankHandler); + cellGcmSys.AddFunc(0x983fb9aa, cellGcmSetWaitFlip); + cellGcmSys.AddFunc(0xd34a420d, cellGcmSetZcull); + // cellGcmSortRemapEaIoAddress cellGcmSys.AddFunc(0xd9b7653e, cellGcmUnbindTile); cellGcmSys.AddFunc(0xa75640e8, cellGcmUnbindZcull); - cellGcmSys.AddFunc(0xa41ef7e8, cellGcmSetFlipHandler); - cellGcmSys.AddFunc(0xf80196c1, cellGcmGetLabelAddress); - cellGcmSys.AddFunc(0x107bf3a1, cellGcmInitCursor); - cellGcmSys.AddFunc(0x1a0de550, cellGcmSetCursorPosition); - cellGcmSys.AddFunc(0x69c6cc82, cellGcmSetCursorDisable); - cellGcmSys.AddFunc(0xa91b0402, cellGcmSetVBlankHandler); - cellGcmSys.AddFunc(0xbd2fa0a7, cellGcmUpdateCursor); - cellGcmSys.AddFunc(0xc47d0812, cellGcmSetCursorEnable); - cellGcmSys.AddFunc(0xf9bfdc72, cellGcmSetCursorImageOffset); + cellGcmSys.AddFunc(0x657571f7, cellGcmGetTileInfo); + cellGcmSys.AddFunc(0xd9a0a879, cellGcmGetZcullInfo); cellGcmSys.AddFunc(0x0e6b0dae, cellGcmGetDisplayInfo); cellGcmSys.AddFunc(0x93806525, cellGcmGetCurrentDisplayBufferId); - cellGcmSys.AddFunc(0xbc982946, cellGcmSetDefaultCommandBuffer); - cellGcmSys.AddFunc(0xa47c09ff, cellGcmSetFlipStatus); - cellGcmSys.AddFunc(0xd0b1d189, cellGcmSetTile); - cellGcmSys.AddFunc(0xbd100dbc, cellGcmSetTileInfo); - cellGcmSys.AddFunc(0x4524cccd, cellGcmBindTile); - cellGcmSys.AddFunc(0x0b4b62d5, cellGcmSetPrepareFlip); - cellGcmSys.AddFunc(0x657571f7, cellGcmGetTileInfo); - cellGcmSys.AddFunc(0xcaabd992, cellGcmInitDefaultFifoMode); - cellGcmSys.AddFunc(0x8572bce2, cellGcmGetReportDataAddressLocation); - cellGcmSys.AddFunc(0x51c9d62b, cellGcmSetDebugOutputLevel); - cellGcmSys.AddFunc(0x4d7ce993, cellGcmSetSecondVFrequency); - cellGcmSys.AddFunc(0xdc09357e, cellGcmSetFlip); - cellGcmSys.AddFunc(0x983fb9aa, cellGcmSetWaitFlip); + //------------------------------------------------------------------------ //Memory Mapping + //------------------------------------------------------------------------ cellGcmSys.AddFunc(0x21ac3697, cellGcmAddressToOffset); cellGcmSys.AddFunc(0xfb81c03e, cellGcmGetMaxIoMapSize); cellGcmSys.AddFunc(0x2922aed0, cellGcmGetOffsetTable); @@ -874,6 +919,33 @@ void cellGcmSys_init() cellGcmSys.AddFunc(0xefd00f54, cellGcmUnmapEaIoAddress); cellGcmSys.AddFunc(0xdb23e867, cellGcmUnmapIoAddress); cellGcmSys.AddFunc(0x3b9bd5bd, cellGcmUnreserveIoMapSize); + + //------------------------------------------------------------------------ + // Cursor + //------------------------------------------------------------------------ + cellGcmSys.AddFunc(0x107bf3a1, cellGcmInitCursor); + cellGcmSys.AddFunc(0xc47d0812, cellGcmSetCursorEnable); + cellGcmSys.AddFunc(0x69c6cc82, cellGcmSetCursorDisable); + cellGcmSys.AddFunc(0xf9bfdc72, cellGcmSetCursorImageOffset); + cellGcmSys.AddFunc(0x1a0de550, cellGcmSetCursorPosition); + cellGcmSys.AddFunc(0xbd2fa0a7, cellGcmUpdateCursor); + + //------------------------------------------------------------------------ + // Functions for Maintaining Compatibility + //------------------------------------------------------------------------ + // cellGcmGetCurrentBuffer + // cellGcmSetCurrentBuffer + cellGcmSys.AddFunc(0xbc982946, cellGcmSetDefaultCommandBuffer); + // cellGcmSetDefaultCommandBufferAndSegmentWordSize + // cellGcmSetUserCallback + + //------------------------------------------------------------------------ + // Other + //------------------------------------------------------------------------ + cellGcmSys.AddFunc(0x21397818, cellGcmSetFlipCommand); + cellGcmSys.AddFunc(0x3a33c1fd, cellGcmFunc15); + cellGcmSys.AddFunc(0xd8f88e1a, cellGcmSetFlipCommandWithWaitLabel); + cellGcmSys.AddFunc(0xd0b1d189, cellGcmSetTile); } void cellGcmSys_Load() From eab81deb2791837e04d4a002198e818bdea9783b Mon Sep 17 00:00:00 2001 From: Anthony Miyaguchi Date: Sun, 30 Mar 2014 17:02:27 -0700 Subject: [PATCH 2/4] Reordered functions for organization. --- rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp | 1013 +++++++++++---------- 1 file changed, 519 insertions(+), 494 deletions(-) diff --git a/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp b/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp index bb6620cd71..b357796b4c 100644 --- a/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp +++ b/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp @@ -44,7 +44,7 @@ int32_t cellGcmUnmapEaIoAddress(u64 ea); int32_t cellGcmUnmapIoAddress(u64 io); int32_t cellGcmUnreserveIoMapSize(u32 size); -//------------------------------------------------------------ +//---------------------------------------------------------------------------- CellGcmConfig current_config; CellGcmContextData current_context; @@ -53,6 +53,113 @@ gcmInfo gcm_info; u32 map_offset_addr = 0; u32 map_offset_pos = 0; +//---------------------------------------------------------------------------- +// Data Retrieval +//---------------------------------------------------------------------------- + +u32 cellGcmGetLabelAddress(u8 index) +{ + cellGcmSys.Log("cellGcmGetLabelAddress(index=%d)", index); + return Memory.RSXCMDMem.GetStartAddr() + 0x10 * index; +} + +u32 cellGcmGetReportDataAddressLocation(u8 location, u32 index) +{ + ConLog.Warning("cellGcmGetReportDataAddressLocation(location=%d, index=%d)", location, index); + return Emu.GetGSManager().GetRender().m_report_main_addr; +} + +u64 cellGcmGetTimeStamp(u32 index) +{ + cellGcmSys.Log("cellGcmGetTimeStamp(index=%d)", index); + return Memory.Read64(Memory.RSXFBMem.GetStartAddr() + index * 0x10); +} + +//---------------------------------------------------------------------------- +// Command Buffer Control +//---------------------------------------------------------------------------- + +u32 cellGcmGetControlRegister() +{ + cellGcmSys.Log("cellGcmGetControlRegister()"); + + return gcm_info.control_addr; +} + +u32 cellGcmGetDefaultCommandWordSize() +{ + cellGcmSys.Warning("cellGcmGetDefaultCommandWordSize()"); + return 0x400; +} + +u32 cellGcmGetDefaultSegmentWordSize() +{ + cellGcmSys.Warning("cellGcmGetDefaultSegmentWordSize()"); + return 0x100; +} + +int cellGcmInitDefaultFifoMode(int mode) +{ + cellGcmSys.Warning("cellGcmInitDefaultFifoMode(mode=%d)", mode); + return CELL_OK; +} + +int cellGcmSetDefaultFifoSize(u32 bufferSize, u32 segmentSize) +{ + cellGcmSys.Warning("cellGcmSetDefaultFifoSize(bufferSize=0x%x, segmentSize=0x%x)", bufferSize, segmentSize); + return CELL_OK; +} + +//---------------------------------------------------------------------------- +// Hardware Resource Management +//---------------------------------------------------------------------------- + +int cellGcmBindTile(u8 index) +{ + cellGcmSys.Warning("cellGcmBindTile(index=%d)", index); + + if (index >= RSXThread::m_tiles_count) + { + return CELL_GCM_ERROR_INVALID_VALUE; + } + + auto& tile = Emu.GetGSManager().GetRender().m_tiles[index]; + tile.m_binded = true; + + return CELL_OK; +} + +int cellGcmBindZcull(u8 index) +{ + cellGcmSys.Warning("TODO: cellGcmBindZcull(index=%d)", index); + + return CELL_OK; +} + +int cellGcmGetConfiguration(mem_ptr_t config) +{ + cellGcmSys.Log("cellGcmGetConfiguration(config_addr=0x%x)", config.GetAddr()); + + if (!config.IsGood()) return CELL_EFAULT; + + *config = current_config; + + return CELL_OK; +} + +int cellGcmGetFlipStatus() +{ + return Emu.GetGSManager().GetRender().m_flip_status; +} + +u32 cellGcmGetTiledPitchSize(u32 size) +{ + //TODO + cellGcmSys.Warning("cellGcmGetTiledPitchSize(size=%d)", size); + + return size; +} + int cellGcmInit(u32 context_addr, u32 cmdSize, u32 ioSize, u32 ioAddress) { cellGcmSys.Warning("cellGcmInit(context_addr=0x%x,cmdSize=0x%x,ioSize=0x%x,ioAddress=0x%x)", context_addr, cmdSize, ioSize, ioAddress); @@ -119,13 +226,27 @@ int cellGcmInit(u32 context_addr, u32 cmdSize, u32 ioSize, u32 ioAddress) return CELL_OK; } -int cellGcmGetConfiguration(mem_ptr_t config) +int cellGcmResetFlipStatus() { - cellGcmSys.Log("cellGcmGetConfiguration(config_addr=0x%x)", config.GetAddr()); + Emu.GetGSManager().GetRender().m_flip_status = 1; - if(!config.IsGood()) return CELL_EFAULT; + return CELL_OK; +} - *config = current_config; +int cellGcmSetDebugOutputLevel(int level) +{ + cellGcmSys.Warning("cellGcmSetDebugOutputLevel(level=%d)", level); + + switch (level) + { + case CELL_GCM_DEBUG_LEVEL0: + case CELL_GCM_DEBUG_LEVEL1: + case CELL_GCM_DEBUG_LEVEL2: + Emu.GetGSManager().GetRender().m_debug_level = level; + break; + + default: return CELL_EINVAL; + } return CELL_OK; } @@ -151,17 +272,50 @@ int cellGcmSetDisplayBuffer(u32 id, u32 offset, u32 pitch, u32 width, u32 height return CELL_OK; } -u32 cellGcmGetLabelAddress(u8 index) +int cellGcmSetFlip(mem_ptr_t ctxt, u32 id) { - cellGcmSys.Log("cellGcmGetLabelAddress(index=%d)", index); - return Memory.RSXCMDMem.GetStartAddr() + 0x10 * index; + cellGcmSys.Log("cellGcmSetFlip(ctx=0x%x, id=0x%x)", ctxt.GetAddr(), id); + + int res = cellGcmSetPrepareFlip(ctxt, id); + return res < 0 ? CELL_GCM_ERROR_FAILURE : CELL_OK; } -u32 cellGcmGetControlRegister() +int cellGcmSetFlipHandler(u32 handler_addr) { - cellGcmSys.Log("cellGcmGetControlRegister()"); + cellGcmSys.Warning("cellGcmSetFlipHandler(handler_addr=%d)", handler_addr); + if (handler_addr != 0 && !Memory.IsGoodAddr(handler_addr)) + { + return CELL_EFAULT; + } - return gcm_info.control_addr; + Emu.GetGSManager().GetRender().m_flip_handler.SetAddr(handler_addr); + return CELL_OK; +} + +int cellGcmSetFlipMode(u32 mode) +{ + cellGcmSys.Warning("cellGcmSetFlipMode(mode=%d)", mode); + + switch (mode) + { + case CELL_GCM_DISPLAY_HSYNC: + case CELL_GCM_DISPLAY_VSYNC: + case CELL_GCM_DISPLAY_HSYNC_WITH_NOISE: + Emu.GetGSManager().GetRender().m_flip_mode = mode; + break; + + default: + return CELL_EINVAL; + } + + return CELL_OK; +} + +void cellGcmSetFlipStatus() +{ + cellGcmSys.Warning("cellGcmSetFlipStatus()"); + + Emu.GetGSManager().GetRender().m_flip_status = 0; } int cellGcmSetPrepareFlip(mem_ptr_t ctxt, u32 id) @@ -198,9 +352,80 @@ int cellGcmSetPrepareFlip(mem_ptr_t ctxt, u32 id) return id; } -int cellGcmSetFlipCommand(u32 ctx, u32 id) +int cellGcmSetSecondVFrequency(u32 freq) { - return cellGcmSetPrepareFlip(ctx, id); + cellGcmSys.Warning("cellGcmSetSecondVFrequency(level=%d)", freq); + + switch (freq) + { + case CELL_GCM_DISPLAY_FREQUENCY_59_94HZ: + case CELL_GCM_DISPLAY_FREQUENCY_SCANOUT: + case CELL_GCM_DISPLAY_FREQUENCY_DISABLE: + Emu.GetGSManager().GetRender().m_frequency_mode = freq; + break; + + default: return CELL_EINVAL; + } + + return CELL_OK; +} + +int cellGcmSetTileInfo(u8 index, u8 location, u32 offset, u32 size, u32 pitch, u8 comp, u16 base, u8 bank) +{ + cellGcmSys.Warning("cellGcmSetTileInfo(index=%d, location=%d, offset=%d, size=%d, pitch=%d, comp=%d, base=%d, bank=%d)", + index, location, offset, size, pitch, comp, base, bank); + + if (index >= RSXThread::m_tiles_count || base >= 800 || bank >= 4) + { + return CELL_GCM_ERROR_INVALID_VALUE; + } + + if (offset & 0xffff || size & 0xffff || pitch & 0xf) + { + return CELL_GCM_ERROR_INVALID_ALIGNMENT; + } + + if (location >= 2 || (comp != 0 && (comp < 7 || comp > 12))) + { + return CELL_GCM_ERROR_INVALID_ENUM; + } + + if (comp) + { + cellGcmSys.Error("cellGcmSetTileInfo: bad comp! (%d)", comp); + } + + auto& tile = Emu.GetGSManager().GetRender().m_tiles[index]; + tile.m_location = location; + tile.m_offset = offset; + tile.m_size = size; + tile.m_pitch = pitch; + tile.m_comp = comp; + tile.m_base = base; + tile.m_bank = bank; + Memory.WriteData(Emu.GetGSManager().GetRender().m_tiles_addr + sizeof(CellGcmTileInfo)* index, tile.Pack()); + + return CELL_OK; +} + +u32 cellGcmSetUserHandler(u32 handler) +{ + cellGcmSys.Warning("cellGcmSetUserHandler(handler=0x%x)", handler); + return handler; +} + +int cellGcmSetVBlankHandler() +{ + UNIMPLEMENTED_FUNC(cellGcmSys); + return CELL_OK; +} + +int cellGcmSetWaitFlip(mem_ptr_t ctxt) +{ + cellGcmSys.Log("cellGcmSetWaitFlip(ctx=0x%x)", ctxt.GetAddr()); + + GSLockCurrent lock(GS_LOCK_WAIT_FLIP); + return CELL_OK; } int cellGcmSetZcull(u8 index, u32 offset, u32 width, u32 height, u32 cullStart, u32 zFormat, u32 aaFormat, u32 zCullDir, u32 zCullFormat, u32 sFunc, u32 sRef, u32 sMask) @@ -211,138 +436,298 @@ int cellGcmSetZcull(u8 index, u32 offset, u32 width, u32 height, u32 cullStart, return CELL_OK; } -int cellGcmBindZcull(u8 index) +int cellGcmUnbindTile(u8 index) { - cellGcmSys.Warning("TODO: cellGcmBindZcull(index=%d)", index); + cellGcmSys.Warning("cellGcmUnbindTile(index=%d)", index); + + if (index >= RSXThread::m_tiles_count) + { + return CELL_GCM_ERROR_INVALID_VALUE; + } + + auto& tile = Emu.GetGSManager().GetRender().m_tiles[index]; + tile.m_binded = false; return CELL_OK; } +int cellGcmUnbindZcull(u8 index) +{ + cellGcmSys.Warning("cellGcmUnbindZcull(index=%d)", index); + if (index >= 8) + return CELL_EINVAL; + + return CELL_OK; +} + +u32 cellGcmGetTileInfo() +{ + cellGcmSys.Warning("cellGcmGetTileInfo()"); + return Emu.GetGSManager().GetRender().m_tiles_addr; +} + u32 cellGcmGetZcullInfo() { cellGcmSys.Warning("cellGcmGetZcullInfo()"); return Emu.GetGSManager().GetRender().m_zculls_addr; } -int cellGcmGetFlipStatus() +u32 cellGcmGetDisplayInfo() { - return Emu.GetGSManager().GetRender().m_flip_status; + cellGcmSys.Warning("cellGcmGetDisplayInfo() = 0x%x", Emu.GetGSManager().GetRender().m_gcm_buffers_addr); + return Emu.GetGSManager().GetRender().m_gcm_buffers_addr; } -int cellGcmResetFlipStatus() +int cellGcmGetCurrentDisplayBufferId(u32 id_addr) { - Emu.GetGSManager().GetRender().m_flip_status = 1; + cellGcmSys.Warning("cellGcmGetCurrentDisplayBufferId(id_addr=0x%x)", id_addr); - return CELL_OK; -} - -int cellGcmSetFlipMode(u32 mode) -{ - cellGcmSys.Warning("cellGcmSetFlipMode(mode=%d)", mode); - - switch(mode) - { - case CELL_GCM_DISPLAY_HSYNC: - case CELL_GCM_DISPLAY_VSYNC: - case CELL_GCM_DISPLAY_HSYNC_WITH_NOISE: - Emu.GetGSManager().GetRender().m_flip_mode = mode; - break; - - default: - return CELL_EINVAL; - } - - return CELL_OK; -} - -u32 cellGcmGetTiledPitchSize(u32 size) -{ - //TODO - cellGcmSys.Warning("cellGcmGetTiledPitchSize(size=%d)", size); - - return size; -} - -u32 cellGcmSetUserHandler(u32 handler) -{ - cellGcmSys.Warning("cellGcmSetUserHandler(handler=0x%x)", handler); - return handler; -} - -u32 cellGcmGetDefaultCommandWordSize() -{ - cellGcmSys.Warning("cellGcmGetDefaultCommandWordSize()"); - return 0x400; -} - -u32 cellGcmGetDefaultSegmentWordSize() -{ - cellGcmSys.Warning("cellGcmGetDefaultSegmentWordSize()"); - return 0x100; -} - -int cellGcmSetDefaultFifoSize(u32 bufferSize, u32 segmentSize) -{ - cellGcmSys.Warning("cellGcmSetDefaultFifoSize(bufferSize=0x%x, segmentSize=0x%x)", bufferSize, segmentSize); - return CELL_OK; -} - -int cellGcmUnbindZcull(u8 index) -{ - cellGcmSys.Warning("cellGcmUnbindZcull(index=%d)", index); - if(index >= 8) - return CELL_EINVAL; - - return CELL_OK; -} - -u64 cellGcmGetTimeStamp(u32 index) -{ - cellGcmSys.Log("cellGcmGetTimeStamp(index=%d)", index); - return Memory.Read64(Memory.RSXFBMem.GetStartAddr() + index * 0x10); -} - -int cellGcmSetFlipHandler(u32 handler_addr) -{ - cellGcmSys.Warning("cellGcmSetFlipHandler(handler_addr=%d)", handler_addr); - if(handler_addr != 0 && !Memory.IsGoodAddr(handler_addr)) + if (!Memory.IsGoodAddr(id_addr)) { return CELL_EFAULT; } - Emu.GetGSManager().GetRender().m_flip_handler.SetAddr(handler_addr); + Memory.Write32(id_addr, Emu.GetGSManager().GetRender().m_gcm_current_buffer); + return CELL_OK; } -s64 cellGcmFunc15() +//---------------------------------------------------------------------------- +// Memory Mapping +//---------------------------------------------------------------------------- + +gcm_offset offsetTable = { 0, 0 }; + +void InitOffsetTable() { - cellGcmSys.Error("cellGcmFunc15()"); - return 0; + offsetTable.io = Memory.Alloc(3072 * sizeof(u16), 1); + for (int i = 0; i<3072; i++) + { + Memory.Write16(offsetTable.io + sizeof(u16)*i, 0xFFFF); + } + + offsetTable.ea = Memory.Alloc(256 * sizeof(u16), 1);//TODO: check flags + for (int i = 0; i<256; i++) + { + Memory.Write16(offsetTable.ea + sizeof(u16)*i, 0xFFFF); + } } -int cellGcmSetFlipCommandWithWaitLabel(u32 ctx, u32 id, u32 label_index, u32 label_value) +int32_t cellGcmAddressToOffset(u64 address, mem32_t offset) { - int res = cellGcmSetPrepareFlip(ctx, id); - Memory.Write32(Memory.RSXCMDMem.GetStartAddr() + 0x10 * label_index, label_value); - return res < 0 ? CELL_GCM_ERROR_FAILURE : CELL_OK; -} + cellGcmSys.Log("cellGcmAddressToOffset(address=0x%x,offset_addr=0x%x)", address, offset.GetAddr()); -int cellGcmSetFlip(mem_ptr_t ctxt, u32 id) -{ - cellGcmSys.Log("cellGcmSetFlip(ctx=0x%x, id=0x%x)", ctxt.GetAddr(), id); + if (address >= 0xD0000000/*not on main memory or local*/) + return CELL_GCM_ERROR_FAILURE; - int res = cellGcmSetPrepareFlip(ctxt, id); - return res < 0 ? CELL_GCM_ERROR_FAILURE : CELL_OK; -} + u32 result; -int cellGcmSetWaitFlip(mem_ptr_t ctxt) -{ - cellGcmSys.Log("cellGcmSetWaitFlip(ctx=0x%x)", ctxt.GetAddr()); + // If address is in range of local memory + if (Memory.RSXFBMem.IsInMyRange(address)) + { + result = address - Memory.RSXFBMem.GetStartAddr(); + } + // else check if the adress (main memory) is mapped in IO + else + { + u16 upper12Bits = Memory.Read16(offsetTable.io + sizeof(u16)*(address >> 20)); - GSLockCurrent lock(GS_LOCK_WAIT_FLIP); + if (upper12Bits != 0xFFFF) + { + result = (((u64)upper12Bits << 20) | (address & (0xFFFFF))); + } + // address is not mapped in IO + else + { + return CELL_GCM_ERROR_FAILURE; + } + } + + offset = result; return CELL_OK; } +uint32_t cellGcmGetMaxIoMapSize() +{ + return Memory.RSXIOMem.GetEndAddr() - Memory.RSXIOMem.GetStartAddr() - Memory.RSXIOMem.GetResevedAmount(); +} + +void cellGcmGetOffsetTable(mem_ptr_t table) +{ + table->io = re(offsetTable.io); + table->ea = re(offsetTable.ea); +} + +int32_t cellGcmIoOffsetToAddress(u32 ioOffset, u64 address) +{ + u64 realAddr; + + realAddr = Memory.RSXIOMem.getRealAddr(Memory.RSXIOMem.GetStartAddr() + ioOffset); + + if (!realAddr) + return CELL_GCM_ERROR_FAILURE; + + Memory.Write64(address, realAddr); + + return CELL_OK; +} + +int32_t cellGcmMapEaIoAddress(const u32 ea, const u32 io, const u32 size) +{ + cellGcmSys.Warning("cellGcmMapEaIoAddress(ea=0x%x, io=0x%x, size=0x%x)", ea, io, size); + + if ((ea & 0xFFFFF) || (io & 0xFFFFF) || (size & 0xFFFFF)) return CELL_GCM_ERROR_FAILURE; + + //check if the mapping was successfull + if (Memory.RSXIOMem.Map(ea, size, Memory.RSXIOMem.GetStartAddr() + io)) + { + //fill the offset table + for (u32 i = 0; i<(size >> 20); i++) + { + Memory.Write16(offsetTable.io + ((ea >> 20) + i)*sizeof(u16), (io >> 20) + i); + Memory.Write16(offsetTable.ea + ((io >> 20) + i)*sizeof(u16), (ea >> 20) + i); + } + } + else + { + return CELL_GCM_ERROR_FAILURE; + } + + return CELL_OK; +} + +int32_t cellGcmMapEaIoAddressWithFlags(const u32 ea, const u32 io, const u32 size, const u32 flags) +{ + cellGcmSys.Warning("cellGcmMapEaIoAddressWithFlags(ea=0x%x, io=0x%x, size=0x%x, flags=0x%x)", ea, io, size, flags); + return cellGcmMapEaIoAddress(ea, io, size); // TODO: strict ordering +} + +int32_t cellGcmMapLocalMemory(u64 address, u64 size) +{ + if (!local_size && !local_addr) + { + local_size = 0xf900000; //TODO + local_addr = Memory.RSXFBMem.GetStartAddr(); + Memory.RSXFBMem.AllocAlign(local_size); + Memory.Write32(address, local_addr); + Memory.Write32(size, local_size); + } + else + { + cellGcmSys.Error("RSX local memory already mapped"); + return CELL_GCM_ERROR_FAILURE; + } + + return CELL_OK; +} + +int32_t cellGcmMapMainMemory(u64 ea, u32 size, mem32_t offset) +{ + cellGcmSys.Warning("cellGcmMapMainMemory(ea=0x%x,size=0x%x,offset_addr=0x%x)", ea, size, offset.GetAddr()); + + u64 io; + + if ((ea & 0xFFFFF) || (size & 0xFFFFF)) return CELL_GCM_ERROR_FAILURE; + + //check if the mapping was successfull + if (io = Memory.RSXIOMem.Map(ea, size, 0)) + { + // convert to offset + io = io - Memory.RSXIOMem.GetStartAddr(); + + //fill the offset table + for (u32 i = 0; i<(size >> 20); i++) + { + Memory.Write16(offsetTable.io + ((ea >> 20) + i)*sizeof(u16), (io >> 20) + i); + Memory.Write16(offsetTable.ea + ((io >> 20) + i)*sizeof(u16), (ea >> 20) + i); + } + + offset = io; + } + else + { + return CELL_GCM_ERROR_NO_IO_PAGE_TABLE; + } + + Emu.GetGSManager().GetRender().m_main_mem_addr = Emu.GetGSManager().GetRender().m_ioAddress; + + return CELL_OK; +} + +int32_t cellGcmReserveIoMapSize(const u32 size) +{ + if (size & 0xFFFFF) + return CELL_GCM_ERROR_INVALID_ALIGNMENT; + + if (size > cellGcmGetMaxIoMapSize()) + return CELL_GCM_ERROR_INVALID_VALUE; + + Memory.RSXIOMem.Reserve(size); + return CELL_OK; +} + +int32_t cellGcmUnmapEaIoAddress(u64 ea) +{ + u32 size; + if (size = Memory.RSXIOMem.UnmapRealAddress(ea)) + { + u64 io; + ea = ea >> 20; + io = Memory.Read16(offsetTable.io + (ea*sizeof(u16))); + + for (u32 i = 0; i> 20; + ea = Memory.Read16(offsetTable.ea + (io*sizeof(u16))); + + for (u32 i = 0; i Memory.RSXIOMem.GetResevedAmount()) + return CELL_GCM_ERROR_INVALID_VALUE; + + Memory.RSXIOMem.Unreserve(size); + return CELL_OK; +} + +//------------------------------------------------------------------------ +// Cursor +//------------------------------------------------------------------------ + int cellGcmInitCursor() { UNIMPLEMENTED_FUNC(cellGcmSys); @@ -361,11 +746,6 @@ int cellGcmSetCursorDisable() return CELL_OK; } -int cellGcmSetVBlankHandler() -{ - UNIMPLEMENTED_FUNC(cellGcmSys); - return CELL_OK; -} int cellGcmUpdateCursor() { @@ -385,25 +765,9 @@ int cellGcmSetCursorImageOffset(u32 offset) return CELL_OK; } -u32 cellGcmGetDisplayInfo() -{ - cellGcmSys.Warning("cellGcmGetDisplayInfo() = 0x%x", Emu.GetGSManager().GetRender().m_gcm_buffers_addr); - return Emu.GetGSManager().GetRender().m_gcm_buffers_addr; -} - -int cellGcmGetCurrentDisplayBufferId(u32 id_addr) -{ - cellGcmSys.Warning("cellGcmGetCurrentDisplayBufferId(id_addr=0x%x)", id_addr); - - if(!Memory.IsGoodAddr(id_addr)) - { - return CELL_EFAULT; - } - - Memory.Write32(id_addr, Emu.GetGSManager().GetRender().m_gcm_current_buffer); - - return CELL_OK; -} +//------------------------------------------------------------------------ +// Functions for Maintaining Compatibility +//------------------------------------------------------------------------ void cellGcmSetDefaultCommandBuffer() { @@ -411,11 +775,26 @@ void cellGcmSetDefaultCommandBuffer() Memory.Write32(Emu.GetGSManager().GetRender().m_ctxt_addr, gcm_info.context_addr); } -void cellGcmSetFlipStatus() +//------------------------------------------------------------------------ +// Other +//------------------------------------------------------------------------ + +int cellGcmSetFlipCommand(u32 ctx, u32 id) { - cellGcmSys.Warning("cellGcmSetFlipStatus()"); - - Emu.GetGSManager().GetRender().m_flip_status = 0; + return cellGcmSetPrepareFlip(ctx, id); +} + +s64 cellGcmFunc15() +{ + cellGcmSys.Error("cellGcmFunc15()"); + return 0; +} + +int cellGcmSetFlipCommandWithWaitLabel(u32 ctx, u32 id, u32 label_index, u32 label_value) +{ + int res = cellGcmSetPrepareFlip(ctx, id); + Memory.Write32(Memory.RSXCMDMem.GetStartAddr() + 0x10 * label_index, label_value); + return res < 0 ? CELL_GCM_ERROR_FAILURE : CELL_OK; } int cellGcmSetTile(u8 index, u8 location, u32 offset, u32 size, u32 pitch, u8 comp, u16 base, u8 bank) @@ -457,361 +836,7 @@ int cellGcmSetTile(u8 index, u8 location, u32 offset, u32 size, u32 pitch, u8 co return CELL_OK; } -int cellGcmSetTileInfo(u8 index, u8 location, u32 offset, u32 size, u32 pitch, u8 comp, u16 base, u8 bank) -{ - cellGcmSys.Warning("cellGcmSetTileInfo(index=%d, location=%d, offset=%d, size=%d, pitch=%d, comp=%d, base=%d, bank=%d)", - index, location, offset, size, pitch, comp, base, bank); - - if(index >= RSXThread::m_tiles_count || base >= 800 || bank >= 4) - { - return CELL_GCM_ERROR_INVALID_VALUE; - } - - if(offset & 0xffff || size & 0xffff || pitch & 0xf) - { - return CELL_GCM_ERROR_INVALID_ALIGNMENT; - } - - if(location >= 2 || (comp != 0 && (comp < 7 || comp > 12))) - { - return CELL_GCM_ERROR_INVALID_ENUM; - } - - if(comp) - { - cellGcmSys.Error("cellGcmSetTileInfo: bad comp! (%d)", comp); - } - - auto& tile = Emu.GetGSManager().GetRender().m_tiles[index]; - tile.m_location = location; - tile.m_offset = offset; - tile.m_size = size; - tile.m_pitch = pitch; - tile.m_comp = comp; - tile.m_base = base; - tile.m_bank = bank; - Memory.WriteData(Emu.GetGSManager().GetRender().m_tiles_addr + sizeof(CellGcmTileInfo) * index, tile.Pack()); - - return CELL_OK; -} - -int cellGcmBindTile(u8 index) -{ - cellGcmSys.Warning("cellGcmBindTile(index=%d)", index); - - if(index >= RSXThread::m_tiles_count) - { - return CELL_GCM_ERROR_INVALID_VALUE; - } - - auto& tile = Emu.GetGSManager().GetRender().m_tiles[index]; - tile.m_binded = true; - - return CELL_OK; -} - -int cellGcmUnbindTile(u8 index) -{ - cellGcmSys.Warning("cellGcmUnbindTile(index=%d)", index); - - if(index >= RSXThread::m_tiles_count) - { - return CELL_GCM_ERROR_INVALID_VALUE; - } - - auto& tile = Emu.GetGSManager().GetRender().m_tiles[index]; - tile.m_binded = false; - - return CELL_OK; -} - -u32 cellGcmGetTileInfo() -{ - cellGcmSys.Warning("cellGcmGetTileInfo()"); - return Emu.GetGSManager().GetRender().m_tiles_addr; -} - -int cellGcmInitDefaultFifoMode(int mode) -{ - cellGcmSys.Warning("cellGcmInitDefaultFifoMode(mode=%d)", mode); - return CELL_OK; -} - -u32 cellGcmGetReportDataAddressLocation(u8 location, u32 index) -{ - ConLog.Warning("cellGcmGetReportDataAddressLocation(location=%d, index=%d)", location, index); - return Emu.GetGSManager().GetRender().m_report_main_addr; -} - -int cellGcmSetDebugOutputLevel (int level) -{ - cellGcmSys.Warning("cellGcmSetDebugOutputLevel(level=%d)", level); - - switch (level) - { - case CELL_GCM_DEBUG_LEVEL0: - case CELL_GCM_DEBUG_LEVEL1: - case CELL_GCM_DEBUG_LEVEL2: - Emu.GetGSManager().GetRender().m_debug_level = level; - break; - - default: return CELL_EINVAL; - } - - return CELL_OK; -} - -int cellGcmSetSecondVFrequency (u32 freq) -{ - cellGcmSys.Warning("cellGcmSetSecondVFrequency(level=%d)", freq); - - switch (freq) - { - case CELL_GCM_DISPLAY_FREQUENCY_59_94HZ: - case CELL_GCM_DISPLAY_FREQUENCY_SCANOUT: - case CELL_GCM_DISPLAY_FREQUENCY_DISABLE: - Emu.GetGSManager().GetRender().m_frequency_mode = freq; - break; - - default: return CELL_EINVAL; - } - - return CELL_OK; -} - -/*------------------------------------------------------------ - Memory Mapping -------------------------------------------------------------*/ - -gcm_offset offsetTable = {0, 0}; - -void InitOffsetTable() -{ - offsetTable.io = Memory.Alloc(3072*sizeof(u16), 1); - for(int i=0; i<3072; i++) - { - Memory.Write16(offsetTable.io + sizeof(u16)*i, 0xFFFF); - } - - offsetTable.ea = Memory.Alloc(256*sizeof(u16), 1);//TODO: check flags - for(int i=0; i<256; i++) - { - Memory.Write16(offsetTable.ea + sizeof(u16)*i, 0xFFFF); - } -} - -int32_t cellGcmAddressToOffset(u64 address, mem32_t offset) -{ - cellGcmSys.Log("cellGcmAddressToOffset(address=0x%x,offset_addr=0x%x)", address, offset.GetAddr()); - - if(address >= 0xD0000000/*not on main memory or local*/) - return CELL_GCM_ERROR_FAILURE; - - u32 result; - - // If address is in range of local memory - if(Memory.RSXFBMem.IsInMyRange(address)) - { - result = address - Memory.RSXFBMem.GetStartAddr(); - } - // else check if the adress (main memory) is mapped in IO - else - { - u16 upper12Bits = Memory.Read16(offsetTable.io + sizeof(u16)*(address >> 20)); - - if(upper12Bits != 0xFFFF) - { - result = (((u64)upper12Bits << 20) | (address & (0xFFFFF))); - } - // address is not mapped in IO - else - { - return CELL_GCM_ERROR_FAILURE; - } - } - - offset = result; - return CELL_OK; -} - -uint32_t cellGcmGetMaxIoMapSize() -{ - return Memory.RSXIOMem.GetEndAddr() - Memory.RSXIOMem.GetStartAddr() - Memory.RSXIOMem.GetResevedAmount(); -} - -void cellGcmGetOffsetTable(mem_ptr_t table) -{ - table->io = re(offsetTable.io); - table->ea = re(offsetTable.ea); -} - -int32_t cellGcmIoOffsetToAddress(u32 ioOffset, u64 address) -{ - u64 realAddr; - - realAddr = Memory.RSXIOMem.getRealAddr(Memory.RSXIOMem.GetStartAddr() + ioOffset); - - if(!realAddr) - return CELL_GCM_ERROR_FAILURE; - - Memory.Write64(address, realAddr); - - return CELL_OK; -} - -int32_t cellGcmMapEaIoAddress(const u32 ea, const u32 io, const u32 size) -{ - cellGcmSys.Warning("cellGcmMapEaIoAddress(ea=0x%x, io=0x%x, size=0x%x)", ea, io, size); - - if((ea & 0xFFFFF) || (io & 0xFFFFF) || (size & 0xFFFFF)) return CELL_GCM_ERROR_FAILURE; - - //check if the mapping was successfull - if(Memory.RSXIOMem.Map(ea, size, Memory.RSXIOMem.GetStartAddr() + io)) - { - //fill the offset table - for(u32 i=0; i<(size >> 20); i++) - { - Memory.Write16(offsetTable.io + ((ea >> 20) + i)*sizeof(u16), (io >> 20) + i); - Memory.Write16(offsetTable.ea + ((io >> 20) + i)*sizeof(u16), (ea >> 20) + i); - } - } - else - { - return CELL_GCM_ERROR_FAILURE; - } - - return CELL_OK; -} - -int32_t cellGcmMapEaIoAddressWithFlags(const u32 ea, const u32 io, const u32 size, const u32 flags) -{ - cellGcmSys.Warning("cellGcmMapEaIoAddressWithFlags(ea=0x%x, io=0x%x, size=0x%x, flags=0x%x)", ea, io, size, flags); - return cellGcmMapEaIoAddress(ea, io, size); // TODO: strict ordering -} - -int32_t cellGcmMapLocalMemory(u64 address, u64 size) -{ - if(!local_size && !local_addr) - { - local_size = 0xf900000; //TODO - local_addr = Memory.RSXFBMem.GetStartAddr(); - Memory.RSXFBMem.AllocAlign(local_size); - Memory.Write32(address, local_addr); - Memory.Write32(size, local_size); - } - else - { - cellGcmSys.Error("RSX local memory already mapped"); - return CELL_GCM_ERROR_FAILURE; - } - - return CELL_OK; -} - -int32_t cellGcmMapMainMemory(u64 ea, u32 size, mem32_t offset) -{ - cellGcmSys.Warning("cellGcmMapMainMemory(ea=0x%x,size=0x%x,offset_addr=0x%x)", ea, size, offset.GetAddr()); - - u64 io; - - if((ea & 0xFFFFF) || (size & 0xFFFFF)) return CELL_GCM_ERROR_FAILURE; - - //check if the mapping was successfull - if(io = Memory.RSXIOMem.Map(ea, size, 0)) - { - // convert to offset - io = io - Memory.RSXIOMem.GetStartAddr(); - - //fill the offset table - for(u32 i=0; i<(size >> 20); i++) - { - Memory.Write16(offsetTable.io + ((ea >> 20) + i)*sizeof(u16), (io >> 20) + i); - Memory.Write16(offsetTable.ea + ((io >> 20) + i)*sizeof(u16), (ea >> 20) + i); - } - - offset = io; - } - else - { - return CELL_GCM_ERROR_NO_IO_PAGE_TABLE; - } - - Emu.GetGSManager().GetRender().m_main_mem_addr = Emu.GetGSManager().GetRender().m_ioAddress; - - return CELL_OK; -} - -int32_t cellGcmReserveIoMapSize(const u32 size) -{ - if(size & 0xFFFFF) - return CELL_GCM_ERROR_INVALID_ALIGNMENT; - - if(size > cellGcmGetMaxIoMapSize()) - return CELL_GCM_ERROR_INVALID_VALUE; - - Memory.RSXIOMem.Reserve(size); - return CELL_OK; -} - -int32_t cellGcmUnmapEaIoAddress(u64 ea) -{ - u32 size; - if(size = Memory.RSXIOMem.UnmapRealAddress(ea)) - { - u64 io; - ea = ea >> 20; - io = Memory.Read16(offsetTable.io + (ea*sizeof(u16))); - - for(u32 i=0; i> 20; - ea = Memory.Read16(offsetTable.ea + (io*sizeof(u16))); - - for(u32 i=0; i Memory.RSXIOMem.GetResevedAmount()) - return CELL_GCM_ERROR_INVALID_VALUE; - - Memory.RSXIOMem.Unreserve(size); - return CELL_OK; -} - -//------------------------------------------------------------ +//---------------------------------------------------------------------------- void cellGcmSys_init() { From b571f14fe467451013b189bfdf3aadcec997bd71 Mon Sep 17 00:00:00 2001 From: Anthony Miyaguchi Date: Sun, 30 Mar 2014 17:25:55 -0700 Subject: [PATCH 3/4] Function declaration at top needed for another function. --- rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp b/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp index b357796b4c..8259bf5e30 100644 --- a/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp +++ b/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp @@ -21,6 +21,9 @@ enum CELL_GCM_ERROR_ADDRESS_OVERWRAP = 0x80210005 }; +// Function declaration +int cellGcmSetPrepareFlip(mem_ptr_t ctxt, u32 id); + /*------------------------------------------------------------ Memory Mapping ------------------------------------------------------------*/ @@ -724,9 +727,9 @@ int32_t cellGcmUnreserveIoMapSize(u32 size) return CELL_OK; } -//------------------------------------------------------------------------ +//---------------------------------------------------------------------------- // Cursor -//------------------------------------------------------------------------ +//---------------------------------------------------------------------------- int cellGcmInitCursor() { From 2106fb83b26f1d9cfb1d9cf64c936dd1ea68c684 Mon Sep 17 00:00:00 2001 From: Anthony Miyaguchi Date: Sun, 30 Mar 2014 18:01:51 -0700 Subject: [PATCH 4/4] Added cellGcmSetUserHandler that already existed but was never added. --- rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp b/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp index 8259bf5e30..ef054f7492 100644 --- a/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp +++ b/rpcs3/Emu/SysCalls/Modules/cellGcmSys.cpp @@ -919,7 +919,7 @@ void cellGcmSys_init() cellGcmSys.AddFunc(0x4d7ce993, cellGcmSetSecondVFrequency); // cellGcmSetSecondVHandler cellGcmSys.AddFunc(0xbd100dbc, cellGcmSetTileInfo); - // cellGcmSetUserHandler TODO: Function exists + cellGcmSys.AddFunc(0x06edea9e, cellGcmSetUserHandler); // cellGcmSetVBlankFrequency cellGcmSys.AddFunc(0xa91b0402, cellGcmSetVBlankHandler); cellGcmSys.AddFunc(0x983fb9aa, cellGcmSetWaitFlip);