mirror/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-03-25 16:43:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

rsx: more efficient command reading

Browse Source
This commit is contained in:
eladash 2018-06-27 07:06:58 +03:00 committed by kd-11
parent 42851a93d4
commit 345f92ab0a
1 changed files with 21 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
rpcs3/Emu/RSX/RSXThread.cpp
View File

@ -576,18 +576,20 @@ namespace rsx
continue; continue;
} }
//Validate put and get registers // Validate put and get registers before reading the command
// TODO: Who should handle graphics exceptions?? // TODO: Who should handle graphics exceptions??
const u32 get_address = RSXIOMem.RealAddr(internal_get); u32 cmd;
{
u32 get_address;
if (!get_address) if (!RSXIOMem.getRealAddr(internal_get, get_address))
{ {
LOG_ERROR(RSX, "Invalid FIFO queue get/put registers found, get=0x%X, put=0x%X", internal_get.load(), put); LOG_ERROR(RSX, "Invalid FIFO queue get/put registers found, get=0x%X, put=0x%X", internal_get.load(), put);
if (mem_faults_count >= 3) if (mem_faults_count >= 3)
{ {
LOG_ERROR(RSX, "Application has failed to recover, resetting FIFO queue"); LOG_ERROR(RSX, "Application has failed to recover, resetting FIFO queue");
internal_get = restore_point.load();; internal_get = restore_point.load();
} }
else else
{ {
@ -599,7 +601,9 @@ namespace rsx
continue; continue;
} }
const u32 cmd = ReadIO32(internal_get); cmd = vm::read32(get_address);
}
const u32 count = (cmd >> 18) & 0x7ff; const u32 count = (cmd >> 18) & 0x7ff;
if ((cmd & RSX_METHOD_OLD_JUMP_CMD_MASK) == RSX_METHOD_OLD_JUMP_CMD) if ((cmd & RSX_METHOD_OLD_JUMP_CMD_MASK) == RSX_METHOD_OLD_JUMP_CMD)