diff --git a/rpcs3/Emu/Io/PadHandler.cpp b/rpcs3/Emu/Io/PadHandler.cpp index 2efdebc585..2d58b33564 100644 --- a/rpcs3/Emu/Io/PadHandler.cpp +++ b/rpcs3/Emu/Io/PadHandler.cpp @@ -290,13 +290,13 @@ PadHandlerBase::connection PadHandlerBase::get_next_button_press(const std::stri if (callback) { - const pad_preview_values preview_values = get_preview_values(data); + pad_preview_values preview_values = get_preview_values(data); const u32 battery_level = get_battery_level(pad_id); if (pressed_button.value > 0) - callback(pressed_button.value, pressed_button.name, pad_id, battery_level, preview_values); + callback(pressed_button.value, pressed_button.name, pad_id, battery_level, std::move(preview_values)); else - callback(0, "", pad_id, battery_level, preview_values); + callback(0, "", pad_id, battery_level, std::move(preview_values)); } return status; diff --git a/rpcs3/Input/evdev_joystick_handler.cpp b/rpcs3/Input/evdev_joystick_handler.cpp index 1507f57a61..5c512a26d8 100644 --- a/rpcs3/Input/evdev_joystick_handler.cpp +++ b/rpcs3/Input/evdev_joystick_handler.cpp @@ -483,9 +483,9 @@ PadHandlerBase::connection evdev_joystick_handler::get_next_button_press(const s if (callback) { if (pressed_button.value > 0) - callback(pressed_button.value, pressed_button.name, padId, 0, preview_values); + callback(pressed_button.value, pressed_button.name, padId, 0, std::move(preview_values)); else - callback(0, "", padId, 0, preview_values); + callback(0, "", padId, 0, std::move(preview_values)); } return connection::connected; diff --git a/rpcs3/Input/mm_joystick_handler.cpp b/rpcs3/Input/mm_joystick_handler.cpp index 5f77e51785..cf99b1de46 100644 --- a/rpcs3/Input/mm_joystick_handler.cpp +++ b/rpcs3/Input/mm_joystick_handler.cpp @@ -379,9 +379,9 @@ PadHandlerBase::connection mm_joystick_handler::get_next_button_press(const std: } if (pressed_button.value > 0) - callback(pressed_button.value, pressed_button.name, padId, 0, preview_values); + callback(pressed_button.value, pressed_button.name, padId, 0, std::move(preview_values)); else - callback(0, "", padId, 0, preview_values); + callback(0, "", padId, 0, std::move(preview_values)); } return connection::connected; diff --git a/rpcs3/rpcs3qt/pad_settings_dialog.cpp b/rpcs3/rpcs3qt/pad_settings_dialog.cpp index d809a1090a..7cc308b0bf 100644 --- a/rpcs3/rpcs3qt/pad_settings_dialog.cpp +++ b/rpcs3/rpcs3qt/pad_settings_dialog.cpp @@ -575,9 +575,15 @@ void pad_settings_dialog::InitButtons() const std::vector buttons = { - m_cfg_entries[button_ids::id_pad_l2].keys, m_cfg_entries[button_ids::id_pad_r2].keys, m_cfg_entries[button_ids::id_pad_lstick_left].keys, - m_cfg_entries[button_ids::id_pad_lstick_right].keys, m_cfg_entries[button_ids::id_pad_lstick_down].keys, m_cfg_entries[button_ids::id_pad_lstick_up].keys, - m_cfg_entries[button_ids::id_pad_rstick_left].keys, m_cfg_entries[button_ids::id_pad_rstick_right].keys, m_cfg_entries[button_ids::id_pad_rstick_down].keys, + m_cfg_entries[button_ids::id_pad_l2].keys, + m_cfg_entries[button_ids::id_pad_r2].keys, + m_cfg_entries[button_ids::id_pad_lstick_left].keys, + m_cfg_entries[button_ids::id_pad_lstick_right].keys, + m_cfg_entries[button_ids::id_pad_lstick_down].keys, + m_cfg_entries[button_ids::id_pad_lstick_up].keys, + m_cfg_entries[button_ids::id_pad_rstick_left].keys, + m_cfg_entries[button_ids::id_pad_rstick_right].keys, + m_cfg_entries[button_ids::id_pad_rstick_down].keys, m_cfg_entries[button_ids::id_pad_rstick_up].keys };