From 02c263fc19661ac1f866518db48c30697a1293a5 Mon Sep 17 00:00:00 2001 From: luxsie Date: Sat, 11 Apr 2015 13:31:28 +0800 Subject: [PATCH] Remove comments in confirmed files. --- rpcs3/Emu/FS/vfsStreamMemory.cpp | 1 - rpcs3/Emu/RSX/RSXThread.cpp | 3 --- rpcs3/Emu/SysCalls/Modules/cellCamera.h | 1 - rpcs3/Emu/SysCalls/Modules/cellSpurs.cpp | 2 -- rpcs3/Emu/SysCalls/lv2/sys_spu.cpp | 3 +-- 5 files changed, 1 insertion(+), 9 deletions(-) diff --git a/rpcs3/Emu/FS/vfsStreamMemory.cpp b/rpcs3/Emu/FS/vfsStreamMemory.cpp index 2f3283318f..5ce30c3a7c 100644 --- a/rpcs3/Emu/FS/vfsStreamMemory.cpp +++ b/rpcs3/Emu/FS/vfsStreamMemory.cpp @@ -38,7 +38,6 @@ u64 vfsStreamMemory::Write(const void* src, u64 size) u64 vfsStreamMemory::Read(void* dst, u64 size) { - // TODO:: Syphurith: Should us do anything? Since Asserts aren't included in Release builds. assert(Tell() < GetSize()); if (Tell() + size > GetSize()) { diff --git a/rpcs3/Emu/RSX/RSXThread.cpp b/rpcs3/Emu/RSX/RSXThread.cpp index 0d185c6c0a..6bc9344ca0 100644 --- a/rpcs3/Emu/RSX/RSXThread.cpp +++ b/rpcs3/Emu/RSX/RSXThread.cpp @@ -200,7 +200,6 @@ u32 RSXThread::OutOfArgsCount(const uint x, const u32 cmd, const u32 count, cons #define case_32(offset, step) \ case_16(offset, step) \ case_16(offset + 16*step, step) -// TODO:: Syphurith: I'm not sure about whether this is correct or missing a break;. #define case_range(n, offset, step) \ case_##n(offset, step) \ index = (cmd - offset) / step @@ -369,7 +368,6 @@ void RSXThread::DoCmd(const u32 fcmd, const u32 cmd, const u32 args_addr, const } // Texture - // TODO:: Syphurith: Ensure it don't need to break;? case 0: A=0; case 1: A=1; would always give you A=1. case_range(16, NV4097_SET_TEXTURE_FORMAT, 0x20); case_range(16, NV4097_SET_TEXTURE_OFFSET, 0x20); case_range(16, NV4097_SET_TEXTURE_FILTER, 0x20); @@ -400,7 +398,6 @@ void RSXThread::DoCmd(const u32 fcmd, const u32 cmd, const u32 args_addr, const } // Vertex Texture - // TODO:: Syphurith: Ensure it don't need to break;? Similiar reason.. case_range(4, NV4097_SET_VERTEX_TEXTURE_FORMAT, 0x20); case_range(4, NV4097_SET_VERTEX_TEXTURE_OFFSET, 0x20); case_range(4, NV4097_SET_VERTEX_TEXTURE_FILTER, 0x20); diff --git a/rpcs3/Emu/SysCalls/Modules/cellCamera.h b/rpcs3/Emu/SysCalls/Modules/cellCamera.h index 95c505bd6f..12ae95270a 100644 --- a/rpcs3/Emu/SysCalls/Modules/cellCamera.h +++ b/rpcs3/Emu/SysCalls/Modules/cellCamera.h @@ -314,7 +314,6 @@ struct CellCameraAttributes u32 LED; u32 AUDIOGAIN; u32 QS; -// Syphurith: Found using cppcheck. This is originally stated as an single-element array, however references its [0] and [1]. So i changed this to 2 u32 units. u32 NONZEROCOEFFS[2]; u32 YUVFLAG; u32 JPEGFLAG; diff --git a/rpcs3/Emu/SysCalls/Modules/cellSpurs.cpp b/rpcs3/Emu/SysCalls/Modules/cellSpurs.cpp index 9f82dec553..f2474f841c 100644 --- a/rpcs3/Emu/SysCalls/Modules/cellSpurs.cpp +++ b/rpcs3/Emu/SysCalls/Modules/cellSpurs.cpp @@ -2206,7 +2206,6 @@ s32 cellSpursCreateTasksetWithAttribute(vm::ptr spurs, vm::ptr taskset, vm::ptr task_id, vm: if (tmp_task_id >= CELL_SPURS_MAX_TASK) { - // Syphurith: If that is intentionally done, please remove the 'return'. Or else just remove this comment. return CELL_SPURS_TASK_ERROR_AGAIN; } diff --git a/rpcs3/Emu/SysCalls/lv2/sys_spu.cpp b/rpcs3/Emu/SysCalls/lv2/sys_spu.cpp index 0f83676866..ee8f1ca6dd 100644 --- a/rpcs3/Emu/SysCalls/lv2/sys_spu.cpp +++ b/rpcs3/Emu/SysCalls/lv2/sys_spu.cpp @@ -508,8 +508,7 @@ s32 sys_spu_thread_group_terminate(u32 id, s32 value) } } - // TODO:: Syphurith: Thank @danilaml (first) and let us talk about this mistake/typo. Have you used the wrong constant for the third condition? - if ((group->state <= SPU_THREAD_GROUP_STATUS_INITIALIZED) || (group->state == SPU_THREAD_GROUP_STATUS_WAITING) || (group->state == SPU_THREAD_GROUP_STATUS_WAITING)) + if ((group->state <= SPU_THREAD_GROUP_STATUS_INITIALIZED) || (group->state == SPU_THREAD_GROUP_STATUS_WAITING)) { return CELL_EINVAL; }