mirror/rabbitizer
1
0
Fork 0
mirror of https://github.com/Decompollaborate/rabbitizer.git synced 2024-12-26 09:17:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix heap corruption in Rust bindings (#62)

Browse Source 
RabbitizerInstruction_getSizeForBuffer and
RabbitizerOperandType_getBufferSize return
the size _without_ the null terminator, so
we need to allocate one more byte to avoid
writing past the allocated vector bounds.
This commit is contained in:
Luke Street 2024-05-22 10:33:15 -06:00 committed by GitHub
parent f5c65d02d1
commit 4dd2a55588
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rust/src/instruction.rs
View File

@ -709,7 +709,7 @@ impl Instruction {
let buffer_size =
RabbitizerInstruction_getSizeForBuffer(self, imm_override_len, extra_l_just);
let mut buffer: Vec<u8> = vec![0; buffer_size];
let mut buffer: Vec<u8> = vec![0; buffer_size + 1];
let disassembled_size = RabbitizerInstruction_disassemble(
self,
buffer.as_mut_ptr() as *mut core::ffi::c_char,

2
rust/src/opereand_type.rs
View File

@ -30,7 +30,7 @@ impl operand_type_enum::OperandType {
unsafe {
let buffer_size = RabbitizerOperandType_getBufferSize(*self, instr, imm_override_len);
let mut buffer: Vec<u8> = vec![0; buffer_size];
let mut buffer: Vec<u8> = vec![0; buffer_size + 1];
let disassembled_size = RabbitizerOperandType_disassemble(
*self,
instr,