add bug comments to stuff i think might be a bug?

This commit is contained in:
JohnCorby 2022-05-18 11:39:28 -07:00
parent f8f9f26a1c
commit a97ef83cf5
5 changed files with 6 additions and 0 deletions

View File

@ -35,6 +35,7 @@ public class QSBStalkAction : QSBGhostAction
protected override void OnEnterAction()
{
// BUG: this checks only for the host's lantern concealed?
var flag = Locator.GetDreamWorldController().GetPlayerLantern().GetLanternController().IsConcealed();
_wasPlayerLanternConcealed = flag;
_isFocusingLight = flag;

View File

@ -72,6 +72,7 @@ internal class GhostPartyPathDirectorPatches : QSBPatch
__instance._numArrivedGhosts++;
}
// BUG: only checks for host blocking the respawn?
if (!__instance._respawnBlockTrigger.IsTrackingObject(Locator.GetPlayerDetector()))
{
__instance._dispatchedGhosts.QuickRemoveAt(i);

View File

@ -408,6 +408,7 @@ public class QSBGhostBrain : WorldObject<GhostBrain>, IGhostObject
_data.currentAction = GhostAction.Name.None;
}
// BUG: IsExitingDream happens for one frame, but still, doesn't this not evaluate actions if host is leaving dream world?
if (_data.isAlive && !Locator.GetDreamWorldController().IsExitingDream())
{
AttachedObject.EvaluateActions();
@ -593,6 +594,7 @@ public class QSBGhostBrain : WorldObject<GhostBrain>, IGhostObject
{
var playersInDreamworld = QSBPlayerManager.PlayerList.Where(x => x.InDreamWorld);
// BUG: doesn't this disable the ghost if the host is the only player left?
if (playersInDreamworld.Count() == 0 || (playersInDreamworld.Count() == 1 && playersInDreamworld.First() == QSBPlayerManager.LocalPlayer))
{
DebugLog.DebugWrite($"No players in dream world");

View File

@ -36,6 +36,7 @@ public class QSBGhostController : WorldObject<GhostController>, IGhostObject
AttachedObject._grabController.Initialize(effects.AttachedObject);
AttachedObject._lantern.SetLit(true);
AttachedObject.MoveLanternToCarrySocket(false, 0.1f);
// BUG: i have no idea what this does, but it's still local player shenanigans?
AttachedObject._playerCollider = Locator.GetPlayerBody().GetComponent<CapsuleCollider>();
}

View File

@ -94,6 +94,7 @@ internal class QSBPrisonerBrain : WorldObject<PrisonerBrain>, IGhostObject
if (Controller.AttachedObject.IsMoving())
{
// BUG: does this make it not stop for remote players?
bool movementPaused = AttachedObject._blockMovementVolume.IsTrackingObject(Locator.GetPlayerDetector()) || !AttachedObject._allowMovementVolume.IsTrackingObject(Locator.GetPlayerDetector());
Controller.AttachedObject.SetMovementPaused(movementPaused);
}