mirror/quantum-space-buddies
1
0
Fork 0
mirror of https://github.com/misternebula/quantum-space-buddies.git synced 2025-02-06 00:39:55 +00:00
Code Issues Projects Releases Wiki Activity

redundant arguments with default value

Browse Source
This commit is contained in:
JohnCorby 2021-12-26 21:08:36 -08:00
parent 748397fa29
commit a0a1c21a66
21 changed files with 57 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
QSB/Animation/Player/Patches/PlayerAnimationPatches.cs
View File

@ -60,7 +60,7 @@ namespace QSB.Animation.Player.Patches
var lastGroundBody = ____playerController.GetLastGroundBody();
if (!isGrounded && !isAttached && !isInZeroG && lastGroundBody != null)
{
freefallMagnitude = (____playerController.GetAttachedOWRigidbody(false).GetVelocity() - lastGroundBody.GetPointVelocity(____playerController.transform.position)).magnitude;
freefallMagnitude = (____playerController.GetAttachedOWRigidbody().GetVelocity() - lastGroundBody.GetPointVelocity(____playerController.transform.position)).magnitude;
timeInFreefall = Time.time - ____ungroundedTime;
}

8
QSB/Audio/QSBPlayerAudioController.cs
View File

@ -23,16 +23,16 @@ namespace QSB.Audio
}
public void PlayEquipTool()
=> _oneShotExternalSource.PlayOneShot(AudioType.ToolTranslatorEquip, 1f);
=> _oneShotExternalSource.PlayOneShot(AudioType.ToolTranslatorEquip);
public void PlayUnequipTool()
=> _oneShotExternalSource.PlayOneShot(AudioType.ToolTranslatorUnequip, 1f);
=> _oneShotExternalSource.PlayOneShot(AudioType.ToolTranslatorUnequip);
public void PlayTurnOnFlashlight()
=> _oneShotExternalSource.PlayOneShot(AudioType.ToolFlashlightOn, 1f);
=> _oneShotExternalSource.PlayOneShot(AudioType.ToolFlashlightOn);
public void PlayTurnOffFlashlight()
=> _oneShotExternalSource.PlayOneShot(AudioType.ToolFlashlightOff, 1f);
=> _oneShotExternalSource.PlayOneShot(AudioType.ToolFlashlightOff);
private OWAudioSource CreateBaseAudio(
Transform parent,

2
QSB/DeathSync/Patches/DeathPatches.cs
View File

@ -91,7 +91,7 @@ namespace QSB.DeathSync.Patches
}
else if (__instance.gameObject.CompareTag("Ship"))
{
__instance.GetComponent<ShipDamageController>().Explode(false);
__instance.GetComponent<ShipDamageController>().Explode();
}
}

4
QSB/DeathSync/Patches/MapPatches.cs
View File

@ -164,9 +164,9 @@ namespace QSB.DeathSync.Patches
var zoomInput = 0f;
if (canInteractWith)
{
XZinput = OWInput.GetAxisValue(InputLibrary.moveXZ, InputMode.All);
XZinput = OWInput.GetAxisValue(InputLibrary.moveXZ);
lookInput = InputLibrary.look.GetAxisValue(false);
zoomInput = OWInput.GetValue(InputLibrary.mapZoomIn, InputMode.All) - OWInput.GetValue(InputLibrary.mapZoomOut, InputMode.All);
zoomInput = OWInput.GetValue(InputLibrary.mapZoomIn) - OWInput.GetValue(InputLibrary.mapZoomOut);
lookInput.y *= -1f;
zoomInput *= -1f;
}

8
QSB/EchoesOfTheEye/LightSensorSync/Patches/LightSensorPatches.cs
View File

@ -65,7 +65,7 @@ namespace QSB.EchoesOfTheEye.LightSensorSync.Patches
var position = Locator.GetPlayerCamera().transform.position;
var to = __instance.transform.position - position;
if (Vector3.Angle(Locator.GetPlayerCamera().transform.forward, to) <= __instance._maxSpotHalfAngle
&& !__instance.CheckOcclusion(position, vector, sensorWorldDir, true))
&& !__instance.CheckOcclusion(position, vector, sensorWorldDir))
{
__instance._illuminated = true;
}
@ -77,7 +77,7 @@ namespace QSB.EchoesOfTheEye.LightSensorSync.Patches
var position = player.Camera.transform.position;
var to = __instance.transform.position - position;
if (Vector3.Angle(player.Camera.transform.forward, to) <= __instance._maxSpotHalfAngle
&& !__instance.CheckOcclusion(position, vector, sensorWorldDir, true))
&& !__instance.CheckOcclusion(position, vector, sensorWorldDir))
{
__instance._illuminated = true;
}
@ -92,7 +92,7 @@ namespace QSB.EchoesOfTheEye.LightSensorSync.Patches
&& probe.IsLaunched()
&& !probe.IsRetrieving()
&& probe.CheckIlluminationAtPoint(vector, __instance._sensorRadius, __instance._maxDistance)
&& !__instance.CheckOcclusion(probe.GetLightSourcePosition(), vector, sensorWorldDir, true))
&& !__instance.CheckOcclusion(probe.GetLightSourcePosition(), vector, sensorWorldDir))
{
__instance._illuminated = true;
}
@ -110,7 +110,7 @@ namespace QSB.EchoesOfTheEye.LightSensorSync.Patches
if (dreamLanternController.IsLit()
&& dreamLanternController.IsFocused(__instance._lanternFocusThreshold)
&& dreamLanternController.CheckIlluminationAtPoint(vector, __instance._sensorRadius, __instance._maxDistance)
&& !__instance.CheckOcclusion(dreamLanternController.GetLightPosition(), vector, sensorWorldDir, true))
&& !__instance.CheckOcclusion(dreamLanternController.GetLightPosition(), vector, sensorWorldDir))
{
__instance._illuminatingDreamLanternList.Add(dreamLanternController);
__instance._illuminated = true;

4
QSB/ElevatorSync/WorldObjects/QSBElevator.cs
View File

@ -43,9 +43,9 @@ namespace QSB.ElevatorSync.WorldObjects
AttachedObject._attachPoint.AttachPlayer();
if (Locator.GetPlayerSuit().IsWearingSuit(true) && Locator.GetPlayerSuit().IsTrainingSuit())
if (Locator.GetPlayerSuit().IsWearingSuit() && Locator.GetPlayerSuit().IsTrainingSuit())
{
Locator.GetPlayerSuit().RemoveSuit(false);
Locator.GetPlayerSuit().RemoveSuit();
}
RemoteStartLift();

22
QSB/EyeOfTheUniverse/GalaxyMap/QSBCharacterDialogueTree.cs
View File

@ -82,7 +82,7 @@ namespace QSB.EyeOfTheUniverse.GalaxyMap
{
if (_currentDialogueBox != null && OWInput.GetInputMode() == InputMode.Dialogue)
{
if (OWInput.IsNewlyPressed(InputLibrary.interact, InputMode.All) || OWInput.IsNewlyPressed(InputLibrary.cancel, InputMode.All) || OWInput.IsNewlyPressed(InputLibrary.enter, InputMode.All) || OWInput.IsNewlyPressed(InputLibrary.enter2, InputMode.All))
if (OWInput.IsNewlyPressed(InputLibrary.interact) || OWInput.IsNewlyPressed(InputLibrary.cancel) || OWInput.IsNewlyPressed(InputLibrary.enter) || OWInput.IsNewlyPressed(InputLibrary.enter2))
{
if (!_currentDialogueBox.AreTextEffectsComplete())
{
@ -104,13 +104,13 @@ namespace QSB.EyeOfTheUniverse.GalaxyMap
}
else
{
if (OWInput.IsNewlyPressed(InputLibrary.down, InputMode.All) || OWInput.IsNewlyPressed(InputLibrary.down2, InputMode.All))
if (OWInput.IsNewlyPressed(InputLibrary.down) || OWInput.IsNewlyPressed(InputLibrary.down2))
{
_currentDialogueBox.OnDownPressed();
return;
}
if (OWInput.IsNewlyPressed(InputLibrary.up, InputMode.All) || OWInput.IsNewlyPressed(InputLibrary.up2, InputMode.All))
if (OWInput.IsNewlyPressed(InputLibrary.up) || OWInput.IsNewlyPressed(InputLibrary.up2))
{
_currentDialogueBox.OnUpPressed();
}
@ -180,7 +180,7 @@ namespace QSB.EyeOfTheUniverse.GalaxyMap
dialogueNode.ListEntryCondition.Add(xelement5.Value);
if (!sharedInstance.ConditionExists(xelement5.Value))
{
sharedInstance.AddCondition(xelement5.Value, false);
sharedInstance.AddCondition(xelement5.Value);
}
}
}
@ -256,7 +256,7 @@ namespace QSB.EyeOfTheUniverse.GalaxyMap
dialogueOption.ConditionRequirement = xelement13.Element("RequiredCondition").Value;
if (!sharedInstance.ConditionExists(dialogueOption.ConditionRequirement))
{
sharedInstance.AddCondition(dialogueOption.ConditionRequirement, false);
sharedInstance.AddCondition(dialogueOption.ConditionRequirement);
}
}
@ -270,7 +270,7 @@ namespace QSB.EyeOfTheUniverse.GalaxyMap
dialogueOption.CancelledRequirement = xelement13.Element("CancelledCondition").Value;
if (!sharedInstance.ConditionExists(dialogueOption.CancelledRequirement))
{
sharedInstance.AddCondition(dialogueOption.CancelledRequirement, false);
sharedInstance.AddCondition(dialogueOption.CancelledRequirement);
}
}
@ -289,7 +289,7 @@ namespace QSB.EyeOfTheUniverse.GalaxyMap
dialogueOption.ConditionToSet = xelement13.Element("ConditionToSet").Value;
if (!sharedInstance.ConditionExists(dialogueOption.ConditionToSet))
{
sharedInstance.AddCondition(dialogueOption.ConditionToSet, false);
sharedInstance.AddCondition(dialogueOption.ConditionToSet);
}
}
@ -298,7 +298,7 @@ namespace QSB.EyeOfTheUniverse.GalaxyMap
dialogueOption.ConditionToCancel = xelement13.Element("ConditionToCancel").Value;
if (!sharedInstance.ConditionExists(dialogueOption.ConditionToCancel))
{
sharedInstance.AddCondition(dialogueOption.ConditionToCancel, false);
sharedInstance.AddCondition(dialogueOption.ConditionToCancel);
}
}
@ -368,12 +368,12 @@ namespace QSB.EyeOfTheUniverse.GalaxyMap
_currentDialogueBox = DisplayDialogueBox2();
if (_attentionPoint != null && !PlayerState.InZeroG())
{
Locator.GetPlayerTransform().GetRequiredComponent<PlayerLockOnTargeting>().LockOn(_attentionPoint, _attentionPointOffset, 2f, false, 1f);
Locator.GetPlayerTransform().GetRequiredComponent<PlayerLockOnTargeting>().LockOn(_attentionPoint, _attentionPointOffset, 2f);
}
if (PlayerState.InZeroG() && !_timeFrozen)
{
Locator.GetPlayerBody().GetComponent<Autopilot>().StartMatchVelocity(this.GetAttachedOWRigidbody(false).GetReferenceFrame(), false);
Locator.GetPlayerBody().GetComponent<Autopilot>().StartMatchVelocity(this.GetAttachedOWRigidbody().GetReferenceFrame());
}
}
@ -497,7 +497,7 @@ namespace QSB.EyeOfTheUniverse.GalaxyMap
if (selectedOption.ConditionToCancel != string.Empty)
{
DialogueConditionManager.SharedInstance.SetConditionState(selectedOption.ConditionToCancel, false);
DialogueConditionManager.SharedInstance.SetConditionState(selectedOption.ConditionToCancel);
}
if (selectedOption.TargetName == string.Empty)

4
QSB/EyeOfTheUniverse/GalaxyMap/QSBDialogueNode.cs
View File

@ -149,12 +149,12 @@ namespace QSB.EyeOfTheUniverse.GalaxyMap
if (PersistentConditionToDisable != string.Empty)
{
PlayerData.SetPersistentCondition(PersistentConditionToDisable, false);
sharedInstance.SetConditionState(PersistentConditionToDisable, false);
sharedInstance.SetConditionState(PersistentConditionToDisable);
}
for (var j = 0; j < DBEntriesToSet.Length; j++)
{
Locator.GetShipLogManager().RevealFact(DBEntriesToSet[j], true, true);
Locator.GetShipLogManager().RevealFact(DBEntriesToSet[j]);
}
}
}

2
QSB/EyeOfTheUniverse/InstrumentSync/Patches/QuantumInstrumentPatches.cs
View File

@ -28,7 +28,7 @@ namespace QSB.EyeOfTheUniverse.InstrumentSync.Patches
&& Vector3.Angle(__instance.transform.position - Locator.GetPlayerCamera().transform.position, Locator.GetPlayerCamera().transform.forward) < 1f)
{
__instance._scopeGatherPrompt.SetVisibility(true);
if (OWInput.IsNewlyPressed(InputLibrary.interact, InputMode.All))
if (OWInput.IsNewlyPressed(InputLibrary.interact))
{
__instance.Gather();
__instance.GetWorldObject<QSBQuantumInstrument>().SendMessage(new GatherInstrumentMessage());

4
QSB/Menus/MenuManager.cs
View File

@ -133,7 +133,7 @@ namespace QSB.Menus
if (QSBSceneManager.IsInUniverse)
{
LoadManager.LoadScene(OWScene.TitleScreen, LoadManager.FadeType.ToBlack, 2f, true);
LoadManager.LoadScene(OWScene.TitleScreen, LoadManager.FadeType.ToBlack, 2f);
}
}
@ -262,7 +262,7 @@ namespace QSB.Menus
OWInput.RestorePreviousInputs();
LoadManager.LoadScene(OWScene.TitleScreen, LoadManager.FadeType.ToBlack, 2f, true);
LoadManager.LoadScene(OWScene.TitleScreen, LoadManager.FadeType.ToBlack, 2f);
}
private void Host()

2
QSB/Player/PlayerInfo.cs
View File

@ -230,7 +230,7 @@ namespace QSB.Player
else
{
FlashlightActive = Locator.GetFlashlight()._flashlightOn;
SuitedUp = Locator.GetPlayerBody().GetComponent<PlayerSpacesuit>().IsWearingSuit(true);
SuitedUp = Locator.GetPlayerBody().GetComponent<PlayerSpacesuit>().IsWearingSuit();
}
new PlayerInformationMessage().Send();

10
QSB/PoolSync/CustomNomaiRemoteCameraPlatform.cs
View File

@ -201,7 +201,7 @@ namespace QSB.PoolSync
_slavePlatform.UpdateRendererFade();
SwitchToRemoteCamera();
_hologramGroup.SetActive(true);
_ambientAudioSource.FadeIn(3f, true, false, 1f);
_ambientAudioSource.FadeIn(3f, true);
Locator.GetAudioMixer().MixRemoteCameraPlatform(_fadeInLength);
_cameraState = CameraState.Connecting_FadeOut;
}
@ -538,7 +538,7 @@ namespace QSB.PoolSync
{
if (_dataPointID.Length > 0)
{
Locator.GetShipLogManager().RevealFact(_dataPointID, true, true);
Locator.GetShipLogManager().RevealFact(_dataPointID);
}
}
@ -562,7 +562,7 @@ namespace QSB.PoolSync
_cameraState = CameraState.Connecting_FadeIn;
}
_oneShotAudioSource.PlayOneShot(AudioType.NomaiRemoteCameraEntry, 1f);
_oneShotAudioSource.PlayOneShot(AudioType.NomaiRemoteCameraEntry);
enabled = true;
}
@ -584,8 +584,8 @@ namespace QSB.PoolSync
else
{
_cameraState = CameraState.Disconnecting_FadeIn;
_ambientAudioSource.FadeOut(0.5f, OWAudioSource.FadeOutCompleteAction.STOP, 0f);
_oneShotAudioSource.PlayOneShot(AudioType.NomaiRemoteCameraExit, 1f);
_ambientAudioSource.FadeOut(0.5f);
_oneShotAudioSource.PlayOneShot(AudioType.NomaiRemoteCameraExit);
Locator.GetAudioMixer().UnmixRemoteCameraPlatform(_fadeOutLength);
}
}

4
QSB/PoolSync/CustomNomaiRemoteCameraStreaming.cs
View File

@ -37,8 +37,8 @@
{
_hasLoadedAssets = true;
_streamingGroup = StreamingGroup.GetStreamingGroup(NomaiRemoteCameraStreaming.NomaiRemoteCameraPlatformIDToSceneName(stone.GetRemoteCameraID()));
_streamingGroup.RequestRequiredAssets(0);
_streamingGroup.RequestGeneralAssets(0);
_streamingGroup.RequestRequiredAssets();
_streamingGroup.RequestGeneralAssets();
}
}
}

2
QSB/QuantumSync/Patches/QuantumPatches.cs
View File

@ -413,7 +413,7 @@ namespace QSB.QuantumSync.Patches
{
__instance._isPlayerInside = true;
__instance.SetSurfaceState(__instance._stateIndex);
Locator.GetShipLogManager().RevealFact(__instance._revealFactID, true, true);
Locator.GetShipLogManager().RevealFact(__instance._revealFactID);
GlobalMessenger.FireEvent(OWEvents.PlayerEnterQuantumMoon);
}
else

2
QSB/QuantumSync/Patches/ServerQuantumPatches.cs
View File

@ -238,7 +238,7 @@ namespace QSB.QuantumSync.Patches
else
{
__instance.SetSurfaceState(-1);
__instance._quantumSignal.SetSignalActivation(__instance._stateIndex != 5, 2f);
__instance._quantumSignal.SetSignalActivation(__instance._stateIndex != 5);
}
__instance._referenceFrameVolume.gameObject.SetActive(__instance._stateIndex != 5);

2
QSB/RespawnSync/RespawnManager.cs
View File

@ -129,7 +129,7 @@ namespace QSB.RespawnSync
mapController.ExitMapView();
var cameraEffectController = Locator.GetPlayerCamera().GetComponent<PlayerCameraEffectController>();
cameraEffectController.OpenEyes(1f, false);
cameraEffectController.OpenEyes(1f);
}
public void OnPlayerDeath(PlayerInfo player)

6
QSB/SatelliteSync/Patches/SatelliteProjectorPatches.cs
View File

@ -44,7 +44,7 @@ namespace QSB.SatelliteSync.Patches
return false;
}
if (OWInput.IsNewlyPressed(InputLibrary.toolActionPrimary, InputMode.All))
if (OWInput.IsNewlyPressed(InputLibrary.toolActionPrimary))
{
new SatelliteProjectorSnapshotMessage(true).Send();
__instance._satelliteCamera.transform.localEulerAngles = __instance._initCamLocalRot;
@ -52,7 +52,7 @@ namespace QSB.SatelliteSync.Patches
return false;
}
if (__instance._allowRearview && OWInput.IsNewlyPressed(InputLibrary.toolActionSecondary, InputMode.All))
if (__instance._allowRearview && OWInput.IsNewlyPressed(InputLibrary.toolActionSecondary))
{
new SatelliteProjectorSnapshotMessage(false).Send();
__instance._satelliteCamera.transform.localEulerAngles = __instance._initCamLocalRot + new Vector3(0f, 180f, 0f);
@ -60,7 +60,7 @@ namespace QSB.SatelliteSync.Patches
return false;
}
if (OWInput.IsNewlyPressed(InputLibrary.cancel, InputMode.All))
if (OWInput.IsNewlyPressed(InputLibrary.cancel))
{
__instance.TurnOffProjector();
}

12
QSB/SatelliteSync/SatelliteProjectorManager.cs
View File

@ -74,11 +74,11 @@ namespace QSB.SatelliteSync
if (Projector._fadeLight != null)
{
Projector._fadeLight.StartFade(0f, 2f, 0f);
Projector._fadeLight.StartFade(0f, 2f);
}
var audioClip = Projector._oneShotSource.PlayOneShot(AudioType.TH_ProjectorActivate, 1f);
Projector._loopingSource.FadeIn(audioClip.length, false, false, 1f);
var audioClip = Projector._oneShotSource.PlayOneShot(AudioType.TH_ProjectorActivate);
Projector._loopingSource.FadeIn(audioClip.length);
}
public void RemoteExit()
@ -96,11 +96,11 @@ namespace QSB.SatelliteSync
if (Projector._fadeLight != null)
{
Projector._fadeLight.StartFade(Projector._initLightIntensity, 2f, 0f);
Projector._fadeLight.StartFade(Projector._initLightIntensity, 2f);
}
var audioClip = Projector._oneShotSource.PlayOneShot(AudioType.TH_ProjectorStop, 1f);
Projector._loopingSource.FadeOut(audioClip.length, OWAudioSource.FadeOutCompleteAction.STOP, 0f);
var audioClip = Projector._oneShotSource.PlayOneShot(AudioType.TH_ProjectorStop);
Projector._loopingSource.FadeOut(audioClip.length);
}
public void RemoteTakeSnapshot(bool forward)

10
QSB/Tools/ProbeTool/QSBProbeEffects.cs
View File

@ -35,7 +35,7 @@ namespace QSB.Tools.ProbeTool
_probe.OnStartRetrieveProbe -= OnStartRetrieve;
}
private void OnLaunch() => _flightLoopAudio.FadeIn(0.1f, true, true, 1f);
private void OnLaunch() => _flightLoopAudio.FadeIn(0.1f, true, true);
private void OnAnchor()
{
@ -49,14 +49,14 @@ namespace QSB.Tools.ProbeTool
//{
_anchorParticles.Play();
//}
_flightLoopAudio.FadeOut(0.5f, OWAudioSource.FadeOutCompleteAction.STOP, 0f);
_anchorAudio.PlayOneShot(AudioType.ToolProbeAttach, 1f);
_flightLoopAudio.FadeOut(0.5f);
_anchorAudio.PlayOneShot(AudioType.ToolProbeAttach);
}
private void OnUnanchor()
=> _flightLoopAudio.FadeIn(0.5f, false, false, 1f);
=> _flightLoopAudio.FadeIn(0.5f);
private void OnStartRetrieve(float retrieveLength)
=> _flightLoopAudio.FadeOut(retrieveLength, OWAudioSource.FadeOutCompleteAction.STOP, 0f);
=> _flightLoopAudio.FadeOut(retrieveLength);
}
}

2
QSB/ZeroGCaveSync/Patches/ZeroGCavePatches.cs
View File

@ -31,7 +31,7 @@ namespace QSB.ZeroGCaveSync.Patches
.SendMessage(new SatelliteNodeRepairedMessage());
__instance._damaged = false;
var component = Locator.GetPlayerTransform().GetComponent<ReferenceFrameTracker>();
if (component.GetReferenceFrame(true) == __instance._rfVolume.GetReferenceFrame())
if (component.GetReferenceFrame() == __instance._rfVolume.GetReferenceFrame())
{
component.UntargetReferenceFrame();
}

2
QSB/ZeroGCaveSync/WorldObjects/QSBSatelliteNode.cs
View File

@ -10,7 +10,7 @@ namespace QSB.ZeroGCaveSync.WorldObjects
DebugLog.DebugWrite($"[SATELLITE NODE] {AttachedObject} Set repaired.");
AttachedObject._damaged = false;
var component = Locator.GetPlayerTransform().GetComponent<ReferenceFrameTracker>();
if (component.GetReferenceFrame(true) == AttachedObject._rfVolume.GetReferenceFrame())
if (component.GetReferenceFrame() == AttachedObject._rfVolume.GetReferenceFrame())
{
component.UntargetReferenceFrame();
}