mirror of
https://github.com/protocolbuffers/protobuf-go.git
synced 2025-01-04 02:38:50 +00:00
8c86fc5e7d
Immediately abort (un)marshal operations when encountering invalid UTF-8 data in proto3 strings. No other proto implementation supports non-UTF-8 data in proto3 strings (and many reject it in proto2 strings as well). Producing invalid output is an interoperability threat (other implementations won't be able to read it). The case where existing string data is found to contain non-UTF8 data is better handled by changing the field to the `bytes` type, which (aside from UTF-8 validation) is wire-compatible with `string`. Remove the errors.NonFatal type, since there are no remaining cases where it is needed. "Non-fatal" errors which produce results and a non-nil error are problematic because they compose poorly; the better approach is to take an option like AllowPartial indicating which conditions to check for. Change-Id: I9d189ec6ffda7b5d96d094aa1b290af2e3f23736 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/183098 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
32 lines
803 B
Go
32 lines
803 B
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package errors
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestNewPrefix(t *testing.T) {
|
|
e1 := New("abc")
|
|
got := e1.Error()
|
|
if !strings.HasPrefix(got, "proto:") {
|
|
t.Errorf("missing \"proto:\" prefix in %q", got)
|
|
}
|
|
if !strings.Contains(got, "abc") {
|
|
t.Errorf("missing text \"abc\" in %q", got)
|
|
}
|
|
|
|
e2 := New("%v", e1)
|
|
got = e2.Error()
|
|
if !strings.HasPrefix(got, "proto:") {
|
|
t.Errorf("missing \"proto:\" prefix in %q", got)
|
|
}
|
|
// Test to make sure prefix is removed from the embedded error.
|
|
if strings.Contains(strings.TrimPrefix(got, "proto:"), "proto:") {
|
|
t.Errorf("prefix \"proto:\" not elided in embedded error: %q", got)
|
|
}
|
|
}
|