mirror of
https://github.com/protocolbuffers/protobuf-go.git
synced 2024-12-29 12:17:48 +00:00
44e4150b30
For simplicity, IsValid was implemented in terms of regular expressions, which are useful for verifying a string according to a strict grammar, but performs poorly. Implement the check in terms of hand-written code, which provides a 20x improvement to validate the name "google.protobuf.Any". name old time/op new time/op delta FullNameIsValid-8 683ns ± 2% 35ns ± 1% -94.86% (p=0.000 n=10+10) Change-Id: I980403befca0b72cea22acd274064a46cb02644b Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/238002 Reviewed-by: Damien Neil <dneil@google.com>
83 lines
1.6 KiB
Go
83 lines
1.6 KiB
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package protoreflect
|
|
|
|
import "testing"
|
|
|
|
func TestNameIsValid(t *testing.T) {
|
|
tests := []struct {
|
|
in Name
|
|
want bool
|
|
}{
|
|
{"", false},
|
|
{"a", true},
|
|
{".", false},
|
|
{"_", true}, // odd, but permitted by protoc
|
|
{".foo", false},
|
|
{"foo.", false},
|
|
{"foo", true},
|
|
{"one1_two2_three3", true},
|
|
{"1one", false},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
if got := tt.in.IsValid(); got != tt.want {
|
|
t.Errorf("Name(%q).IsValid() = %v, want %v", tt.in, got, tt.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestFullNameIsValid(t *testing.T) {
|
|
tests := []struct {
|
|
in FullName
|
|
want bool
|
|
}{
|
|
{"", false},
|
|
{"a", true},
|
|
{"a.b", true},
|
|
{"a.b.c", true},
|
|
{".", false},
|
|
{"_._._", true}, // odd, but permitted by protoc
|
|
{".foo", false},
|
|
{"foo.", false},
|
|
{"foo", true},
|
|
{"one1_two2_three3", true},
|
|
{"one1.two2.three3", true},
|
|
{".one1.two2.three3", false},
|
|
{"one1.two2.three3.", false},
|
|
{"foo.1one", false},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
if got := tt.in.IsValid(); got != tt.want {
|
|
t.Errorf("Name(%q).IsValid() = %v, want %v", tt.in, got, tt.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestNameAppend(t *testing.T) {
|
|
tests := []FullName{
|
|
"",
|
|
"a",
|
|
"a.b",
|
|
"a.b.c",
|
|
"one1.two2.three3",
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
if got := tt.Parent().Append(tt.Name()); got != tt {
|
|
t.Errorf("FullName.Parent().Append(FullName.Name()) = %q, want %q", got, tt)
|
|
}
|
|
}
|
|
}
|
|
|
|
var sink bool
|
|
|
|
func BenchmarkFullNameIsValid(b *testing.B) {
|
|
for i := 0; i < b.N; i++ {
|
|
sink = FullName("google.protobuf.Any").IsValid()
|
|
}
|
|
}
|