mirror/protobuf-go
1
0
Fork 0
mirror of https://github.com/protocolbuffers/protobuf-go.git synced 2024-12-29 12:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
cedb595154
protobuf-go/proto
History
Damien Neil cedb595154 proto, internal/impl: avoid string->[]byte conversions 
We trust the compiler to optimize away the string->[]byte conversion in
code like:

	b = wire.AppendBytes(b, []byte(s))

In testing (go 1.12.5 linux/amd64), this optimization is not happening.
Perhaps newer versions of the compiler will optimize this, but we
shouldn't rely on it; avoid unnecessary conversions.

Benchmark differences vs https://golang.org/cl/171462:

  name                                   old time/op    new time/op    delta
  Wire/Marshal/google_message1_proto2-6     310ns ± 2%     189ns ± 3%  -39.20%  (p=0.000 n=8+8)
  Wire/Marshal/google_message1_proto3-6     389ns ± 8%     261ns ± 2%  -33.03%  (p=0.000 n=8+8)
  Wire/Marshal/google_message2-6            103µs ±11%      59µs ± 4%  -42.17%  (p=0.000 n=8+8)

  name                                   old alloc/op   new alloc/op   delta
  Wire/Marshal/google_message1_proto2-6      592B ± 0%      240B ± 0%  -59.46%  (p=0.000 n=8+8)
  Wire/Marshal/google_message1_proto3-6      576B ± 0%      224B ± 0%  -61.11%  (p=0.000 n=8+8)
  Wire/Marshal/google_message2-6            196kB ± 0%      90kB ± 0%  -54.05%  (p=0.000 n=8+8)

  name                                   old allocs/op  new allocs/op  delta
  Wire/Marshal/google_message1_proto2-6      5.00 ± 0%      1.00 ± 0%  -80.00%  (p=0.000 n=8+8)
  Wire/Marshal/google_message1_proto3-6      5.00 ± 0%      1.00 ± 0%  -80.00%  (p=0.000 n=8+8)
  Wire/Marshal/google_message2-6            1.66k ± 0%     0.00k ± 0%  -99.94%  (p=0.000 n=8+8)

Change-Id: Idab7634b8c86604dffa46895ba2e61be38c9bd9c
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/183380
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
2019-06-24 17:41:45 +00:00
..
bench_test.go proto: add benchmark using protobuf repo test data 2019-06-20 20:38:50 +00:00
decode_gen.go all: remove non-fatal UTF-8 validation errors (and non-fatal in general) 2019-06-20 20:55:13 +00:00
decode_test.go all: remove non-fatal UTF-8 validation errors (and non-fatal in general) 2019-06-20 20:55:13 +00:00
decode.go all: remove non-fatal UTF-8 validation errors (and non-fatal in general) 2019-06-20 20:55:13 +00:00
encode_gen.go proto, internal/impl: avoid string->[]byte conversions 2019-06-24 17:41:45 +00:00
encode_test.go all: remove non-fatal UTF-8 validation errors (and non-fatal in general) 2019-06-20 20:55:13 +00:00
encode.go all: remove non-fatal UTF-8 validation errors (and non-fatal in general) 2019-06-20 20:55:13 +00:00
equal_test.go reflect/protoreflect: add alternative message reflection API 2019-06-17 17:33:24 +00:00
equal.go reflect/protoreflect: add alternative message reflection API 2019-06-17 17:33:24 +00:00
isinit_test.go all: change module to google.golang.org/protobuf 2019-05-14 17:28:29 +00:00
isinit.go all: remove non-fatal UTF-8 validation errors (and non-fatal in general) 2019-06-20 20:55:13 +00:00
proto_methods.go all: change module to google.golang.org/protobuf 2019-05-14 17:28:29 +00:00
proto_reflect.go all: change module to google.golang.org/protobuf 2019-05-14 17:28:29 +00:00
proto.go all: change module to google.golang.org/protobuf 2019-05-14 17:28:29 +00:00
reset_test.go proto: fix memory aliasing bug in Reset 2019-06-20 19:48:37 +00:00
reset.go proto: fix memory aliasing bug in Reset 2019-06-20 19:48:37 +00:00
size_gen.go proto, internal/impl: avoid string->[]byte conversions 2019-06-24 17:41:45 +00:00
size.go reflect/protoreflect: add alternative message reflection API 2019-06-17 17:33:24 +00:00