mirror of
https://github.com/protocolbuffers/protobuf-go.git
synced 2025-01-30 03:32:49 +00:00
358fe40267
The grow() method in func did create a new internal byte slice with a
specific size instead of a specific capacity. As the call following
grow() is append() we ended up with a slice larger than needed.
It affects the memory consumption of programs that import generated
protobuf files. As an example with the following:
-- go.mod --
module x
go 1.20
require cloud.google.com/go/appengine v1.6.0
-- main.go --
package main
import _ "cloud.google.com/go/appengine/apiv1/appenginepb"
func main() {}
Running the following a few times:
$ go mod tidy && GODEBUG=inittrace=1 go run . 2>&1 | grep appenginepb
Before:
init cloud.google.com/go/appengine/apiv1/appenginepb @3.4 ms, 0.23 ms clock, 204624 bytes, 231 allocs
init cloud.google.com/go/appengine/apiv1/appenginepb @3.2 ms, 0.17 ms clock, 204688 bytes, 231 allocs
init cloud.google.com/go/appengine/apiv1/appenginepb @2.5 ms, 0.15 ms clock, 204400 bytes, 230 allocs
init cloud.google.com/go/appengine/apiv1/appenginepb @2.5 ms, 0.16 ms clock, 205552 bytes, 234 allocs
After:
init cloud.google.com/go/appengine/apiv1/appenginepb @3.3 ms, 0.19 ms clock, 143440 bytes, 226 allocs
init cloud.google.com/go/appengine/apiv1/appenginepb @2.7 ms, 0.16 ms clock, 144368 bytes, 229 allocs
init cloud.google.com/go/appengine/apiv1/appenginepb @2.8 ms, 0.16 ms clock, 144304 bytes, 229 allocs
init cloud.google.com/go/appengine/apiv1/appenginepb @3.1 ms, 0.16 ms clock, 142864 bytes, 224 allocs
Change-Id: If4ece5d70d6bd9de8a758cb29ce9dffc741c4951
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/465115
Reviewed-by: Joseph Tsai <joetsai@digital-static.net>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Michael Stapelberg <stapelberg@google.com>
96 lines
2.5 KiB
Go
96 lines
2.5 KiB
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
//go:build !purego && !appengine
|
|
// +build !purego,!appengine
|
|
|
|
package strs
|
|
|
|
import (
|
|
"unsafe"
|
|
|
|
"google.golang.org/protobuf/reflect/protoreflect"
|
|
)
|
|
|
|
type (
|
|
stringHeader struct {
|
|
Data unsafe.Pointer
|
|
Len int
|
|
}
|
|
sliceHeader struct {
|
|
Data unsafe.Pointer
|
|
Len int
|
|
Cap int
|
|
}
|
|
)
|
|
|
|
// UnsafeString returns an unsafe string reference of b.
|
|
// The caller must treat the input slice as immutable.
|
|
//
|
|
// WARNING: Use carefully. The returned result must not leak to the end user
|
|
// unless the input slice is provably immutable.
|
|
func UnsafeString(b []byte) (s string) {
|
|
src := (*sliceHeader)(unsafe.Pointer(&b))
|
|
dst := (*stringHeader)(unsafe.Pointer(&s))
|
|
dst.Data = src.Data
|
|
dst.Len = src.Len
|
|
return s
|
|
}
|
|
|
|
// UnsafeBytes returns an unsafe bytes slice reference of s.
|
|
// The caller must treat returned slice as immutable.
|
|
//
|
|
// WARNING: Use carefully. The returned result must not leak to the end user.
|
|
func UnsafeBytes(s string) (b []byte) {
|
|
src := (*stringHeader)(unsafe.Pointer(&s))
|
|
dst := (*sliceHeader)(unsafe.Pointer(&b))
|
|
dst.Data = src.Data
|
|
dst.Len = src.Len
|
|
dst.Cap = src.Len
|
|
return b
|
|
}
|
|
|
|
// Builder builds a set of strings with shared lifetime.
|
|
// This differs from strings.Builder, which is for building a single string.
|
|
type Builder struct {
|
|
buf []byte
|
|
}
|
|
|
|
// AppendFullName is equivalent to protoreflect.FullName.Append,
|
|
// but optimized for large batches where each name has a shared lifetime.
|
|
func (sb *Builder) AppendFullName(prefix protoreflect.FullName, name protoreflect.Name) protoreflect.FullName {
|
|
n := len(prefix) + len(".") + len(name)
|
|
if len(prefix) == 0 {
|
|
n -= len(".")
|
|
}
|
|
sb.grow(n)
|
|
sb.buf = append(sb.buf, prefix...)
|
|
sb.buf = append(sb.buf, '.')
|
|
sb.buf = append(sb.buf, name...)
|
|
return protoreflect.FullName(sb.last(n))
|
|
}
|
|
|
|
// MakeString is equivalent to string(b), but optimized for large batches
|
|
// with a shared lifetime.
|
|
func (sb *Builder) MakeString(b []byte) string {
|
|
sb.grow(len(b))
|
|
sb.buf = append(sb.buf, b...)
|
|
return sb.last(len(b))
|
|
}
|
|
|
|
func (sb *Builder) grow(n int) {
|
|
if cap(sb.buf)-len(sb.buf) >= n {
|
|
return
|
|
}
|
|
|
|
// Unlike strings.Builder, we do not need to copy over the contents
|
|
// of the old buffer since our builder provides no API for
|
|
// retrieving previously created strings.
|
|
sb.buf = make([]byte, 0, 2*(cap(sb.buf)+n))
|
|
}
|
|
|
|
func (sb *Builder) last(n int) string {
|
|
return UnsafeString(sb.buf[len(sb.buf)-n:])
|
|
}
|