Michael Stapelberg bdcc7adc94 internal/impl: skip synthetic oneofs in messageInfo ...

Calling WhichOneof should not be possible for synthetic oneofs;
on the reflection level, these fields should work as if they
were regular fields, not as if they were oneofs:

> Reflection for proto3 optional fields should work properly. For example, a
> method like Reflection::HasField() should know to look for the hasbit for a
> proto3 optional field. It should not be fooled by the synthetic oneof into
> thinking that there is a case member for the oneof.

From the Protobuf docs at:
https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md#updating-reflection

This change was tested Google-internally as CL 701866153.

Change-Id: Id9500d4aa492acf4ebc6d2d84be07ed81201d2aa
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/632735
Reviewed-by: Chressie Himpel <chressie@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

2024-12-02 08:52:41 +00:00

..

protocmp

testing/protocmp: document behavior when combining Ignore and Sort

2024-10-28 09:07:43 +00:00

protopack

all: modernize documentation

2023-09-05 14:55:28 +00:00

prototest

internal/impl: skip synthetic oneofs in messageInfo

2024-12-02 08:52:41 +00:00