mirror/protobuf-go
1
0
Fork 0
mirror of https://github.com/protocolbuffers/protobuf-go.git synced 2025-01-01 03:14:16 +00:00
Code Issues Packages Projects Releases Wiki Activity
Go support for Google's protocol buffers
485 Commits 1 Branch 27 Tags 20 MiB
Go 99.8%
Shell 0.2%
a6af044c3f
Go to file
Damien Neil a6af044c3f internal/impl: fix data race in atomicNilMessage 
The problem is that atomicNilMessage.m.mi is accessed both by atomic and
non-atomic operations. (Init uses an atomic read to verify that m.mi is
non-nil, but then returns a non-atomic m.)

Race condition is demonstrated by this test with
"go test -race -count=1000":

	func TestPointer(t *testing.T) {
		var m atomicNilMessage
		var mi MessageInfo
		ch := make(chan *MessageInfo)
		for i := 0; i < 20; i++ {
			go func() {
				r := m.Init(&mi)
				if &mi != r.mi {
					// This conditional exists just
					// ensure r.mi is touched.
					t.Error("mismatch")
				}
				ch <- r.mi
			}()
		}
		for i := 0; i < 20; i++ {
			<-ch
		}
	}

I chose not to add the test since it seems a bit overfit to the specific
situation.

Change-Id: Id4664ef3cd5b29515ed310851b9aeb7561be30d0
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/188337
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
2019-08-02 21:09:23 +00:00
benchmarks benchmarks: move download_benchdata.bash into benchmarks/ dir 2019-07-09 22:36:27 +00:00
cmd cmd/protoc-gen-go: minor code changes to assist internal patches 2019-07-20 08:29:32 +00:00
compiler/protogen compiler/protogen: use protoreflect.SourcePath 2019-07-15 18:21:33 +00:00
encoding cmd/protoc-gen-go: update deprecation warning 2019-07-18 02:26:18 +00:00
internal internal/impl: fix data race in atomicNilMessage 2019-08-02 21:09:23 +00:00
proto proto: remove dependency on github.com/golang/protobuf 2019-07-15 22:26:29 +00:00
reflect reflect/protoregistry: add conflict override 2019-07-18 17:47:11 +00:00
runtime all: implement proto1 weak fields 2019-07-15 18:44:12 +00:00
testing/prototest all: implement proto1 weak fields 2019-07-15 18:44:12 +00:00
types cmd/protoc-gen-go: refactor logic to be more compartmentalized 2019-07-19 08:16:51 +00:00
.gitignore integration_test.go: move Go cache 2019-07-12 00:35:42 +00:00
.travis.yml .travis.yml: configure for OSX 2019-03-13 18:04:08 +00:00
AUTHORS
CONTRIBUTING.md
CONTRIBUTORS
go.mod all: update to github.com/golang/protobuf@b9f5089f 2019-07-18 00:01:40 +00:00
go.sum all: update to github.com/golang/protobuf@b9f5089f 2019-07-18 00:01:40 +00:00
integration_test.go all: implement proto1 weak fields 2019-07-15 18:44:12 +00:00
LICENSE
PATENTS
README.md
regenerate.bash internal/cmd/generate-protos: generate test for testdata 2019-03-11 19:40:53 +00:00
test.bash internal/cmd/generate-protos: generate test for testdata 2019-03-11 19:40:53 +00:00

README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.