mirror of
https://github.com/protocolbuffers/protobuf-go.git
synced 2025-01-17 01:12:51 +00:00
3d0706ac2e
Make the fast-path and slow-path versions of IsInitialized report exactly the same errors: An errors.RequiredNotSet containing the full name of one of the unset required fields. Bugfix: Fast-path IsInitialized on a nil message reports an error only when the message directly contains required fields. Bugfix: Include fast-path IsInitialized in legacy messageIfaceWrapper. Fixes golang/protobuf#887 Change-Id: Ia5e4b386f8c23f6f855d995f4a098b1338acbae3 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/185397 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
58 lines
1.5 KiB
Go
58 lines
1.5 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style.
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package proto
|
|
|
|
import (
|
|
"google.golang.org/protobuf/internal/errors"
|
|
pref "google.golang.org/protobuf/reflect/protoreflect"
|
|
)
|
|
|
|
// IsInitialized returns an error if any required fields in m are not set.
|
|
func IsInitialized(m Message) error {
|
|
if methods := protoMethods(m); methods != nil && methods.IsInitialized != nil {
|
|
return methods.IsInitialized(m)
|
|
}
|
|
return isInitialized(m.ProtoReflect())
|
|
}
|
|
|
|
// IsInitialized returns an error if any required fields in m are not set.
|
|
func isInitialized(m pref.Message) error {
|
|
md := m.Descriptor()
|
|
fds := md.Fields()
|
|
for i, nums := 0, md.RequiredNumbers(); i < nums.Len(); i++ {
|
|
fd := fds.ByNumber(nums.Get(i))
|
|
if !m.Has(fd) {
|
|
return errors.RequiredNotSet(string(fd.FullName()))
|
|
}
|
|
}
|
|
var err error
|
|
m.Range(func(fd pref.FieldDescriptor, v pref.Value) bool {
|
|
switch {
|
|
case fd.IsList():
|
|
if fd.Message() == nil {
|
|
return true
|
|
}
|
|
for i, list := 0, v.List(); i < list.Len() && err == nil; i++ {
|
|
err = IsInitialized(list.Get(i).Message().Interface())
|
|
}
|
|
case fd.IsMap():
|
|
if fd.MapValue().Message() == nil {
|
|
return true
|
|
}
|
|
v.Map().Range(func(key pref.MapKey, v pref.Value) bool {
|
|
err = IsInitialized(v.Message().Interface())
|
|
return err == nil
|
|
})
|
|
default:
|
|
if fd.Message() == nil {
|
|
return true
|
|
}
|
|
err = IsInitialized(v.Message().Interface())
|
|
}
|
|
return err == nil
|
|
})
|
|
return err
|
|
}
|