mirror of
https://github.com/protocolbuffers/protobuf-go.git
synced 2024-12-29 12:17:48 +00:00
d6966a4431
The generator currently uses an unintuitive and stateful algorithm for name generation where it "fixes" name conflicts by appending "_" to the end of the new name. PR#657 refactored the generator code and noticed that the above algorithm was not properly taking into account that a Get method is generated for parent oneofs, fixing it in the same PR. While this is more correct, this breaks users (see #780) since it means that the generation of names can change. This PR changes the name mangling logic to be as it was previously. This does mean that some new proto files may be unbuildable, but that is arguably better than breaking existing proto files Change-Id: I2e354f4bb5d9c2b562fa2faa9149e949e2d86a0f Reviewed-on: https://go-review.googlesource.com/c/156877 Reviewed-by: Damien Neil <dneil@google.com>
10 lines
142 B
Protocol Buffer
10 lines
142 B
Protocol Buffer
syntax = "proto2";
|
|
|
|
package oneoftest;
|
|
|
|
message Foo {
|
|
oneof bar { // must be generated as Bar field in Foo struct
|
|
string get_bar = 1;
|
|
}
|
|
}
|