mirror of
https://github.com/protocolbuffers/protobuf-go.git
synced 2025-01-01 03:14:16 +00:00
3d0706ac2e
Make the fast-path and slow-path versions of IsInitialized report exactly the same errors: An errors.RequiredNotSet containing the full name of one of the unset required fields. Bugfix: Fast-path IsInitialized on a nil message reports an error only when the message directly contains required fields. Bugfix: Include fast-path IsInitialized in legacy messageIfaceWrapper. Fixes golang/protobuf#887 Change-Id: Ia5e4b386f8c23f6f855d995f4a098b1338acbae3 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/185397 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
61 lines
1.4 KiB
Go
61 lines
1.4 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style.
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package proto_test
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"google.golang.org/protobuf/internal/scalar"
|
|
"google.golang.org/protobuf/proto"
|
|
|
|
testpb "google.golang.org/protobuf/internal/testprotos/test"
|
|
)
|
|
|
|
func TestIsInitializedErrors(t *testing.T) {
|
|
for _, test := range []struct {
|
|
m proto.Message
|
|
want string
|
|
}{
|
|
{
|
|
&testpb.TestRequired{},
|
|
`proto: required field goproto.proto.test.TestRequired.required_field not set`,
|
|
},
|
|
{
|
|
&testpb.TestRequiredForeign{
|
|
OptionalMessage: &testpb.TestRequired{},
|
|
},
|
|
`proto: required field goproto.proto.test.TestRequired.required_field not set`,
|
|
},
|
|
{
|
|
&testpb.TestRequiredForeign{
|
|
RepeatedMessage: []*testpb.TestRequired{
|
|
{RequiredField: scalar.Int32(1)},
|
|
{},
|
|
},
|
|
},
|
|
`proto: required field goproto.proto.test.TestRequired.required_field not set`,
|
|
},
|
|
{
|
|
&testpb.TestRequiredForeign{
|
|
MapMessage: map[int32]*testpb.TestRequired{
|
|
1: {},
|
|
},
|
|
},
|
|
`proto: required field goproto.proto.test.TestRequired.required_field not set`,
|
|
},
|
|
} {
|
|
err := proto.IsInitialized(test.m)
|
|
got := "<nil>"
|
|
if err != nil {
|
|
got = fmt.Sprintf("%q", err)
|
|
}
|
|
want := fmt.Sprintf("%q", test.want)
|
|
if got != want {
|
|
t.Errorf("IsInitialized(m):\n got: %v\nwant: %v\nMessage:\n%v", got, want, marshalText(test.m))
|
|
}
|
|
}
|
|
}
|