Joe Tsai 32e8a52cbf internal/impl: fix race in aberrant message logic ...

Previously, when aberrantLoadMessageDesc returned it was guaranteed
to have initialized the current message through the use of the done signal.
However, this does not guarantee that the descriptor for a cylic reference
has also finished initialization.

Rather than add more complicated logic to wait until all cyclic references
have finished initializing, just add a global lock for the entire
aberrantLoadMessageDesc function.

This slows down performance, but is easier to reason about.

Change-Id: I4cdae8b955f71ee40fa6979f5a8d548d9749042c
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/184657
Reviewed-by: Damien Neil <dneil@google.com>

2019-07-02 18:39:06 +00:00

..

api_export.go

internal/impl: move legacy files into impl

2019-05-22 19:40:32 +00:00

codec_extension.go

internal/impl: unexport ExtensionField.Desc

2019-06-05 20:15:29 +00:00

codec_field.go

internal/impl: refactor fast-path

2019-06-27 20:08:19 +00:00

codec_message.go

internal/impl: refactor fast-path

2019-06-27 20:08:19 +00:00

encode_field.go

internal/impl: add fast-path for IsInitialized

2019-06-24 17:42:23 +00:00

encode_gen.go

proto, internal/impl: avoid string->[]byte conversions

2019-06-24 17:41:45 +00:00

encode_map_go111.go

internal/impl: add fast-path marshal implementation

2019-05-16 22:13:43 +00:00

encode_map_go112.go

internal/impl: add fast-path marshal implementation

2019-05-16 22:13:43 +00:00

encode_map.go

internal/impl: add fast-path for IsInitialized

2019-06-24 17:42:23 +00:00

encode_reflect.go

internal/impl: add fast-path for IsInitialized

2019-06-24 17:42:23 +00:00

encode_unsafe.go

internal/impl: add fast-path marshal implementation

2019-05-16 22:13:43 +00:00

encode.go

internal/impl: refactor fast-path

2019-06-27 20:08:19 +00:00

isinit.go

internal/impl: refactor fast-path

2019-06-27 20:08:19 +00:00

legacy_aberrant_test.go

internal/impl: fix race in aberrant message logic

2019-07-02 18:39:06 +00:00

legacy_enum.go

internal/impl: support aberrant enums and messages

2019-07-01 21:18:15 +00:00

legacy_export_test.go

all: move v1 types over to the v2 repository

2019-03-22 20:01:07 +00:00

legacy_export.go

all: change module to google.golang.org/protobuf

2019-05-14 17:28:29 +00:00

legacy_extension.go

internal/filedesc, internal/filetype: initial commit

2019-06-20 02:06:11 +00:00

legacy_file_test.go

reflect/protoreflect: remove FieldDescriptor.{Oneof,Extendee} methods

2019-06-17 19:43:30 +00:00

legacy_file.go

internal/filedesc, internal/filetype: initial commit

2019-06-20 02:06:11 +00:00

legacy_message.go

internal/impl: fix race in aberrant message logic

2019-07-02 18:39:06 +00:00

legacy_test.go

all: remove protoreflect.Message.Len

2019-06-25 21:59:46 +00:00

message_field.go

internal/impl: refactor fast-path

2019-06-27 20:08:19 +00:00

message_test.go

encoding/prototext: fix parsing of field names

2019-06-25 21:57:50 +00:00

message.go

internal/impl: refactor fast-path

2019-06-27 20:08:19 +00:00

pointer_reflect.go

internal/impl: abstract away ExtensionDescV1 as the underlying descriptor

2019-06-05 19:53:14 +00:00

pointer_unsafe.go

internal/impl: abstract away ExtensionDescV1 as the underlying descriptor

2019-06-05 19:53:14 +00:00