Joe Tsai 3034025d28 internal/impl: avoid inlining fixed coderFieldInfo array ...

Any attempt at guessing the size for a fixed coderFieldInfo array
will always get it wrong in some cases, either by under-estimating
or over-estimating the count. The former causes worse caching behavior,
while the latter causes memory waste.

As a middle ground, just pre-allocate a slice of the exact length.
Each element will have memory locality with each other, but not
be guaranteed to have memory locality with the parent coderMessageInfo.

name                            old time/op  new time/op  delta
EmptyMessage/Wire/Marshal-8     43.1ns ±11%  42.6ns ± 8%  -1.32%  (p=0.036 n=50+49)
EmptyMessage/Wire/Unmarshal-8   18.6ns ±10%  18.9ns ±12%    ~     (p=0.054 n=50+50)
EmptyMessage/Wire/Validate-8    15.0ns ± 9%  14.7ns ±10%  -2.44%  (p=0.002 n=50+45)
EmptyMessage/Clone-8             163ns ±20%   149ns ±19%  -8.58%  (p=0.000 n=48+53)
RepeatedInt32/Wire/Marshal-8    4.27µs ±12%  4.24µs ±13%    ~     (p=0.612 n=48+52)
RepeatedInt32/Wire/Unmarshal-8  3.47µs ±14%  3.50µs ±11%    ~     (p=0.217 n=50+53)
RepeatedInt32/Wire/Validate-8   2.12µs ±12%  2.09µs ± 9%    ~     (p=0.121 n=50+51)
RepeatedInt32/Clone-8           3.04µs ±18%  2.98µs ±36%    ~     (p=0.289 n=51+54)
Required/Wire/Marshal-8          281ns ±14%   276ns ±11%    ~     (p=0.059 n=48+55)
Required/Wire/Unmarshal-8        117ns ±14%   118ns ±11%    ~     (p=0.358 n=49+53)
Required/Wire/Validate-8        87.6ns ± 9%  88.0ns ±12%    ~     (p=0.373 n=48+53)
Required/Clone-8                 533ns ±12%   507ns ±15%  -4.71%  (p=0.000 n=49+54)

Change-Id: I4cf3134e424130bee728b7591127e5c80f07e2db
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/232937
Reviewed-by: Damien Neil <dneil@google.com>

2020-05-13 03:30:14 +00:00

..

api_export.go

internal/impl: minor refactoring

2020-04-02 00:23:08 +00:00

checkinit.go

all: rename IsInitialized as CheckInitialized

2020-02-20 20:45:40 +00:00

codec_extension.go

internal/impl: remove deprecated ExtensionField methods

2020-03-23 18:37:32 +00:00

codec_field.go

internal/impl: minor refactoring

2020-04-02 00:23:08 +00:00

codec_gen.go

internal/impl: validate UTF-8 for proto3 optional strings

2020-05-01 17:23:32 +00:00

codec_map_go111.go

internal/impl: rename encode->codec in various places

2019-07-08 20:12:42 +00:00

codec_map_go112.go

internal/impl: rename encode->codec in various places

2019-07-08 20:12:42 +00:00

codec_map.go

encoding/protowire: make package publicly available

2020-03-20 07:42:18 +00:00

codec_message.go

internal/impl: avoid inlining fixed coderFieldInfo array

2020-05-13 03:30:14 +00:00

codec_messageset.go

encoding/protowire: make package publicly available

2020-03-20 07:42:18 +00:00

codec_reflect.go

encoding/protowire: make package publicly available

2020-03-20 07:42:18 +00:00

codec_tables.go

internal/impl: validate UTF-8 for proto3 optional strings

2020-05-01 17:23:32 +00:00

codec_unsafe.go

internal/impl: rename encode->codec in various places

2019-07-08 20:12:42 +00:00

convert_list.go

all: improve extension validation

2020-04-23 06:01:13 +00:00

convert_map.go

all: improve extension validation

2020-04-23 06:01:13 +00:00

convert.go

all: improve extension validation

2020-04-23 06:01:13 +00:00

decode.go

encoding/protowire: make package publicly available

2020-03-20 07:42:18 +00:00

encode.go

internal/impl: check for size cache overflow

2020-02-24 20:12:47 +00:00

enum_test.go

all: remove {Enum,Message,Extension}Type.GoType methods

2019-10-07 21:08:26 +00:00

enum.go

all: remove {Enum,Message,Extension}Type.GoType methods

2019-10-07 21:08:26 +00:00

extension_test.go

all: trivial formatting changes

2020-02-25 21:59:54 +00:00

extension.go

internal/impl: add message validator

2020-01-07 21:36:47 +00:00

lazy_test.go

all: tests, tweaks for lazy extension decoding

2020-02-06 19:43:25 +00:00

legacy_aberrant_test.go

internal/impl: handle extremely old messages

2020-04-02 21:12:23 +00:00

legacy_enum.go

all: minor tweaks

2020-01-12 09:18:34 +00:00

legacy_export_test.go

all: move v1 types over to the v2 repository

2019-03-22 20:01:07 +00:00

legacy_export.go

all: use v2 Message interface for weak fields

2020-04-29 22:34:29 +00:00

legacy_extension.go

all: implement support for proto3 optional semantics

2020-04-29 20:02:24 +00:00

legacy_file_test.go

all: trivial formatting changes

2020-02-25 21:59:54 +00:00

legacy_file.go

internal/impl: make resolverOnly explicitly implement file resolver

2019-11-06 18:17:25 +00:00

legacy_message.go

internal/impl: handle extremely old messages

2020-04-02 21:12:23 +00:00

legacy_test.go

all: trivial formatting changes

2020-02-25 21:59:54 +00:00

merge_gen.go

all: remove stray "." from license headers

2020-02-20 18:54:38 +00:00

merge.go

all: fast-path method refactoring

2020-02-19 22:01:50 +00:00

message_reflect_field.go

all: improve panic messages for better debugability

2020-05-05 21:10:54 +00:00

message_reflect_gen.go

all: improve panic messages for better debugability

2020-05-05 21:10:54 +00:00

message_reflect_test.go

all: trivial formatting changes

2020-02-25 21:59:54 +00:00

message_reflect.go

all: improve panic messages for better debugability

2020-05-05 21:10:54 +00:00

message.go

all: use v2 Message interface for weak fields

2020-04-29 22:34:29 +00:00

pointer_reflect.go

internal/impl: weak field bugfixes

2019-10-04 17:07:45 +00:00

pointer_unsafe.go

all: improve panic messages for better debugability

2020-05-05 21:10:54 +00:00

validate.go

all: implement support for proto3 optional semantics

2020-04-29 20:02:24 +00:00

weak.go

all: use v2 Message interface for weak fields

2020-04-29 22:34:29 +00:00