mirror of
https://github.com/protocolbuffers/protobuf-go.git
synced 2024-12-29 12:17:48 +00:00
4069211bcd
Use the full path (including the extension) for the generation of the per-file variable name. Several reasons for this: * The current logic is buggy in the case where pathType == pathTypeImport since the prefix variable will be mangled with the Go import path. * The extension is technically part of the path. Thus, "path/to/foo.proto" and "path/to/foo.protodevel" are two distinctly different imports. * Style-wise, it subjectively looks better. Rather than being a mixture of camelCase and snake_case, it is all snake_case for the common case: before: ProtoFile_google_protobuf_any after: File_google_protobuf_any_proto * Since the extension is almost always ".proto", this results in a suffix of "_proto", which provides an additional layer of protection against possible name conflicts. The previous approach could possibly have a conflict between "Foo.proto" and a message named ProtoFile with a sub-message called Foo. Also, use the per-file variable name for the raw descriptor variables instead of the hashed version. Change-Id: Ic91e326b7593e5985cee6ececc60539c27fe32fe Reviewed-on: https://go-review.googlesource.com/c/164379 Reviewed-by: Damien Neil <dneil@google.com>
63 lines
1.5 KiB
Go
63 lines
1.5 KiB
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package protogen
|
|
|
|
import "testing"
|
|
|
|
func TestCamelCase(t *testing.T) {
|
|
tests := []struct {
|
|
in, want string
|
|
}{
|
|
{"", ""},
|
|
{"one", "One"},
|
|
{"one_two", "OneTwo"},
|
|
{"_my_field_name_2", "XMyFieldName_2"},
|
|
{"Something_Capped", "Something_Capped"},
|
|
{"my_Name", "My_Name"},
|
|
{"OneTwo", "OneTwo"},
|
|
{"_", "X"},
|
|
{"_a_", "XA_"},
|
|
{"one.two", "OneTwo"},
|
|
{"one.Two", "One_Two"},
|
|
{"one_two.three_four", "OneTwoThreeFour"},
|
|
{"one_two.Three_four", "OneTwo_ThreeFour"},
|
|
{"_one._two", "XOne_XTwo"},
|
|
{"SCREAMING_SNAKE_CASE", "SCREAMING_SNAKE_CASE"},
|
|
{"double__underscore", "Double_Underscore"},
|
|
{"camelCase", "CamelCase"},
|
|
{"go2proto", "Go2Proto"},
|
|
{"世界", "世界"},
|
|
{"x世界", "X世界"},
|
|
{"foo_bar世界", "FooBar世界"},
|
|
}
|
|
for _, tc := range tests {
|
|
if got := camelCase(tc.in); got != tc.want {
|
|
t.Errorf("CamelCase(%q) = %q, want %q", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestCleanGoName(t *testing.T) {
|
|
tests := []struct {
|
|
in, want string
|
|
}{
|
|
{"", "_"},
|
|
{"boo", "boo"},
|
|
{"Boo", "Boo"},
|
|
{"ßoo", "ßoo"},
|
|
{"default", "_default"},
|
|
{"hello", "hello"},
|
|
{"hello-world!!", "hello_world__"},
|
|
{"hello-\xde\xad\xbe\xef\x00", "hello_____"},
|
|
{"hello 世界", "hello_世界"},
|
|
{"世界", "世界"},
|
|
}
|
|
for _, tc := range tests {
|
|
if got := cleanGoName(tc.in); got != tc.want {
|
|
t.Errorf("cleanGoName(%q) = %q, want %q", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|