mirror/protobuf-go
1
0
Fork 0
mirror of https://github.com/protocolbuffers/protobuf-go.git synced 2025-01-01 11:58:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
Go support for Google's protocol buffers
312 Commits 1 Branch 27 Tags 20 MiB
Go 99.8%
Shell 0.2%
03e748680c
Go to file
Damien Neil 03e748680c proto: replace CachedSize fast-path method with UseCachedSize option 
Using an option instead of a separate method has several useful properties:

It makes it explicit whether the fast-path AppendMarshal is expected to use
cached sizes or not.

It properly plumbs the decision to use cached sizes through the call stack.
Consider the case where message A includes B includes C: If A and C support
cached sizes but B does not, we would like to use the size cache in all
messages which support it. Placing this decision in the options allows this
to work properly with no additional effort.

Placing this option in MarshalOptions permits users to request use of
existing cached sizes. This is a two-edged sword: There are places where
this ability can permit substantial efficiencies, but this is also an
exceedingly sharp-edged API. I believe that on balance the benefits
outweigh the risks, especially since the prerequisites for using
cached sizes are intuitively obvious. (You must have called Size, and
you must not have changed the message.)

This CL adds a Size method to MarshalOptions, rather than adding a SizeOptions
type. Future additions to MarshalOptions may affect the size of the encoded
output (e.g., an option to skip encoding unknown fields) and using the same
options for both Marshal and Size makes it easier to use a consistent
configuration for each.

Change-Id: I6adbb55b717dd03d39f067e1d0b7381945000976
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/171119
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
2019-04-08 05:14:36 +00:00
cmd proto, runtime/protoiface: add support for fast-path marshaling 2019-04-02 21:23:04 +00:00
encoding proto: add IsInitialized 2019-04-05 22:21:46 +00:00
internal internal/encoding/json: improve Value.Int,Uint by reducing allocations 2019-04-06 04:16:05 +00:00
proto proto: replace CachedSize fast-path method with UseCachedSize option 2019-04-08 05:14:36 +00:00
protogen internal/fieldnum: generate field numbers for the google.protobuf package 2019-03-21 00:57:40 +00:00
reflect proto, runtime/protoiface: add support for fast-path marshaling 2019-04-02 21:23:04 +00:00
runtime proto: replace CachedSize fast-path method with UseCachedSize option 2019-04-08 05:14:36 +00:00
types proto, runtime/protoiface: add support for fast-path marshaling 2019-04-02 21:23:04 +00:00
.gitignore cmd/protoc-gen-go/testdata: ignore go.sum 2019-03-11 20:19:03 +00:00
.travis.yml .travis.yml: configure for OSX 2019-03-13 18:04:08 +00:00
AUTHORS AUTHORS, CONTRIBUTORS, LICENSE, PATENTS: initial commit 2018-08-07 22:39:48 +00:00
CONTRIBUTING.md CONTRIBUTING.md: add pre-push hook instructions 2018-08-07 23:58:41 +00:00
CONTRIBUTORS AUTHORS, CONTRIBUTORS, LICENSE, PATENTS: initial commit 2018-08-07 22:39:48 +00:00
go.mod cmd/protoc-gen-go: generate for v2-only dependencies 2019-03-26 17:03:31 +00:00
go.sum cmd/protoc-gen-go: generate for v2-only dependencies 2019-03-26 17:03:31 +00:00
integration_test.go proto: enable/disable fast path with build tags 2019-04-07 17:00:00 +00:00
LICENSE AUTHORS, CONTRIBUTORS, LICENSE, PATENTS: initial commit 2018-08-07 22:39:48 +00:00
PATENTS AUTHORS, CONTRIBUTORS, LICENSE, PATENTS: initial commit 2018-08-07 22:39:48 +00:00
README.md CONTRIBUTING.md: initial commit 2018-08-01 20:39:06 +00:00
regenerate.bash internal/cmd/generate-protos: generate test for testdata 2019-03-11 19:40:53 +00:00
test.bash internal/cmd/generate-protos: generate test for testdata 2019-03-11 19:40:53 +00:00

README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.