protobuf-go/testing/prototest
Michael Stapelberg 575aebf635 internal/impl: revert IsSynthetic() check to fix panic
This reverts change https://go.dev/cl/632735, in which
I misunderstood what the Protobuf documentation wanted to convey:
The quoted docs in CL 632735 refer to reflection for proto3 optional
fields, not to reflection for proto3 synthetic oneofs.

Synthetic oneofs should remain visible through reflection.
For the Open API, this change restores the old behavior.
For the Opaque API, another fix is needed and will be sent
in a separate, follow-up CL (follow golang/protobuf#1659).

For golang/protobuf#1659

Thanks to Joshua Humphries for the report and reproducer!

Change-Id: I3a924eed6d2425581adc65651395a68fc1576f4d
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/638495
Reviewed-by: Chressie Himpel <chressie@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-12-23 04:34:27 -08:00
..
enum.go
message.go internal/impl: revert IsSynthetic() check to fix panic 2024-12-23 04:34:27 -08:00
prototest_test.go encoding/protojson: add protojson editions tests including fuzztests 2024-02-23 08:35:31 +00:00