Commit Graph

3 Commits

Author SHA1 Message Date
Joe Tsai
9118b11cd8 all: update contributing documentation
Change-Id: I2815e570696fd5ffc765c42ffc26060fc4aa5a2b
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/220677
Reviewed-by: Damien Neil <dneil@google.com>
2020-02-24 22:15:07 +00:00
Joe Tsai
dd8f2fa63e CONTRIBUTING.md: add pre-push hook instructions
Now that we have a test.bash script that does comprehensive testing,
add instructions to CONTRIBUTING.md for how to install the hook.

We use a pre-push hook, rather than a pre-commit hook (which is more common)
since we're more interested in making sure the changes are correct just prior
to a user sending out code for review.

It is common for a user to continually add new files and/or update the commit
message. It would be annoying running the tests for every one of those operations.

Change-Id: I084a74fdb7f601d8075b3e349c7ee854b3b9394b
Reviewed-on: https://go-review.googlesource.com/128364
Reviewed-by: Herbie Ong <herbie@google.com>
2018-08-07 23:58:41 +00:00
Joe Tsai
a19bc9bfc6 CONTRIBUTING.md: initial commit
Change-Id: Ic9a678d890e622628db4677cce93d4f8be39003f
Reviewed-on: https://go-review.googlesource.com/127336
Reviewed-by: Damien Neil <dneil@google.com>
2018-08-01 20:39:06 +00:00