3 Commits

Author	SHA1	Message	Date
Damien Neil	a8a2cea3e7	proto: move T->*T wrappers from internal/scalar to proto ... Usage of these is pervasive in code which works with proto2, and proto2 will be with us for a long, long time to come. Move them to the proto package. Change-Id: I1b2e57429fd5a8f107a848a4492d20c27f304bd7 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/185543 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>	2019-07-12 17:35:01 +00:00
Damien Neil	a9940822d4	all: remove protoreflect.Message.Len ... Len looks like it should be O(1), but the need to check for non-zero-length repeated fields makes it at minimum O(n) where n is the number of repeated fields. In practice, it's O(n) where n is the number of fields altogether. The Len function is not especially useful, easily duplicated with Range and a counter, and can be surprisingly inefficient. Drop it. Change-Id: I24b27433217e131e842bd18dd58475bcdf62ef97 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/183678 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>	2019-06-25 21:59:46 +00:00
Joe Tsai	ef75becaa8	proto: fix memory aliasing bug in Reset ... Fix a bug where using Message.Range alone does not clear memory references for empty, but allocated lists and maps. Thus, we iterate over every known field and explicitly call Clear. Change-Id: I9c1847d4056cf66f3199947150f3140d0783444a Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/183197 Reviewed-by: Damien Neil <dneil@google.com>	2019-06-20 19:48:37 +00:00